Little Domestic Advisor Bug

Elhoim

Iron Tower Studio Dev
Joined
Nov 3, 2004
Messages
2,897
Location
San Isidro, Argentina.
The domestic advisor has a little bug. Instead of showing the gold a city generates, it shows the commerce. Why do I call it a bug and not a dev decision? Because of this line in the CvDomesticAdvisdor:

# Gold Column
screen.setTableColumnHeader( "CityListBackground", 12, "<font=2>" + (u"%c" % gc.getYieldInfo(YieldTypes.YIELD_COMMERCE).getChar()) + "</font>", 40 )

It is called Gold Column, BUT it shows YIELD_COMMERCE. I´ll try to fix it myself...

EDIT: Can´t do it. Anyone with more experience? I just want to replace commerce with gold, not even add a new column. Thanks in advance for any advice!!

EDIT 2: After some research, I tried something.

# Gold Column
screen.setTableColumnHeader( "CityListBackground", 12, "<font=2>" + (u"%c" % gc.getCommerceInfo(CommerceTypes.COMMERCE_GOLD).getChar()) + "</font>", 40 )

I get the gold icon in the column, but the info is still the commerce :sad:
Any kind of help is appreciated!

(setTableColumnHeader: That should have told me something :p)

EDIT 3: I´ve done it! After changing this little line of code from this:

# Gold status...
screen.setTableInt( "CityListBackground", 12, i, unicode(pLoopCity.calculateGoldRate()), "", WidgetTypes.WIDGET_GENERAL, -1, -1, CvUtil.FONT_LEFT_JUSTIFY )

To this:

# Gold status...
screen.setTableInt( "CityListBackground", 12, i, unicode(pLoopCity.getGoldRate()), "", WidgetTypes.WIDGET_GENERAL, -1, -1, CvUtil.FONT_LEFT_JUSTIFY )

And of course adding this little line in PyHelpers under general city functions:

def getGoldRate(self):
return self.city.getCommerceRate(CommerceTypes.COMMERCE_GOLD)

Now it shows gold instead of commerce :D

Thanks to Requies, because I compared his mod with the original files, and used his line of code from DomPyHelpers. If anyone is interested in this little change I might consider posting it. It´s not a big mod, but that was something that bothered me, and I usually like to keep things simple and closer to the original.
 
Back
Top Bottom