Modmodding Q&A Thread

[Novicenoble]

Is there any easy way to modify the CivWBSave files? Do you manually change numbers when you add new civ into it?

 

[Leoreth]

Yeah. With search and replace it's comparatively efficient, but it's still easily the most annoying part of adding a civ.

 

[Novicenoble]

Can you give me a hint/idea/whatever something like that about this kind of problem? This error occurred when I launched 1700AD scenario with modified files. I guess there might be some problems in the WBsave file, but cannot sure about it.

Spoiler :

 

[Leoreth]

Can you give me a hint/idea/whatever something like that about this kind of problem? This error occurred when I launched 1700AD scenario with modified files. I guess there might be some problems in the WBsave file, but cannot sure about it.

There definitely is. Something about civ and team IDs does not line up.

If you want to debug it, copy CvWBDesc.py from Beyond the Sword\Assets\Python\pyWB\ into the corresponding folder in DoC (I have it there as well), and add some output of the current tile to the line mentioned in the exception. That should lead you to the part of the WBSave that causes the problem.

 

[Novicenoble]

Thanks for advice. I will try it

Another question. When the AP is activated and independent civ have the AP, then is it possible to make contact between every civ that have contact with independent civ?

 

[Leoreth]

Isn't it currently that the AP establishes contact between all Catholic civs anyway?

 

[Novicenoble]

Non Catholic ones in this case.
Well it seems like even AP was not boosting Catholic because there was no hammer bonus until HRE conquered it.


I'm currently working based on 1.12v, so there might was some changes until now.

 

[Novicenoble]

Can you give me a hint/idea/whatever something like that about this kind of problem? This error occurred when I launched 1700AD scenario with modified files. I guess there might be some problems in the WBsave file, but cannot sure about it.

Spoiler :

Another question about this problem. Does the tile reveal part can cause the problem?

 

[Leoreth]

No, it's when the WBSave is parsed while loading it, so before anything else happens in the game.

 

[Novicenoble]

Spoiler :

About AP. I think I didn't changed something related with AP but it goes like this. No hammer bonus on Catholic, Inquisition on Khmer, such kind of things.
Happened in 600AD start and when I checked with WB, independent civ still controls Rome. :/
This kind of problem seems not happening with original 1.12v, so I think it is caused by map modification.

Do you have any idea?

 

[Leoreth]

Not really.

 

[ales_]

Swahili? Nice.

 

[Novicenoble]

Hmm...

Please let me know if there is any specific codes about assigning AP into specific religion (Catholic in this case.) I wonder how AP assigned to Catholic in 600AD start, because I didn't saw any info storage for that.

Added: To specify the question more: How does AP works as the Catholic wonder when it is controlled by independent civ? (Which is non Catholic)

 

[Leoreth]

It doesn't matter who controls the AP, it is invariably linked to the state religion of the civ that built it. I don't really know what happens when it is present at the start of a scenario but considering it works in the base mod, you must have changed something that affects this. The code for the AP is in CvGame.cpp.

 

[Novicenoble]

I may need to touch about that part :/

Quick question about that. Is there any possible case that AP is not running with Catholic when game runs normally?

 

[Leoreth]

As I said, the AP is assigned to the state religion of the civ that builds it. If you're not Catholic, you cannot complete the AP. So ...

 

[Novicenoble]

ReligionTypes CvGame::getVoteSourceReligion(VoteSourceTypes eVoteSource) const
{
	stdext::hash_map<VoteSourceTypes, ReligionTypes>::const_iterator it;

	it = m_mapVoteSourceReligions.find(eVoteSource);
	if (it == m_mapVoteSourceReligions.end())
	{
		return NO_RELIGION;
	}

	return it->second;
}

Is there any method that can read out religion type in cpp?
I'm trying to change return NO_RELIGION; part into return CATHOLIC; or such kind of thing, but I cannot find any code that defines religion in cpp files.

 

[Leoreth]

It's either defined as CATHOLICISM or RELIGION_CATHOLICISM, either in CvRhyes.h or CvEnums.h.

Note that the UN is also a VoteSource, so simply hard coding this might have unintended consequences.

 

[Novicenoble]

I realized that independent civ even cannot make AP resolution in normal way..
Yeah, seems like whole AP thing is somewhat screwed in unknown way

 

[Novicenoble]

Is there any code that disables AP when Independent civ controlling the AP? I found this in the code:

bool CvGame::isTeamVoteEligible(TeamTypes eTeam, VoteSourceTypes eVoteSource) const
{
	CvTeam& kTeam = GET_TEAM(eTeam);

	//Rhye - start
	if (eTeam == INDEPENDENT || eTeam == INDEPENDENT2 || eTeam == NATIVE || eTeam == CELTIA || eTeam == SELJUKS)
	{
		return false;
	}
	//Rhye - end

But it seems like doesn't working. Is it all of the code related with disabling votes or is there any other?