Policy free buildings not clearing queue

[ExpiredReign]

I've only just noticed this now as the game I was playing forced me to change my policy play style mid-game.

Anyway, when you select a policy that gives a free building, the building queue does not clear it from production.

Vanilla Civ does and Civup/GEM still does with Wonders.

To be 100% correct the queue isn't immediately cleared as you would imagine. I don't know if it would clear eventually in a matter of turns, but same turn is preferred.
I'm not sure how often the code checks the queue to remove it, but it surely should be on the same turn as when the policy is selected.

 

[ExpiredReign]

Is there a missing XML tag in the GEP_Tradition.xml?

Maybe

<OneShot>true</OneShot>

?

Although I don't understand all the code in CiVUP_Events.lua the functions:
DoPolicyFreeBuildingClasses and DoPolicyFreeBuildingFlavors look OK but I'm not sure.

Any ideas?

 

[Thalassicus]

Hmm this is something I hadn't considered before. I don't know how to remove things from a build queue. I've put it on my todo list.

 

[agc28]

Does the "free culture building in oldest 5 cities" consider city hall in its equation? What about razed enemy cities?

I built monument in all my 5 cities, excluding the already-razed ones of course. But i only got theatre in two cities.

 

[Thalassicus]

Culture buildings are buildings good for culture (the "good for" section of tooltips). I've thought of a way I could restrict these free-building policies to the buildings we expect... hm. I'll experiment with it in the next round of updates.

 

[ExpiredReign]

I'm only guessing here.

In the Vanilla game the policies that provide free buildings had that extra TAG attached to them.

Also Wonders clear the queue automatically so there must be something built-in to the base code to handle the process.

But like I said, I'm only guessing.

 

[ExpiredReign]

Ok in a fresh game as Korea on a PerfectWorld3 map I started production of the Place on turn 14 with 205 +12, it would take 10 turns to complete.

On turn 18 I decided to take the Liberty policy (which grants free palaces). I had 251 + 10.
The following turn the queue was cleared and I started the Monument 263 +13.

First thing to mention is now the queue is being cleared but there is no compensation. There was 6 turns left to complete the palace. Thats 60% of its cost to be reimbursed.

Anyway. I kept playing and on turn 34 a message scrolled up the middle of the screen saying "Seoul can no longer continue building the palace and ....." I didn't catch all of it as more notifications about citystates and barbarian encampments appeared. Curiously the message about Seoul did not show up in the Notification Log but the others did.

So I quit to the menu and loaded an automatic save from turn 10 and replayed the same way to see what the message was.

This time no message appeared. I kept playing for another 30 turns thinking it might show later. Nope. No luck.

This raises a number of questions.
The timing of the on screen messaages about build events is tied to what?
The reimbursement of for free buildings.
What determines whether a message goes in the Notification Log?

Sorry I did not save a log the first time through and as the message didn't appear this time I am unsure on what turn to generate one now.