Should probably be gc.getTypesEnum("FLAVOR_MILITARY"). getInfoTypeForString is only for enum types with an associated Cv...Info class.
Quick Modding Questions Thread
- Thread starter kiwitt
- Start date
mysterious_stalker
Chieftain
- Joined
- Jan 21, 2018
- Messages
- 89
So I've been messing around with RFC RAND's CityNameManager.py
Note that this is the new city name list, which doesn't work. Essentially, I've replaced a name, e.g. "Ur", with a 2-place list.
Similarly, I've edited the implementation in the function, adding a 4th nested list call ([0], since I want it to get the string with the city name) in here:
I have only added the [0] in assignName and converted "city name" to ["city name", 90], 90 being unused as of now. I get a syntax error, though. Can anyone tell me what I've done wrong?
Spoiler Sample civ city names :
Similarly, I've edited the implementation in the function, adding a 4th nested list call ([0], since I want it to get the string with the city name) in here:
Spoiler assignName :
I have only added the [0] in assignName and converted "city name" to ["city name", 90], 90 being unused as of now. I get a syntax error, though. Can anyone tell me what I've done wrong?
Last edited:
CaptainLost
Oberleutnant
I love Civfanatics and you. Thank you.
First of all, this isn't your fault but reading Rhye's code makes me sick.
But to summarise, you changed "Uruk" to ["Uruk", 90] and cityName = lCityLists[iOwner][iArea][self.getCityListsPointers(iOwner, iArea)] to cityName = lCityLists[iOwner][iArea][self.getCityListsPointers(iOwner, iArea)][0]? Looks right. What is the syntax error you are getting exactly? It should point you to the actual line at fault.
mysterious_stalker
Chieftain
- Joined
- Jan 21, 2018
- Messages
- 89
It's pointing to the line that initiates class CityNameManager. It doesn't really help me in any way, because as you said, it looks right, and I'm really not sure what the problem would be.
To clarify what that class contains, it starts right above my 2nd spoiler in the original post. There are other things inside the class, but I haven't changed any of them.
Spoiler class :
lCityListPointers is basically a 2-level list like this:
'lCityListsPointers': [[0, 0, 0, 0],
[...]
[0, 0, 0, 0]],
(number of 4-place 0-lists equal to the number of civs it seems)
Last edited:
mysterious_stalker
Chieftain
- Joined
- Jan 21, 2018
- Messages
- 89
Yes, it's indeed lCityLists.
Here's the error log:
Spoiler PythonErr :
Line 1698 is the start of class CityNameManager.
How strange. Sometime this means the error is actually in the preceding line, e.g. due to a bracket not being closed. Things like this are easily erased when moving code around. Or maybe there are errors in your indentation?
Usually you do not get a syntax error in the class declaration if there are errors further down in the class. You would get an error at the line where the invalid syntax actually is.
Usually you do not get a syntax error in the class declaration if there are errors further down in the class. You would get an error at the line where the invalid syntax actually is.
mysterious_stalker
Chieftain
- Joined
- Jan 21, 2018
- Messages
- 89
It was. Turns out I was missing a bracket at some point. It was inside the quotes rather than outside (although I have no clue how it happened). Thanks!
CaptainLost
Oberleutnant
Anyone know of a documentation for the SDK? Just what each file does. I know the Modiki started on it but it only has like 2 files there.
mysterious_stalker
Chieftain
- Joined
- Jan 21, 2018
- Messages
- 89
Spoiler code snippet :
Also note that I only display the part of the code relevant to this problem. There are no syntax errors.
Spoiler debug log :
That's where the list ends, with cities founded by the other 3 major civs before me. However, cities founded by the minor Independent civs also exist at this point and they are not accounted for.
I am not familiar with PyGame.getCivPlayerList, but it seems like it is not suitable to your needs. But if you want to just iterate all players, you can much more easily do something like this:
range(n) will give you a sequential list of 0, 1, 2, ..., n-1, e.g. range(3) == [0, 1, 2]. gc.getMAX_PLAYERS() gives you the number of players in the game. If it's an RFC mod, there also should be something like an iNumPlayers constant that is equivalent.
Also you usually do not have to think in list indices, "for x in list" will simply iterate the list one by one and assign its elements to x.
Lastly, the print statement should output things like "City list for Egypt: [u'Niwt-Rst']".
Let me know if you're trying to accomplish something else. But by simply iterating all players yourself, you can skip your issue with minor civs.
Code:
for iPlayer in range(gc.getMAX_PLAYERS()):
print "City list for %s: %s" % (CyGlobalContext().getPlayer(iPlayer).getCivilizationShortDescription(0), PyPlayer(iPlayer).getCityList)Also you usually do not have to think in list indices, "for x in list" will simply iterate the list one by one and assign its elements to x.
Lastly, the print statement should output things like "City list for Egypt: [u'Niwt-Rst']".
Let me know if you're trying to accomplish something else. But by simply iterating all players yourself, you can skip your issue with minor civs.
mysterious_stalker
Chieftain
- Joined
- Jan 21, 2018
- Messages
- 89
That did the trick, thanks!
Dumanios
Hakugyukurou Gardener
- Joined
- Oct 24, 2008
- Messages
- 4,924
So I tried to add the Philippines as a civ in my mod and wanted have the Philippines as America's derivative civilization. However, when I try to release a colony as America, I get one of the base game civilizations (khmer, zulu, etc) rather than the Philippines.
I don't know if its something wrong with the XML setup or if its a code peculiarity with Civ 4 or how Civ4 reads Modular files.
I also did some looking at other mods to see how derivative civs worked in general. What I've noticed is that if the Derivative civ points to one of the 34 base BTS civs, it will work as it should - England always releases America, for example. But if the normal derivative already exists or points to a non-base game civ, the derivative civ functions seem to show a strong bias towards the base 34 civs - this is most noticeable in Civ Gold due to the amount of new civs in Civ Gold.
I don't know if its something wrong with the XML setup or if its a code peculiarity with Civ 4 or how Civ4 reads Modular files.
Spoiler America XML, check bold :
Spoiler Filipino XML :
I also did some looking at other mods to see how derivative civs worked in general. What I've noticed is that if the Derivative civ points to one of the 34 base BTS civs, it will work as it should - England always releases America, for example. But if the normal derivative already exists or points to a non-base game civ, the derivative civ functions seem to show a strong bias towards the base 34 civs - this is most noticeable in Civ Gold due to the amount of new civs in Civ Gold.
LPlate2
Warlord
- Joined
- Dec 27, 2018
- Messages
- 299
Hi,
When working with units which are casting delayed spells (based on FFH), how do you stop the casting early?
The spell prerequisites will be tested when a spell is initially casted. If the situation changes during the delay period, can a spell casting be stopped?
What should I put after this line?
When working with units which are casting delayed spells (based on FFH), how do you stop the casting early?
The spell prerequisites will be tested when a spell is initially casted. If the situation changes during the delay period, can a spell casting be stopped?
What should I put after this line?
Code:
if pLoopUnit.getDelayedSpell() == gc.getInfoTypeForString (iSpell):If the effect is entirely python, you can put a check at the start of the <PyResult> function, like that:
Code:
def spellInquisition(caster):
pPlot = caster.plot()
# The city may have been razed while the spell is being cast.
if not pPlot.isCity():
return
[...]LPlate2
Warlord
- Joined
- Dec 27, 2018
- Messages
- 299
Thanks @Ifgr but the pyresult will only be triggered at the end of the delay (some of mine will be quite long), which is why I was hoping to be able to interrupt a casting.
I think I'll just have to invest more time in spell prerequisites and other python permissives (your complicated option).
I think I'll just have to invest more time in spell prerequisites and other python permissives (your complicated option).
<Nexus>
Traveler of the Multiverse
In CIV4CorporationInfo.xml there is the tag <PrereqBonuses> which can contain up to 6 resources but it you add more the just doesn't start.
Anyone knows where this "max 6 resources" limit is defined? Exe, dll or some python file?
Anyone knows where this "max 6 resources" limit is defined? Exe, dll or some python file?
