Thoughts about some tweaks

Leoreth · Apr 11, 2012

Scripting is not programming, though. I'm pretty sure the core of Oblivion is also coded in C++ or a similar language.

Thor Macklin · Apr 11, 2012

SO issue. How DO I give the mongols conquest? I added it in the World Build Map but a turn after I started it it reverted to subjugation.

Leoreth · Apr 11, 2012

You mean Occupation? They need the necessary tech, otherwise it will flip back to the standard civic. Exceptions like Egypt's UP need to be coded in the DLL.

Thor Macklin · Apr 11, 2012

So I found out. Where in the DLL?

in other news. I'm considering adding special features to each religion. So far Islam is the only one I have a definite idea for. Basically making Mosques and Temples work as high-powered courthouses. Allowing players to conquer and not worry too strongly about the costs.

srpt · Apr 11, 2012

I think if you open all the .cpp files at once in Notepad++ and search for "EGYPT" you will find it. I remember copying that change and it was not hard to figure out what to do. then you have to compile.

Thor Macklin · Apr 11, 2012

wait....I am technologically illiterate. Explain compiling to me.

migck · Apr 11, 2012

Thor Macklin said:
wait....I am technologically illiterate. Explain compiling to me.

This has some useful info http://modiki.civfanatics.com/index.php/Civ4_SDK

And about my 'futile' efforts at Better AI and RAND...
I managed to merge and compile them! And the game fired!... and of course on starting a new game the Autoplay sequence doesn't work and all civs spawned at once :lol:

. But at least I learned some things (like how to spot a function header :mischief:

), so I will try again, and again, until I inevitably succeed! :rolleyes:

Leoreth · Apr 11, 2012

Unlike Python code, C++ can't be interpreted by the game directly, but has to be compiled to machine code so the game can "understand" it. That's done by a C++ compiler that has the Civ4 Software Development Kit (SDK) installed. You can learn how to do that here.

It may look daunting at first, but it's really an easy step-by-step guide.

The method you're looking for is CvPlayer::canDoCivic(), by the way.

Thor Macklin · Apr 12, 2012

Okay I searched line-by-line and honestly I have no idea what I am looking for. Egypt has the misfortune of being named 0 in the python script so it is hard for me to find what line i need to edit

srpt · Apr 12, 2012

its not in the Python folder. its in the CvGameCoreDLL folder. the file is CvPlayer.cpp

Thor Macklin · Apr 12, 2012

As I have found.

In essence what we are doing right now is a remake of DOC?

migck · Apr 13, 2012

Wow, I finally made it!! :rockon:

Autoplay works fine, everything seems to work fine! I can't believe it.
There were some very uneasy spot, particularly in CvPlayerAI and CvUnitAI.cpp, which Better AI had changed almost completely, and I wonder if my merge there has been adequate. Off the top of my head, I've kept the Better AI code for defensive pacts, which can be customized in the xml, and I haven't merged Rhye's code for targeting minor civs' cities since I didn't know how to convert it to Better AI format.
There's undoubtedly some tiny errors here or there, things which could have done better due to my lack of knowledge, but the end result is definitely Better AI + RAND!
Plus a few more things:

Spoiler :

Now, to merge the Epic and Marathon game speeds, and maybe some more. I wonder what would be a good name for this project? Better RAND AI? Rhye's and Fall of the AI?

Also, for my idea about the Arabian UP, where would be the code that controls the behavior of PrereqBuildingClasses?

EDIT: first problem I've encountered, and quite bad. the AI is stockpiling settlers, but building few to no cities. In an American start, almost no civ had built more than two cities, China, Mongolia and Russia had 5 settlers in the capital and no cities beside it. The European civs had built some cities in the new world.
Any ideas about what could cause this? I honestly have none...

EDIT2: seems like I have orphaned content out of CvPlayerAI::AI_foundValue. Now to figure out where is the bracket causing the mess... Any tips about C++ I should know to deal with such cases? EDIT3: a bracket has to be commented like // }, not like //} it seems... :run:

migck · Apr 14, 2012

I corrected errors, but to no avail, the AI is simply not founding any cities :cry:

I've settled for a merge with the regular Unofficial Patch 1.6, at least I can make full sense of its changes, and after trying the result out the AI is back to building cities as always. The merge with Better AI is therefore postponed indefinitely... because after so much coding without knowing code I just want to play, dammit

Thor Macklin · Apr 16, 2012

In other news I continue to encounter a terrible annoying issue with Arabia. (Although giving the camels the drill promotions helps) Generally the civ seems downright fearful of trying to attack north africa. Maybe it's just my map edits but overall it is just...annoying to me.

migck · Apr 16, 2012

Leoreth said:
Easiest solution is to add a Python callback to all events that verifies that the player isn't a minor.

Now that I'm looking into this, I'm thinking of barring all events to barbarians and minors directly in the SDK. I found what might be the code controlling them globally, in

Code:

bool CvPlayer::canDoEvent(EventTypes eEvent, const EventTriggeredData& kTriggeredData) const

Is that the basest function which determines whether an event can happen at all? If so, I assume I just have to add there:

Code:

if (GET_PLAYER(kTriggeredData.m_eOtherPlayer).isBarbarian() || GET_PLAYER(kTriggeredData.m_eOtherPlayer).isMinorCiv())
{
	return false;
}

The thing is, I didn't found an isBarbarian() check there, but events can't target barbarians in any way already AFAIK, neither they can have it nor can they target them from another civ. Would the function/s I'm looking for be somewhere else then?

My next target, remove the minors from the diplomacy screen and from any AI considerations regarding relations to other players.

Thor Macklin said:
In other news I continue to encounter a terrible annoying issue with Arabia. (Although giving the camels the drill promotions helps) Generally the civ seems downright fearful of trying to attack north africa. Maybe it's just my map edits but overall it is just...annoying to me.

I had Arabia conquering and holding North Africa and making Spain its vassal once, but not in time for their UHV. Pretty exceptional though. Generally speaking, if you want the AI to act competently, you have to lead them yourself

Thor Macklin · Apr 16, 2012

Yes indeed XD.

Although as a quick note I found that adding baghdad as a byzantine city (I might even make persia byzantine. If anything just to represent the Sassanids at the time rather then just vague city-states) Has encouraged the arabs to head east. Almost always conquering up to India.

Alas they still leave NA alone -__-. Now of course I did remove alexandria and hesperides and replaced them with Berenice.

Could be the reason.

Leoreth · Apr 16, 2012

No idea where the barbarians are excluded, but what you're proposing there should work at least.

Thor Macklin · Apr 16, 2012

valid point. You do mean representing the Sassanids with barbs yes?

In other news. I thought of giving the Jans the leadership promotion. But at the same time remove the ability to upgraade them to Riflemen.

Why do this? Bbecause I still want the ottomans to be able to fight on par with other units using highly-promoted janissaries. But by the time Infantry rolls around you'll probably had to have dispensed of the long-outdated janissaries.

migck · Apr 21, 2012

To prevent the possibility of all my work being lost, and mainly because I want to share with other Civ players what has been my first contact with SDK, Python, XML, and Civ modding in general all at once, I'm intending to release my work so far, with proper credits to the work of everyone involved. The problem is that the final product is 700MB big, 200MB without the .FPK files from Varietas Delectat, so I'm going to have problems hosting it.

I have read the file upload guide, http://www.civfanatics.com/misc/guides/file_upload, so it would seem I need an external host. ModDB seems too professional for the scope of this, which is mainly an amalgamation of already existent mods with my tweaks here and there.

Sorry to be asking this, which seems a bit out of context, but anyone could suggest me what to do if I wanted to release this? Or should I release it at all?

Tomorrow's Dawn · Apr 21, 2012

The better question is, what are you going to name this modmod?

Thoughts about some tweaks

Bofurin

Warlord

Bofurin

Warlord

Deist

Warlord

Señor de la guerra

Bofurin

Warlord

Deist

Warlord

Señor de la guerra

Señor de la guerra

Warlord

Señor de la guerra

Warlord

Bofurin

Warlord

Señor de la guerra

Heroes Never Die

Similar threads