v145.4 trade opportunities display bug

[pawwh98]

In my trade opportunities window, wrong icons are shown for the attitude of other civilizations:

 

[Thalassicus]

Thanks for reporting this. I think I've fixed it for v146.

Firaxis designed this part of the game in a confusing way. Their code reads:

g_pPlayer:GetApproachTowardsUsGuess(iPlayerLoop)

There's no indication of which player is which. I assumed it reads:

"Get their opinion of us."
them:GetApproachTowardsUsGuess(us)
​

That makes sense, right? It appears that the programmer used ambiguous names and wrote the function backwards. It actually works like:

"For us, get the opinion from them."
us:GetApproachTowardsUsGuess(them)
​

It's hard to figure out a way to say that in English!