Nightinggale
Deity
- Joined
- Feb 2, 2009
- Messages
- 5,378
I looked at a bug report, which states that cargo sold in Europe is reset on tax changes. This makes it very hard to finish the quests for being the first to sell X amount. Indeed this turned out to be correct. I just just remove the line pointed out as the issue and then... oh wait that will mess up calculations for price changes.
I examined the problem further and the more I looked into it, the bigger the issues became, so I ended up doing a complete rewrite of how traded cargo is stored and accessed. It is now split into 4 different "memories". Sold and bought in the player, used for quests. Sold and bought in one number in the king used for price changes and value of cargo traded stored in king, used for tax changes. I also had to redesign how to update those counters because the old system was so confusing that at some point somebody will use them incorrectly....again. In the end this quick fix ended up taking a week to complete, but at least now quests should work as intended.
As a bonus I added a new page to the domestic advisor, which shows amount sold and bought at the 3 locations for exports. We now finally have a screen where quest progress can be monitored. It doesn't say what the quest goal is, but you can at least see the current number.
Also sales only counts goods coming from the new world. Anything bought off map will be marked and not count in the sales statistics. This way you can't cheat completing a quest by buying and instantly selling again in Europe. I noticed that I had created this loophole by accident and then fixed it before even committing, so it never even existed at any point in the develop version.
I examined the problem further and the more I looked into it, the bigger the issues became, so I ended up doing a complete rewrite of how traded cargo is stored and accessed. It is now split into 4 different "memories". Sold and bought in the player, used for quests. Sold and bought in one number in the king used for price changes and value of cargo traded stored in king, used for tax changes. I also had to redesign how to update those counters because the old system was so confusing that at some point somebody will use them incorrectly....again. In the end this quick fix ended up taking a week to complete, but at least now quests should work as intended.
As a bonus I added a new page to the domestic advisor, which shows amount sold and bought at the 3 locations for exports. We now finally have a screen where quest progress can be monitored. It doesn't say what the quest goal is, but you can at least see the current number.
Also sales only counts goods coming from the new world. Anything bought off map will be marked and not count in the sales statistics. This way you can't cheat completing a quest by buying and instantly selling again in Europe. I noticed that I had created this loophole by accident and then fixed it before even committing, so it never even existed at any point in the develop version.
