XML requests

[Thunderbrd]

Ah... THAT's why that one trait on Focused Traits has been a bit problematic.

I can try to fix those both later unless someone else states they've done them.

 

[n47]

Well, actually there are 20-30 of them.

 

[Thunderbrd]

So are you taking care of them then? Once found they are easy enough to fix right?

Still I'm curious to see them all... and... good work n47! Thank you

 

[olduser]

Next error:
Assets\Modules\ls612\Traits\ls612_CIV4TraitInfos.xml

			<Type>TRAIT_PHILOSOPHICAL</Type>
			...
					<Not>
						<GOMType>GOM_OPTION</GOMType>
						<ID>GAMEOPTION_LEADERHEAD_LEVELUPS</ID>
					</Not>

Probably should be

			<Type>TRAIT_PHILOSOPHICAL</Type>
			...
					<Not>
						<Has>
							<GOMType>GOM_OPTION</GOMType>
							<ID>GAMEOPTION_LEADERHEAD_LEVELUPS</ID>
						</Has>
					</Not>

I changed them like this i think this is the right way.

			<ReplacementCondition>
				<And>
					<Has>
						<GOMType>GOM_OPTION</GOMType>
						<ID>GAMEOPTION_LS612_TRAITS</ID>
					</Has>
					<Not>
						<Has>
							<GOMType>GOM_OPTION</GOMType>
							<ID>GAMEOPTION_LEADERHEAD_LEVELUPS</ID>
						</Has>
					</Not>
				</And>
			</ReplacementCondition>

And this cannot be correct there must be an bool expression in that tag. There are many of them.

<KillOutcomes>
				<Outcome>
					<OutcomeType>OUTCOME_SUBDUE</OutcomeType>
					<iChance>10</iChance>
					<UnitType>UNIT_SUBDUED_MAMMOTH</UnitType>
					<bUnitToCity>[COLOR="Red"]DONT_ESCORT_SUBDUED_LAND_ANIMAL[/COLOR]</bUnitToCity>
				</Outcome>
				<Outcome>
					<OutcomeType>OUTCOME_HUNTING_KILL</OutcomeType>
					<iChance>90</iChance>
					<Yields>
						<iYield>7</iYield>
						<iYield>3</iYield>
						<iYield>0</iYield>
					</Yields>
				</Outcome>
			</KillOutcomes>

 

[Dancing Hoskuld]

And this cannot be correct there must be an bool expression in that tag. There are many of them.

<KillOutcomes>
				<Outcome>
					<OutcomeType>OUTCOME_SUBDUE</OutcomeType>
					<iChance>10</iChance>
					<UnitType>UNIT_SUBDUED_MAMMOTH</UnitType>
					<bUnitToCity>[COLOR="Red"]DONT_ESCORT_SUBDUED_LAND_ANIMAL[/COLOR]</bUnitToCity>
				</Outcome>
				<Outcome>
					<OutcomeType>OUTCOME_HUNTING_KILL</OutcomeType>
					<iChance>90</iChance>
					<Yields>
						<iYield>7</iYield>
						<iYield>3</iYield>
						<iYield>0</iYield>
					</Yields>
				</Outcome>
			</KillOutcomes>

Except it is working and has been since it was added. DONT_ESCORT_SUBDUED_LAND_ANIMAL is a variable with the value of 0 or 1. It is in A_New_Dawn_GlobalDefines.XML. I.E. it is a user definable variable which we will eventually set from one of the options screens.

 

[olduser]

Except it is working and has been since it was added. DONT_ESCORT_SUBDUED_LAND_ANIMAL is a variable with the value of 0 or 1. It is in A_New_Dawn_GlobalDefines.XML. I.E. it is a user definable variable which we will eventually set from one of the options screens.

Thanks for the info i missed that while reading the code it's just a very complex beast this mod.

 

[olduser]

Removed

 

[JamesBC]

I was wondering, is there a tag for negative production, culture, science? I think there should be one.

 

[Dancing Hoskuld]

I was wondering, is there a tag for negative production, culture, science? I think there should be one.

I think you just use the same fields but with a negative number.

 

[Azurian]

I think you just use the same fields but with a negative number.

I have to try this, I don't recall seeing a building give negative science, production, or culture. I didn't know it was possible, it opens up the design process even more.

 

[Yudishtira]

I have to try this, I don't recall seeing a building give negative science, production, or culture. I didn't know it was possible, it opens up the design process even more.

I think Crime (Graffiti) gives negative culture...

 

[Faustmouse]

Yes, it is that simple: just have a "-" before the values.

There are multiple buildings using it, lookt at the techCommerceChanges and TechYieldChanges from Stonetool Maker for example.

 

[Thunderbrd]

			<ReplacementCondition>
				<And>
					<Has>
						<GOMType>GOM_OPTION</GOMType>
						<ID>GAMEOPTION_LS612_TRAITS</ID>
					</Has>
					<Not>
						<Has>
							<GOMType>GOM_OPTION</GOMType>
							<ID>GAMEOPTION_LEADERHEAD_LEVELUPS</ID>
						</Has>
					</Not>
				</And>
			</ReplacementCondition>

Not so necessary here I think to even have the not statement in there since that's already filtered on the fact that it's a linepriority of 0. However, are you sure that you wouldn't close the and statement before beginning the and/not statement as well? I'm not sure that's why I'm asking... might have something to do with why Sgt Slick's replacement gamespeedinfos isn't working quite as intended.

 

[olduser]

Not so necessary here I think to even have the not statement in there since that's already filtered on the fact that it's a linepriority of 0. However, are you sure that you wouldn't close the and statement before beginning the and/not statement as well? I'm not sure that's why I'm asking... might have something to do with why Sgt Slick's replacement gamespeedinfos isn't working quite as intended.

I think it has to to be this way before it was wrong look in the BoolEpr.cpp. A BoolExrNot does not read anything from the xml so if there are Tags in it this is wrong only other BoolEpr... or Constants can be there. The Has Expression reads the GOMType and ID from the xml.
The And returns True if the first Has is True and the Not is True. The Not is True then the Has inside is False.

 

[Thunderbrd]

Ok... I found the expression system programming beyond my reach of understanding when I've tried to read it so for now I'll trust ya

Could you take a look at SGT Slick's gamespeeds for me and see what might be making it not work quite right? It's the last set of game speeds in the gamespeed.xml file. It's been a huge mystery for me what's not quite firing right there. The option works fine but it doesn't seem to change anything.