3UC/4UC for VP: Project Coordination Thread
- Thread starter Blue Ghost
- Start date
- Status
Oh, you mean the comments. Good point.
pineappledan
Deity
@pineappledan All info that is in CorporationsOverview popup is available from Lua. There is HasGlobalMonopoly, HasStrategicMonopoly, GetGreatestPlayerResourceMonopoly, GetMonopolyPercent, etc.
@adan_eslavo Re: Pitz.lua
You know that you have changed a simple 1-check operation into a loop that executes 7 times performing 7 checks? This is anti-optimization.
You know that you have changed a simple 1-check operation into a loop that executes 7 times performing 7 checks? This is anti-optimization.
@pineappledan Teutonic Order need some fix again. Database.log file.
@Infixo but it was written wrong and didn't load that lua file into the game when I opened it by Modbuddy. I did what I could to make it work. You need to be more careful. Sorry for inconvinience.
Message from github:
"In the 4UC spreadsheet, Etemenanki yields 15% food/science output of the city as an instant yield when a building is purchased in ANY city. Currently, it only does that in the current city."
I used simple sql table for that ability and it works only for 1 city (that where E-temenanki is built). For every city we need lua script. What do we do with that?
@Infixo but it was written wrong and didn't load that lua file into the game when I opened it by Modbuddy. I did what I could to make it work. You need to be more careful. Sorry for inconvinience.
Message from github:
"In the 4UC spreadsheet, Etemenanki yields 15% food/science output of the city as an instant yield when a building is purchased in ANY city. Currently, it only does that in the current city."
I used simple sql table for that ability and it works only for 1 city (that where E-temenanki is built). For every city we need lua script. What do we do with that?
Last edited:
I’m talking about changing 1 IF into a FOR loop. That is unrelated to loading mod, Modbuddy, etc. I didn’t touch that part at all.
pineappledan
Deity
building changes from the 01/26 patch:
, and 2
/1 to each Arena.
The was added last patch because it was added to base CM
The 2 on arena was the original special bonus, but now base VP has added it instead of the .
Should we just not touch anything?
Increase Baan Chang base
to 6 then?
In the current code, hippodrome gives 3
, and 2/1 to each Arena.The
was added last patch because it was added to base CMThe 2
on arena was the original special bonus, but now base VP has added it instead of the .Should we just not touch anything?
Increase Baan Chang base
to 6 then?
@pineappledan I already did such changes: +6p to BC. +4g on arenas from Hippodrome.
@Infixo I understand. You have added table with every combattype (and it was probably something wrong with that when I was comenting parts of code to find error) and changed simple "<6" statement into things borrowed from that table. I understand it was needed. But It was not working, I didn't understand quite well what you did so I added for loop (one I understand) to use correct table with combat types. I just made it work to push v26 as soon as possible. Correct that thing once again (please) but make it work properly. Again sorry for inconvinience. I will not be sorry third time. I'm doing what I can.
@Infixo I understand. You have added table with every combattype (and it was probably something wrong with that when I was comenting parts of code to find error) and changed simple "<6" statement into things borrowed from that table. I understand it was needed. But It was not working, I didn't understand quite well what you did so I added for loop (one I understand) to use correct table with combat types. I just made it work to push v26 as soon as possible. Correct that thing once again (please) but make it work properly. Again sorry for inconvinience. I will not be sorry third time. I'm doing what I can.
First test with v.26 :
Slaganz :
- The "+5 influence to nearest CS when killing barbarian" part of the "Furor Teutonicus" promotion doesn't work
- The 3d model of the unit is the one of the spearman
- The flag of the unit is the one of the spearman in strategic view
- The Historic Info part of the unit should talk about the reason behind the different elements of the "Furor Teutonicus" promotion (it only talks about the weaponry of the unit, and not the tribal conflicts and how the German tribes were united by Arminius to fight the Romans)
Iron Chariot :
- The model for the unit is the same as the one of the Scythed chariot (although it's understandable, since we don't have a lot of different 3d models)
- The "Fast and Hard" promotion doesn't have an effect
- What about the "Rough terrain penatly" ? Is the idea forever forgotten, or do we put it in place (because having a Chariot unit without it simply feels wrong, I'm sorry Blue Ghost : the Scythed chariot has it, and it's a unit which is even more in need of mobility) ?
Cacadores :
- The "Cacador" promotion doesn't have an effect
Teutonic Order :
- The picture used was meant to be the one for the Order, while the picture of the Order should be used for the Teutonic Order
Corsair :
- Blue Ghost said that the unit would gain the "Can enter rival territory" bonus, but it's not the case
Japan : You say in the v26 changelog "added Germany, Japan and all art for the rest of components", but there is no new UCs for Japan. Were you only talking about the arts, or is there a problem ?
Slaganz :
- The "+5 influence to nearest CS when killing barbarian" part of the "Furor Teutonicus" promotion doesn't work
- The 3d model of the unit is the one of the spearman
- The flag of the unit is the one of the spearman in strategic view
- The Historic Info part of the unit should talk about the reason behind the different elements of the "Furor Teutonicus" promotion (it only talks about the weaponry of the unit, and not the tribal conflicts and how the German tribes were united by Arminius to fight the Romans)
Iron Chariot :
- The model for the unit is the same as the one of the Scythed chariot (although it's understandable, since we don't have a lot of different 3d models)
- The "Fast and Hard" promotion doesn't have an effect
- What about the "Rough terrain penatly" ? Is the idea forever forgotten, or do we put it in place (because having a Chariot unit without it simply feels wrong, I'm sorry Blue Ghost : the Scythed chariot has it, and it's a unit which is even more in need of mobility) ?
Cacadores :
- The "Cacador" promotion doesn't have an effect
Teutonic Order :
- The picture used was meant to be the one for the Order, while the picture of the Order should be used for the Teutonic Order
Corsair :
- Blue Ghost said that the unit would gain the "Can enter rival territory" bonus, but it's not the case
Japan : You say in the v26 changelog "added Germany, Japan and all art for the rest of components", but there is no new UCs for Japan. Were you only talking about the arts, or is there a problem ?
Last edited:
Iron Chariot:
- same model but number of units in formation different (iron chariot two chariots, scythed - 1). Solution: new model for scythed chariot?
- Fast and Hard works: click next turn. It will need to be reworked: maybe checking for improvement change on plot?
I already tested that : after creating and improving visible sources of Horse and Iron, I created an Iron Chariot and ended the turn, then, I attacked a Brute, and there was only the "bonus vs bb" and the "Fury of Nergal" bonus.
I'll do more tests after dinner.
No, no, no 
. You need to look into base CP on unit. 13 - base, 15 with one source, 17 CP with two sources. No % bonus.
I will tweak description to say "+2 Combat Power (CP)..." instead of "...Combat Strength...".
. You need to look into base CP on unit. 13 - base, 15 with one source, 17 CP with two sources. No % bonus.I will tweak description to say "+2 Combat Power (CP)..." instead of "...Combat Strength...".
FoxOfWar
Prince
Well then. Nice timing, as my week of winter vacation just began. Onto testing! 
I just checked the github, and Japan isn't among the "released" civilization, so I think your message was only about arts.
I think it is the best solution : we have a model for flying spears from the Zulus I think, but doing a new 3d model would be far too demanding, so have you something in mind for this model ?
Maybe checking the unit models from the Ethnic units mod could bring something ?
- I just saw they added Japan so I though it was complete. Misunderstanding.
- Teutonic order has some bug I saw in database.log. Be careful.
- Maybe something in ethnic will be good. I will try to find something tomorrow.
Second test :
- The Iron chariot works well (I just didn't know that kind of trick was possible, so I didn't check the CP of the unit). One thing though : the description of "Fast and Hard" says that the bonus occurs when you have less Iron Chariots than you have Horse/Iron, but the bonus still occurs when you have as much IC as you have Horse/Iron, so I think a small tweak to the description of the promotion is needed.
- The flax spawns well (during a previous game with Egypt, I was a bit unhappy when I saw that the Nilometer wasn't spawning flax...) and received the good bonus from pantheons and burial tombs.
- The Iron chariot works well (I just didn't know that kind of trick was possible, so I didn't check the CP of the unit). One thing though : the description of "Fast and Hard" says that the bonus occurs when you have less Iron Chariots than you have Horse/Iron, but the bonus still occurs when you have as much IC as you have Horse/Iron, so I think a small tweak to the description of the promotion is needed.
- The flax spawns well (during a previous game with Egypt, I was a bit unhappy when I saw that the Nilometer wasn't spawning flax...) and received the good bonus from pantheons and burial tombs.
pineappledan
Deity
Germany is NOT complete. No attempt has been made to do the influence on slaganz conversion, no lua for chapter promotion from TO, and art assets are wrong
- Status
