Bts 3.19

jdog5000 · Jun 10, 2009

Well, the new BTS patch was thoroughly unexpected!

Based on a quick perusal of the change list, I think most if not all of what they patched was already covered both here in BBAI and by the UP. Will take a careful look through soon to compare how things were addressed, but mostly this probably means a couple of changes will no longer need to be marked UP or BBAI.

I'll post an update in a couple of days ...

MadmanAtW · Jun 10, 2009

I think the real unfortunate thing is going to be the need to compare methods. They say they have the AI evac ships from cities in danger now- a change originally made here. But did they do it the same way? If not, is BBAI's better or worse?

I'm pretty sure there are a couple of things in there that aren't from UP/BBAI and aren't the amphibious desync fix, but I might be wrong. But, enough is duplicated that I for one won't be updating my Civ until all the mods are brought up to date.

r_rolo1 · Jun 10, 2009

There are other issues, like the fact they brought some stuff from the exe to the dll ( atleast is what the changelog says ). Hopefully that will make things easier for future modding, but it can also interfere with already done stuff....

peter450 · Jun 10, 2009

Yes to be honest i'm normally happy about new patches but this time i'm struggling to see the real point as it does not really add anything thats not already out there, it seems all they have done is pick up the bug fixes already done by mod's

I don't understand why they did not just contact Jdog5000 and say can we use your mod as a patch, as then you'd get all the bug fixes + a better AI aswell

phungus420 · Jun 10, 2009

peter450 said:
Yes to be honest i'm normally happy about new patches but this time i'm struggling to see the real point as it does not really add anything thats not already out there, it seems all they have done is pick up the bug fixes already done by mod's

Not everyone uses mods. In fact the vast majority of users don't. This is a good move by firaxis, because it standardizes things (especially for multiplayer), and brings community created and available fixes to every Civ4 player with an internet connection. While it is a PITA from my perspective, and for many other mod users, in the end it is a good move (especially since they exposed more code to the SDK).

peter450 said:
I don't understand why they did not just contact Jdog5000 and say can we use your mod as a patch, as then you'd get all the bug fixes + a better AI aswell

Firstly, how do you know they didn't? This is the same company that hired Blake, the creater of BetterAI to do the AI for BtS. Secondly, they don't need to ask for permission, Firaxis has a legal right to use anything created by the modding community which uses the Civ4 engine.

r_rolo1 · Jun 10, 2009

And not all of the things that come with the patch are from BBAI, atleast judging by the changelog and the alexman comment in the patch thread. There are even some rule changes, like the no-espionage option revamp and the banning of buying obsoleted resources.

Roland Johansen · Jun 10, 2009

There has been some talk about changing the air reconnaissance mission in the UP forum and most agreed that the vision range shouldn't be influenced by the hills, forests and mountains in the terrain, however I don't think it was ever fixed. This patch did mention fixing it. Does that mean that they have been reading the threads and decided to change it or was it changed in the UP or BAI and I just never noticed?

Patch notes said:
Terrain height no longer affects aerial recon missions

joncnunn · Jun 10, 2009

Two things that I noticed on the list that weren't in the Unofficial patch were the banning of trades of obsolete resources & the new vote when there is an invalid AP Palace Resident to be an election. Looked to me like Better AI didn't have either of these either.

I'm really hoping 3.19 fixes everything on the Unofficial patch so there's no need for that.

It does look like Better AI will still be needed, but maybe it can have a smaller footprint if some things were incorporated into 3.19.

jdog5000 · Jun 10, 2009

Roland Johansen said:
There has been some talk about changing the air reconnaissance mission in the UP forum and most agreed that the vision range shouldn't be influenced by the hills, forests and mountains in the terrain, however I don't think it was ever fixed. This patch did mention fixing it. Does that mean that they have been reading the threads and decided to change it or was it changed in the UP or BAI and I just never noticed?

They definitely read the forums here ... no doubt about that.

Yakk · Jun 10, 2009

Files changed:

Spoiler :

Currently looking at 14,000 lines of diff logs.

Yakk · Jun 11, 2009

Filtered it down to 6000, then read it.

A read through of the differences between 3.17 and 3.19, using diff and some filters (so I skipped changes to const and dll export etc after a point, because they got annoying. Also ignored whitespace changes).

Spoiler :

r_rolo1 · Jun 11, 2009

Can you say specifically whre the gold overflow change is, please? It looks that firaxis used a diferent aproach from the 3.17 UP .....

PieceOfMind · Jun 11, 2009

Yakk said:
and a bunch of python changes reflecting the above.
Including a bug around getRevoltProtection returning getExtraHillsDefensePercent() hehe.

lol? What is this?

By the way, in my limited tests, I have yet to see a single gold worth of overflow. It appears all hammers over the cost of the item are simply lost.

r_rolo1 · Jun 11, 2009

I already obtained some gold in a city with huge generic hammer multipliers building chariots ( IW, Beauro, factory and plant, forge..... ). But it definitely is not working as intended.

Time to open a 3.19 UP patch thread?

Minor Annoyance · Jun 11, 2009

A while a go I asked what the bMechanized bool in the unit xml was and now there's this

added bool CvUnit::isMechUnit()

Maybe now it does something...

PieceOfMind · Jun 11, 2009

r_rolo1 said:
I already obtained some gold in a city with huge generic hammer multipliers building chariots ( IW, Beauro, factory and plant, forge..... ). But it definitely is not working as intended.

Time to open a 3.19 UP patch thread?

Absolutely!

First reference: http://forums.civfanatics.com/showpost.php?p=8163827&postcount=160

VoiceOfUnreason said:
It looks to me as though someone lost track of where the overflow is capped, and therefore the gold overflow is being compared to the wrong thing. In other words, at the point where iProductionGold is calculated, iOverflow is capped, but iMaxOverflowForGold is still huge, and therefore the difference is negative.

Also of note - there are three duplicate variations of this code, depending on whether the city is training a unit, constructing a building, or creating a project. All share the same calculation.

(From CvCity.cpp)

Code:

iProductionNeeded = getProductionNeeded(eTrainUnit); // max overflow is the value of the item produced (to eliminate prebuild exploits) iOverflow = getUnitProduction(eTrainUnit) - iProductionNeeded; int iMaxOverflow = std::max(iProductionNeeded, getCurrentProductionDifference(false, false)); int iMaxOverflowForGold = std::max(iProductionNeeded, getProductionDifference(getProductionNeeded(), getProduction(), 0, isFoodProduction(), false)); iOverflow = std::min(iMaxOverflow, iOverflow); if (iOverflow > 0) { changeOverflowProduction(iOverflow, getProductionModifier(eTrainUnit)); } setUnitProduction(eTrainUnit, 0); int iProductionGold = std::max(0, iOverflow - iMaxOverflowForGold) * GC.getDefineINT("MAXED_UNIT_GOLD_PERCENT") / 100;

Yakk · Jun 11, 2009

Here is how to generate a relatively ... clean ... list of the 'essential' changes of a 3.17 based source tree, and a 3.19 based source tree. This is reasonably technical.

The goal is to filter out as much of the pure 'code clean up' stuff (which include 2/3 of the changed lines) as possible.

Spoiler :

The above might work even for comparing the BetterAI source directly to the 3.19 source tree. Remember to back up both source trees, as the above strips out important code in the effort to make the diff information more useful to a human reader.

Bts 3.19

jdog5000

Revolutionary

MadmanAtW

Knight

r_rolo1

King of myself

peter450

Prince

phungus420

Deity

r_rolo1

King of myself

Roland Johansen

Deity

joncnunn

Senior Java Wizard

jdog5000

Revolutionary

Yakk

Cheftan

Yakk

Cheftan

r_rolo1

King of myself

PieceOfMind

Drill IV Defender

r_rolo1

King of myself

Minor Annoyance

Deity

PieceOfMind

Drill IV Defender

Yakk

Cheftan

Similar threads