[BUG] Gold Calculation Bug

maglock · Apr 6, 2013

The gold amount in not being calculated properly. I have attached a screenshot showing the problem.

Spoiler :

As you can see, the 30 gold from religion (in this case Tithe income from number of cities) is not being added to the total. So my gold amount is only growing by 4 NOT 34 as the NET amount shows.

Note that this is during a Golden Age. If you forward a few turns, my income will dry up when the Golden Age expires, and then suddenly it starts calculating the correct amount again.

So its possible that it is being reset when the treasury gold stored hits 0 (or because the Golden Age ended?).

Note also that the display amount in the mouseover is ALWAYS wrong and does not include my religion income.

So
- Net income incorrect (possibly only during Golden Ages)
- Display amount in mouseover is always incorrect and doesn't add Religion income from the Tithe founder belief
- At some point a few turns in the future, gold in treasury hits 0 and the NET amount is corrected and starts being added again BUT the mouseover amount stays incorrect

So lots of bugs there to fix.

Attached save.
Using mods :

Civ V Unofficial Patch v2.5.2 (GK) (v 1)
G&K Enhanced Mod (v1.13.4) (v 1)

Aegis · Apr 8, 2013

I'm currently in a game as Arabia on turn 236. My current amount of Gold is 299 with an expected +1062 GPT with most of my cities producing Wealth. The next turn, my total gold was only 325. If I have my cities produce buildings or units instead, I'm in a deficit and I lose gold.

Before:

Spoiler :

After:

Spoiler :

Here is what my Economic Adviser page had to say on turn 237:

Spoiler :

I had around 4k in reserves before this bug whittled my treasury down to zero, which I only noticed when the game notified me that it had disbanded one of my units because I was running a deficit. [Edit:] The version is 2.5.2. Expenses seems to be calculated the same between what the toolbar and adviser screen says. The problem appears to be in Income. Trade Routes & City Income appear to be correct, but the game is not counting income from Open Borders, Luxury Resources (Arab trait?), or Policies. [Edit2:] I have verified that it has nothing to do with Economics, Banking, or Guilds. I suspect it may have began when I selected the Wealth social trait. I'll update later. [Edit3:] The opener Wealth social trait was not the problem. I think The National Treasury wonder may be the culprit, or one of the other Wealth social traits. [Edit4:] After choosing the Wealth opener, and building the National Treasury, but before hitting a Golden Age, my GPT was correct. Once I hit the GA, it went wonky. Note in my original images, I'm not currently in a GA. In my prior saves, I'll invest my next social policy into something not commerce-related, and see if it reverts after the GA. [Edit5:] It did not revert after the GA, it was broken from that point forward.

Aegis · Apr 29, 2013

Some logs from two different games:

Spoiler :

Aegis · Apr 29, 2013

Lua uploaded for the second log file (turn 249).

mystikx21 · Apr 29, 2013

Looks like the gross/net is way off from the summary.

I've noticed that there might be a problem with the commerce tree's gold bonus before calculating strangely, perhaps that's where we should start checking as it seems to be about the right timing.

Aegis · May 1, 2013

mystikx21 said:
Looks like the gross/net is way off from the summary.

I've noticed that there might be a problem with the commerce tree's gold bonus before calculating strangely, perhaps that's where we should start checking as it seems to be about the right timing.

I think that it's the National Treasury. My income was fine until I completed production of the nat'l wonder. Lua enclosed.

[Edit:] Save enclosed. Mods being used:

1) Civ V Unofficial Patch ver. 2.52
2) G&K Enhanced Mod ver. 1.13.4
3) Increased Tile Yields Mod ver. 3
4) No road or railroad maintenance ver. 1
5) Units - Starting Scout ver. 1

I have had the bug pop up with only the Unofficial Patch and Enhanced mod being run. [Edit2:] Well, crap. I advanced without completing the National Treasury (It's still in my queue), and 1-2 turns later the bug still happened. No new policies were adopted. I completed researching 'Steel'.

Aegis · May 2, 2013

Okay, so I re-played from turn 190 and did not take the Commerce policy in this play through. The bug still showed up at turn 199/200. My Golden Age (started by happiness) had just ended. I kept track of my Gold throughout the GA and it was fine. It wasn't until after the GA that it went wonky. Lua log:

Spoiler :

After this turn, I started a new GA by burning a Great General, and the calculation was still wrong.

mystikx21 · May 2, 2013

My own notes, did a couple test games in 2.52/1.134
I've noticed the bug doesn't seem to be consistently off. It comes and goes. Most turns it seems to be correct, others not.
It seemed to be related to Golden Ages, either exiting or during, so far at least, but I don't think this was a 100% correlation. It was not persistent throughout a golden age for example.

When it was off, it seemed to be roughly the amount of religion income I was generating (tithes). Also: when it was off, faith generation per turn and possibly science and culture per turn were not added that turn (or two).

It seemed to correct after disbanding a unit and gold going positive again.

I did not experience a bug after building the National Treasury.

I have not taken Commerce tree, yet. Update: no obvious change occurred upon taking the commerce tree either. There were occasionally glitches after taking policies within the tree, but they were not timed exactly (such as the cheaper roads/bonus trade policy or extra gold on tiles policies). They may likely have been unrelated as they appeared as the same sporadic forms as prior glitches.

Related notes: Gold income total in the UI when mouse-over doesn't sum in religion in 2.52 (but the per turn top bar version does correctly). In between turns, both the research overlay and the mouseover for "total gold" are incorrect. The research UI top bar remained accurate. I am pretty sure some of those issues were addressed in the 2.6 beta, but it's been a while since I've used it.

Unrelated note: AI religion focus and generation in 2.52 was/is absurdly high. I had Lalibela and Stonehenge and shrine/temples everywhere and a bigger empire and a couple of religious CS friend/ally, and still lagged behind the Spanish (and Mongols!?) in faith generation. I also only managed to get a religion via liberty tree finisher. Something was clearly amiss there that was fixed in 2.6

zonder · May 7, 2013

to me it seems it just doesn't calculate the open borders income. i have about 900 total income and 600 expenses. the game shows +300 correctly but i only get about +30 after each turn.

then i saw that i have 270 income from open borders, this clearly doesn't calculate. (all numbers approx)

vyyt · May 7, 2013

zonder said:
to me it seems it just doesn't calculate the open borders income. i have about 900 total income and 600 expenses. the game shows +300 correctly but i only get about +30 after each turn.

then i saw that i have 270 income from open borders, this clearly doesn't calculate. (all numbers approx)

Sorry Zonder, this does not seem to be the case - or at least not always. Once it happened to me very early on in the game - I was definentely not having open borders with anyone. I remember I was getting around +16 gold / turn and then suddenly I was losing some 3 gold / turn (although the top bar was still showing +16 / turn). Nothing significant happened at that time.

ja14hall · May 19, 2013

I discussed this on another post:

I think I have found what the issue is. It is a simply miscalculation. In CIVUP the modders changed the way civ calculates and updates how much gold you are going to get, but not really. What I mean by that is it updates the tool tip. In my games it shows me earning close to 1000+ gold, but I only get about 50 or so. The issue is, CIVUP calculates this:

CityIncome + TradeIncome + GoldFromPlayers + Openborders + GoldFromReasources + a couple of other things.

So what happens is you think you are getting way more because it calculates many of the numbers twice. The OpenBorders and GoldFromReasources are already calculated in the CityIncome. Also I think this line:

local iGoldPerTurn = activePlayer:GetYieldRate(YieldTypes.YIELD_GOLD)

May still be messing things up, because even after I changed the Lua in the Top Panel file in CIVUP it still showed me getting +988, which interestingly enough is the total income my empire generates. I have not found a way to correct this though, but maybe one of the modders can see this.

Now all that said, this does not break the game, you still earn gold like you should, it is just hard to gauge how your empire is doing just based off a glace at the top bar. Players can click on your gold to bring up a window that shows you where you earn all your gold and where it is all going. Those numbers are accurate, so if you go off those you will be okay. It is just annoying that it does not work the way it should.

Also with GoldFromReligion, that should be contained within your CityIncome. The number that is shows is really only for show for those who are interested in knowing.

Aegis · May 20, 2013

ja14hall said:
So what happens is you think you are getting way more because it calculates many of the numbers twice. The OpenBorders and GoldFromReasources are already calculated in the CityIncome.

Are you sure? Because my GoldFromResources is greater than CityIncome in my screenshots above in post #2. 947.2 (GFR) Vs. 850.56 (CI). Adding in OpenBorders makes it higher: 1060.2 Vs. 850.56. It doesn't make sense to me that CityIncome would be lower than those numbers if they were included.

That being said, the top panel LUA is almost exactly right for the first 180 or so turns of my games, but then goes wonky after a GA. If it was simply a problem of calculating the numbers twice in the LUA it would a constant problem from the beginning of the game. When I'm on turn 170 and the LUA tells me that I'll be receiving +1080 gold, the next turn I will receive exactly 1080 gold. After a GA in that turn time frame, the calculation is wrong and I receive significantly less than what the LUA says.

[Edit:] I took this example of the LUA being correct from my saved game up in post #6, only ten turns earlier when the bug was not showing up. Turn 192: 2,334 in treasury, +465 income for an expected total of 2,799 in next turn’s Treasury:

Spoiler :

Turn 193: 2,796 in the treasury, +466 income for an expected total of 3,262:

Spoiler :

Turn 194: 3,260 in the treasury, +463 income:

Spoiler :

We can see that the income listed in the LUA is correctly being added to the treasury each turn. Note that this was during a Golden Age, after which the bug arose at turn 201.

mystikx21 · May 20, 2013

I don't see how gold from religion should be contained within city income, as it would depend on what kind of religion gold generating belief you are using. Tithing is global (as it comes from foreign sources as well), as is the one-shot gold per conversion of cities. Pantheon beliefs would be local but that's it, and as far as I can tell, those aren't included in "from religion" calculations.

The next problem is that so far as I can tell it comes up randomly as incorrect but for many turns, it will "correctly" add the amounts that it lists into a surplus or deficit. This would suggest that the problem isn't double counting sources (there are places where the game is double-counting like faith or culture from CS, and sometimes food I think too from CS) but something that occurs only occasionally throughout the game.

It is sounding more like the problem is Golden Age bonus yield calculations throwing things off.

ja14hall · May 20, 2013

Okay, for religion I forgot that there are beliefs that add gold based on the number of cities of followers, so that is my bad, lol.

But on the Golden Ages issue, is it a stacking bug? Does each golden age make it worse and worse? I have never noticed it until I was really late in the game when it said I should be getting over 1000 gold and it only gives me 50 or so.

Also, the only file I could find so far that involves golden age calculations is the Top Panel file in the CIVUP files. Has anyone else found anything different before I begin messing around with it and breakin things, lol.

mystikx21 · May 20, 2013

There's a couple points to note.

1) The bug is more extensive than gold not accumulating correctly. It seems to also apply to science, faith, culture, and happiness per turn not adding up correctly either. At least the bug I've noticed when gold isn't adding up correctly. In the case of science, some marginal quantity is added instead. I haven't been able to figure out what that figure is based on. In faith, it will continue to add CS boosts (I think), but that's it. Culture looks the same. Happiness not adding up correctly can impact production and growth negatively but otherwise those yields seem to be doing what they are supposed to, more or less. It's a fairly extensive and damaging bug beyond just income management.

2) It so far in testing seems to be intermittent, but tends to be more noticeable or common surrounding a golden age, either during or maybe right after. Typically when the bug occurs, it happens "in between turns" and I notice immediately that my turns on science in the science overlay display are way off from the top bar display, which may persist for a period of a few turns and then will return to normal. To me the science rate being slowed down and offset by the glitch was far more significant than managing my gold was. I suspect there's an issue with how the golden age calculations for bonus yields are interacting with other bonus yield effects, or just the golden age bonuses themselves aren't working right. Or this mechanic is interacting with something else. It does look like it could be a stacking issue when looking over how the gold bonus yield is done.

I don't know if it becomes cumulative or not but it would seemed to be happening for one or two turns earlier and sometimes three or four later. It's possible that earlier glitching though just isn't as noticeable as the income, science and faith accumulations are far smaller and that the problem is just as acute throughout but very, very obvious when one expects to get 1k gold or 10k science or 300 faith per turn and doesn't.

You seem to have a little better handle wading through the lua than I do, but there are also the regular golden age bonuses in the xml too.

Aegis · May 20, 2013

ja14hall said:
But on the Golden Ages issue, is it a stacking bug? Does each golden age make it worse and worse? I have never noticed it until I was really late in the game when it said I should be getting over 1000 gold and it only gives me 50 or so.

It's an on or off type of thing for me. Say I go through 3-4 GAs before turn 200. The LUA is consistently accurate before, during, and after each GA. Then in the late medieval period (between turns 180-210 for me) I get a GA, after which the calculation is suddenly wrong for the remainder of the game. It's correct through the entirety of that last GA, and the Wealth policy is not taken, and National Treasury is not built.

I considered that maybe the LUA was just listing GA values while I was not in a GA, but those numbers didn't match, either. [Edit:] Well, I didn't do any empirical testing, just based off what I happened to notice, so maybe that's not true. That would explain why culture/faith/science were also off. [Edit2:] Nope, the difference is much greater than just 20%. Using my first post as an example, even if I subtract all income other than what comes from cities and take off 20% for a supposed GA, I should still have 442 Gold, but only get 26.

[BUG] Gold Calculation Bug

maglock

Coatlann Tamer

Attachments

Aegis

Deity

Aegis

Deity

Aegis

Deity

Attachments

mystikx21

Deity

Aegis

Deity

Attachments

Aegis

Deity

mystikx21

Deity

zonder

Chieftain

vyyt

Deity

ja14hall

Chieftain

Aegis

Deity

mystikx21

Deity

ja14hall

Chieftain

mystikx21

Deity

Aegis

Deity

Similar threads