@Thunderbrd, I want to ensure myself do I understand thing correctly. Do you plan to make this combat classes an optional module, such when you do not load it only the main class apply and thing should work as they did earlier? -- If so, are you planning to put not main combat classes in the module's xml?
No. What I plan to do is have NotOnGameOption and OnGameOption tags on the combat classes themselves turn some of these on or off (along with whatever other game effects might be bundled into that option) but I'm not planning to make the CCs nor their assignments modular unless the unit's core definition is in a module itself - which isn't exactly a modular 'edit' either.
Oh and I figured out we have a complication in the autoassignment plan that we're going to have to get around and I'm not a big fan of the readpass3 method as slow as it is. The problem is that unitcombatinfos is loaded quite early in the sequence and it requires some tricky work to delay the read on some tags until the references are loaded. To be specific, when unitcombat is loaded, eras, religions AND cultures (core definition of which is a particular category of Bonus) have not been defined in the code yet.
I may well have to use a read pass 3 for this... might be no real good way around it but I figured I'd let you see the curveball and ask how you'd swing at it.
@Hydro & n47: Hydro - I appreciate your efforts there. Here's my take on it:
I'm wondering if its culturally more acceptable where n47 is from to tell someone they are stupid point blank in thinly veiled terms. Sometimes this can be a cultural practice to chide and toughen up the sensitivities of those in their social group so as to keep them from being weak of heart and mind.
However, generally my understanding of people is that it is our egos that are the most sensitive organ we possess. If you tell someone they are undereducated and stupid you would be as much to say it without understanding that it's going to offend - it should be well understood that no matter how undereducated or stupid the person may be it's going to be an offensive comment. Criticizing another's intelligence really doesn't achieve much either aside from perhaps an attempt to become the dominate conversationalist. We also often resort to such a practice as a defensive mechanism, a counterattack when we worry that we are somehow not being respected ourselves and that somehow we have inferred that the other has very subtly insinuated the same message to us.
Due to nearly all cultures having some amount of the aforementioned customary practice of sandblasting each other's egos to help reduce sensitivity and vulnerability among warrior and intellectual peers, it's quite possible we could be seeing n47 acting as much like a friend as she knows how to be one.
Either way, I know I can be a cocky ass and never know when that facet of my nature can come across to others in a grating manner but when verbally called on it rather than feeling 'humbled' I feel it must suck that the other person hasn't the same confidence to match that they can debate with the same degree of self-confidence in an understanding that since we're debating at all the door is obviously open for consideration of the other's words. A closed mind is only truly presented by a denial of communication at all. You learn this in sales... if they say no and they're still talking to you, they are interested despite what they are saying they feel.
Anyhow, my point is... I take no offense - rather, I took it as an interesting reflection on how I'm perceived by some others. However, I take no offense because I understand the emotions in communication dynamics and choose to recognize that my immediate reaction to take offense is likely invalid. I wouldn't blame anyone else for taking GREAT offense to such a comment however, and I think it would be wise for n47 to recognize the reason such a comment would indeed be a diplomatic error with most. Unless she LIKES people to dislike her for whatever reason that might be
