C2C SVN Changelog

Thunderbrd said:
Changed FreePromoTypes tag to enable a condition statement regarding the unit that would receive the promotion.
Click to expand...
With a change you made along with that there is a pointless loop now in BuildingFilterIsMilitary::isFilteredBuilding:
Code: 
	bool hasFreePromofromList = false;
	for (int iI = 0; iI < GC.getBuildingInfo(eBuilding).getNumFreePromoTypes(); iI++)
	{
		hasFreePromofromList = true;
	}
That is equivalent to
bool hasFreePromofromList = GC.getBuildingInfo(eBuilding).getNumFreePromoTypes() > 0;
 
ls612 said:
1. I don't see such code for the other expressions in CvOutcomeMissions, is that OK or should I add SAFE_DELETE_ARRAY calls for those too?
Click to expand...
They need that as well so please add it.
New and delete have to be matched though so not SAFE_DELETE_ARRAY but just SAFE_DELETE (mismatching the array and non array variants of new and delete can actually corrupt the memory so it is important to use the right variant).
 
AIAndy said:
With a change you made along with that there is a pointless loop now in BuildingFilterIsMilitary::isFilteredBuilding:
Code: 
	bool hasFreePromofromList = false;
	for (int iI = 0; iI < GC.getBuildingInfo(eBuilding).getNumFreePromoTypes(); iI++)
	{
		hasFreePromofromList = true;
	}
That is equivalent to
bool hasFreePromofromList = GC.getBuildingInfo(eBuilding).getNumFreePromoTypes() > 0;
Click to expand...

Oy vay! So it is... so it is. I'll make sure to have that rectified on my next update then.
 
Updates
  • Fixed some XML text files declaring themselves as UTF-8 while being encoded in Latin-1.
  • Changed assumed encoding in XML files without encoding declared in the header from UTF-8 to Latin-1 (that is more compatible with some old XML text files).
  • UTF-8 to unicode conversion will now fail and display a message box instead of adding bad characters into the text when the text is not valid UTF-8.
 
Just pushed to SVN (5588):
  • Significantly more asynchronous processing of city turn
  • Fixed an OOS MP bug
  • Fixed an incorrect text on trait notification
  • Fixed rand logging of stream names
  • Changed compiler flags to optimize for SSE2 (though it doesn't have much impact on my hardware at least)

I'm on vacation for about the next 10 days or so, so if you are getting issues from the multi-core stuff run with 1 thread (same GlobalDefine as before is still used)

For those playing IP MP games, I have fixed on definite issue, but there may be (probably are) more, so please try with multiple threads once to generate new logs, and then set back to one thread again if need be.

Note - I was unable to upload the PDB and DLL for the archive - Sourceforge just kept giving me permission errors. I'll try to push them in a separate rev...
 
Updates

- A fix for the Appian Way python. I am not 100% sure I have fixed this but the code was assuming that you would find a "safe" city to get to from the current city. I just set the variable it was setting when it found a safe path to None before and then test after the loop to ensure it is not still None before doing the path. I am assuming the error case was where a city is on the same landmass but there are barbarians of foreign territory between it and all other cities in its nation.

edit

- Changes to Natural Wonder feature yields as discussed. The Mt Sinai wonder building has been introduced and is slightly changed from the others. Each will have its own building eventually.
 
strategyonly said:
WARNING, I am just guessing here, but i believe the old and new multi-threading dll does not work properly, and Koshling is gone for over 10 days, so i would NOT advise updating till it is solved, sorry everyone, also in doing this request, pls DO NOT post either.
Click to expand...

Irritating. I auto-played over 300 turns in 3 different games, spent 3 hours playing my own game, and retested saves from SO and Talin during testing! Suggest you continue to post minidumps- it might be something very simple and common that AIAndy can resolve without having to dig too much.

@AIAndy - obviously if that is not the case don't spend too long on something that's my fault - it'll have to await my return. I will continue to have access to these boards in the case of questions arising (but not good access to source)
 
Koshling said:
Irritating. I auto-played over 300 turns in 3 different games, spent 3 hours playing my own game, and retested saves from SO and Talin during testing! Suggest you continue to post minidumps- it might be something very simple and common that AIAndy can resolve without having to dig too much.
Click to expand...

Didnt mean it that way, its just that like i said, i have NO problems what so ever with that dll i have in the single CTD area, and since then thats when all this CTD stuff has happened, and now a few have WofC stuff, thats why i posted, sorry, meanness is not intended:blush:, i thought you knew that much, sorry if thats the way you took it), and again no minidumps, even though i have read and full access granted to ALL of civ IV??
 
strategyonly said:
Didnt mean it that way, its just that like i said, i have NO problems what so ever with that dll i have in the single CTD area, and since then thats when all this CTD stuff has happened, and now a few have WofC stuff, thats why i posted, sorry, meanness is not intended:blush:, i thought you knew that much, sorry if thats the way you took it), and again no minidumps, even though i have read and full access granted to ALL of civ IV??
Click to expand...

Maybe the minidump code has issues with multi-threading?

At any rate, I've been getting similar untracable crashes as well, so I've reduced the thread limit globaldefine to 1 on the SVN as an interim fix.
 
ls612 said:
Maybe the minidump code has issues with multi-threading?

At any rate, I've been getting similar untracable crashes as well, so I've reduced the thread limit globaldefine to 1 on the SVN as an interim fix.
Click to expand...
Did you get minidumps?

As SO does not get any minidumps and I consider it unlikely that all his crashes are in threads I still think he is having some issues with Windows 8 and likely writing rights.

EDIT: And I can look into the issue, but only after the weekend as I will be away from my modding computer until Monday.
 
AIAndy said:
Did you get minidumps?

As SO does not get any minidumps and I consider it unlikely that all his crashes are in threads I still think he is having some issues with Windows 8 and likely writing rights.

EDIT: And I can look into the issue, but only after the weekend as I will be away from my modding computer until Monday.
Click to expand...

I've been using win8 since October and it gives dumps fine normally, but I too am not getting anything useful from these crashes. I tried running it under the debugger and it crashed for me in code that processes buildings, which is part of the city code that Koshling multi-threaded, so I'm willing to bet that it does have something to do with that.
 
OK i am going to go back to my OLD Win 7 with Total access/permissions, and see what happens.

EDIT:

????(soon )

OK Win 7 works:eek::eek:

I did at least a load and 2 turns, withOUT a CTD:clap: Will see if it holds out,

I am thinking maybe its a Win 8 problem if ls512 is having the more or less same crashes withOUT a minidump ??
 
You must log in or register to reply here.

Similar threads

E
First timer trying to play the C2C mode, it is not working !
Replies
1
Views
119
Somebody613
S
Ghostly Wolfmoon
C2C SVN Download, seeking help setting up in Linux, please
Replies
10
Views
2K
cobbaut
cobbaut
Non-E
Non-E's C2C Mini Modmods
Replies
1
Views
272
Non-E
Non-E
M
Installation Problem
Replies
2
Views
2K
Metaltooth
M
CainStar
C2C gives error at launch, but normal Civ4 doesn't work either.
Replies
3
Views
623
JL1312
J
Back
Top Bottom