Change_player

[doktorstick]

What is the purpose of the CHANGE_PLAYER code? Is it part of AUTOPLAY?

 

[Cybah]

part of revolution mod as autoplay is a part of revolution mod too.

 

[jdog5000]

It allows any player's civ or leader to be changed in the middle of the game, plus the human player to switch to controlling any other player. It's for debugging (and fun ...).

 

[Thomas SG]

There is problem with change leader! The development of Dynamic Civ Leader emerged a problem with the philo trait. The problem is caused by the great people modifier but only if the modifier is 100%. If it's smaller (tested it with 10% and 50%) nothing happens.

The problem appears when switching from a philo leader to a non philo leader (maybe only at the beginning of the game). It seems as if the change can produce a negative result in

int CvPlayer::getGreatPeopleRateModifier() const
{
	return m_iGreatPeopleRateModifier;
}

With a change to

int CvPlayer::getGreatPeopleRateModifier() const
{
	return std::max(0,m_iGreatPeopleRateModifier);
}

the CTD disappears. And everything is fine.

Don't know why it happens...

 

[jdog5000]

Thanks for the report Thomas. Everything seems to be working fine for me, did you perhaps change what the trait benefit for philosophical was between starting the game and changing the leader? That could totally cause this.

 

[Thomas SG]

No. The traits are not touched in CCV yet. And there is also no modification of the benefits of the traits during the game.

I developed something new I call Dynamic Civ Leader for CCV. This new gameoption changes the leader with each new player era to one of the best fitting available leaders.

So for example if you play the Germans you will have Frederick as your leader in the renaissance era and switch to Bismark in industrial times. That's what DCL does. But of course this idea and mechanic also forces a leader change right at the start up. So the first leader changes are done before the first turn.

And that's were we found the problem. So if you choose Suleiman (Philo) as start leader for the Ottomans and ancient start era, DCL will change the leader to Mehmed (Non-Philo). Everything is fine until you try to found the first city. CTD.

 

[jdog5000]

Ah, okay. Yes the change coming before the beginning of the game could have this effect.

Question: In a situation where you would have had a CTD with the old code, what happens now if you change back to a Philosophical leader? Do you actually get the boost to GP rate in this case?

I'm wondering the early leader switching is causing trait boosts to be set negative and stay negative ...

 

[LunarMongoose]

I developed something new I call Dynamic Civ Leader for CCV. This new gameoption changes the leader with each new player era to one of the best fitting available leaders.

So for example if you play the Germans you will have Frederick as your leader in the renaissance era and switch to Bismark in industrial times. That's what DCL does. But of course this idea and mechanic also forces a leader change right at the start up. So the first leader changes are done before the first turn.

And you developed this when, exactly? Since I posted it as my idea after I came up with and implemented an almost-identical system several months ago.