Development Thread

[EmperorFool]

What about the interesting improvements of MA you were working on? Decreased priority?

I know, I know. My main reason for the delay is that it will be a large undertaking. Weeks of work. Whereas I was hoping to add some smaller features and bug fixes to get 3.1 released ASAP. At least I will fix the disappearing units aspect of the MA for 3.1.

This pedia index was supposed to be quick, but it requires that I change the way that Sevopedia works as a whole, and I am having a small display annoyance (two rows remain selected as you use back/forward buttons and click links in the pages themselves). I have a workaround, but I was resisting it because it will slow down the screen slightly.

Of course, it will slow it to how it was before I added the index. I made some speed improvements while adding the index, and half of them will need to go to fix the issue. I hate throwing out working code due to a design flaw or bug that I cannot fix (it's in the EXE itself). I'll get over it tonight and finish it.

I just looked at the scoreboard tab at the BUG options screen. Wouldn't it make more sense if the third column would be the first and the other two cloumns move to right?
That's because the third column holds the option to disable the advanced layout which somewhat makes it the master switch at this tab.

The options in the first and second columns work in both the normal and Advance Layout scoreboards. That's why they are to the left. The options in the third column only work with the Advanced Layout. If I put the AL column first, it might imply that it is required to get the 1st and 2nd column options to work.

However, I am considering forcing AL and ditching the normal scoreboard. First, I doubt (and hope) no one uses the normal scoreboard. Second, several checkbox options in the 1st/2nd columns must be enabled and their letter codes be added to the Display Order field in the AL column for them to appear in the AL. This is confusing at best. You shouldn't have to enable an option in two places.

If I did that, the third column would indeed become the first column.

 

[Cammagno]

I know, I know. My main reason for the delay is that it will be a large undertaking. Weeks of work. Whereas I was hoping to add some smaller features and bug fixes to get 3.1 released ASAP. At least I will fix the disappearing units aspect of the MA for 3.1.

Good
I'm happy that you still want to work on MA, and I agree with your priorities

However, I am considering forcing AL and ditching the normal scoreboard. First, I doubt (and hope) no one uses the normal scoreboard. Second, several checkbox options in the 1st/2nd columns must be enabled and their letter codes be added to the Display Order field in the AL column for them to appear in the AL. This is confusing at best. You shouldn't have to enable an option in two places.

I wrote my opinion on this in the pull thread.
But here I want to comment on your 2nd reason... I think that this is not a real problem. First of all, we should include all the letter codes in the default Display Order field, so people can simply disable one column removing the checkbox OR deleting the letter, and if they want to have the column back they simply have to change one of the two things (the one they modified previously). Then, to make things even more clear, maybe we can add a line to the hover text of the checkbox saying "If you are using the advanced layout, be sure to check if the 'x' letter code is included in the Display Order field" or something like this... What do you think about this?

 

[EmperorFool]

To make things even more clear, maybe we can add a line to the hover text of the checkbox saying "If you are using the advanced layout, be sure to check if the 'x' letter code is included in the Display Order field" or something like this.

Yes, that's a good idea.

 

[The Doc]

[...]
The options in the first and second columns work in both the normal and Advance Layout scoreboards. That's why they are to the left. The options in the third column only work with the Advanced Layout. If I put the AL column first, it might imply that it is required to get the 1st and 2nd column options to work.

However, I am considering forcing AL and ditching the normal scoreboard. First, I doubt (and hope) no one uses the normal scoreboard. Second, several checkbox options in the 1st/2nd columns must be enabled and their letter codes be added to the Display Order field in the AL column for them to appear in the AL. This is confusing at best. You shouldn't have to enable an option in two places.

If I did that, the third column would indeed become the first column.

Thanks for the clarification. I didn't notice that the 1st/2nd column work for the original scoreboard as well. Put that way the layout of the tab makes more sense. So there's no urgent need to change it.

 

[alerum68]

deleted123

 

[Caesium]

Added translations to UnitGrouper.py and CvBUGMilitaryAdvisor.py, for showing translated texts in Military Advsior.

And here is the text for your xyz_Civ4GameText.xml.

	<TEXT>
		<Tag>TXT_KEY_BUG_MILITARY_ADVISOR_DOMESTIC_CITY</Tag>
		<English>Domestic City</English>
		<French>Domestic City</French>
		<German>Eigene Stadt</German>
		<Italian>Domestic City</Italian>
		<Spanish>Domestic City</Spanish>
	</TEXT>
	<TEXT>
		<Tag>TXT_KEY_BUG_MILITARY_ADVISOR_DOMESTIC_TERRITORY</Tag>
		<English>Domestic Territory</English>
		<French>Domestic Territory</French>
		<German>Eigenes Territorium</German>
		<Italian>Domestic Territory</Italian>
		<Spanish>Domestic Territory</Spanish>
	</TEXT>
	<TEXT>
		<Tag>TXT_KEY_BUG_MILITARY_ADVISOR_TEAM_CITY</Tag>
		<English>Team City</English>
		<French>Team City</French>
		<German>Team Stadt</German>
		<Italian>Team City</Italian>
		<Spanish>Team City</Spanish>
	</TEXT>
	<TEXT>
		<Tag>TXT_KEY_BUG_MILITARY_ADVISOR_TEAM_TERRITORY</Tag>
		<English>Team Territory</English>
		<French>Team Territory</French>
		<German>Team Territorium</German>
		<Italian>Team Territory</Italian>
		<Spanish>Team Territory</Spanish>
	</TEXT>
	<TEXT>
		<Tag>TXT_KEY_BUG_MILITARY_ADVISOR_FRIENDLY_CITY</Tag>
		<English>Friendly City</English>
		<French>Friendly City</French>
		<German>Befreundete Stadt</German>
		<Italian>Friendly City</Italian>
		<Spanish>Friendly City</Spanish>
	</TEXT>
	<TEXT>
		<Tag>TXT_KEY_BUG_MILITARY_ADVISOR_FRIENDLY_TERRITORY</Tag>
		<English>Friendly Territory</English>
		<French>Friendly Territory</French>
		<German>Befreundetes Territorium</German>
		<Italian>Friendly Territory</Italian>
		<Spanish>Friendly Territory</Spanish>
	</TEXT>
	<TEXT>
		<Tag>TXT_KEY_BUG_MILITARY_ADVISOR_NEUTRAL_TERRITORY</Tag>
		<English>Neutral Territory</English>
		<French>Neutral Territory</French>
		<German>Neutrales Territorium</German>
		<Italian>Neutral Territory</Italian>
		<Spanish>Neutral Territory</Spanish>
	</TEXT>
	<TEXT>
		<Tag>TXT_KEY_BUG_MILITARY_ADVISOR_ENEMY_TERRITORY</Tag>
		<English>Enemy Territory</English>
		<French>Enemy Territory</French>
		<German>Feindterritorium</German>
		<Italian>Enemy Territory</Italian>
		<Spanish>Enemy Territory</Spanish>
	</TEXT>
	<TEXT>
		<Tag>TXT_KEY_BUG_MILITARY_ADVISOR_BARBARIAN_TERRITORY</Tag>
		<English>Barbarian Territory</English>
		<French>Barbarian Territory</French>
		<German>Barbarenterritorium</German>
		<Italian>Barbarian Territory</Italian>
		<Spanish>Barbarian Territory</Spanish>
	</TEXT>
	<TEXT>
		<Tag>TXT_KEY_BUG_MILITARY_ADVISOR_ESTIMATE</Tag>
		<English>(est)</English>
		<French>(est)</French>
		<German>(gesch.)</German>
		<Italian>(est)</Italian>
		<Spanish>(est)</Spanish>
	</TEXT>

 

[The Doc]

Added translations to UnitGrouper.py, for showing translated texts in Military Advsior.

And here is the text for your xyz_Civ4GameText.xml.
[...]

Hey, that's great.
Ruff and EF weren't quite sure if these could be made translatable. Now only the "(est)" at the Sit-Rep tab is missing.

 

[Caesium]

I knew it. I forgot something

Let me see, what I can do

 

[EmperorFool]

Ruff and EF weren't quite sure if these could be made translatable.

Naw, was just being lazy and still haven't finished the Deployment tab. I've been majorly distracted by rewriting the BUG core (how it initializes itself and how other mods are included) to make it easier for other mod makers to a) build their own mods and b) include BUG in their mods.

Rest assured I'll get back to it soon. In the meantime, I'll add these in. Thanks, Caesium!

Now only the "(est)" at the Sit-Rep tab is missing.

I still think an asterisk (*) with a note about it at the bottom of the screen would be better. For one thing, all of the values are estimated anyway -- it's not like these are exact chances of being attacked.

 

[Caesium]

OK, but meanwhile I added the est part and corrected a minor glitch I discovered

Edited post above with corrected files and text

I have to thank for the BUG Mod

 

[ruff_hi]

Now only the "(est)" at the Sit-Rep tab is missing.

I still think an asterisk (*) with a note about it at the bottom of the screen would be better.

I, too, like the '*'. Just were to put the note is the question.

 

[The Doc]

I just committed the reformatted strategy guides to SVN. The file is a "little" bigger now because a few times half of the text of a guide was missing.

@Cam: Maybe you would like to translate the introduction text (which is rather short) like I did for German. You can also adjust the shortcut letters (like "(E)" for "Empire Management") to be fitting with the Italian text.

 

[Cammagno]

I made some little change to the BUG Option Screen layout (some empty line added, and one column added to the Advisor tab to avoid the vertical scrolling bar for victory options)... I tested it and it looks ok, but I'm still very very unexpert in Python, so I hope I've not done any damage

@ The Doc
The Advisor Tab requires a little tweak of the German translation, if you would like to avoid an horizontal scrolling bar... only 2 or 3 letters should be removed, and there are different rows from which you can take them off, so I hope it's not too difficult...

 

[The Doc]

I made some little change to the BUG Option Screen layout (some empty line added, and one column added to the Advisor tab to avoid the vertical scrolling bar for victory options)... I tested it and it looks ok, but I'm still very very unexpert in Python, so I hope I've not done any damage

@ The Doc
The Advisor Tab requires a little tweak of the German translation, if you would like to avoid an horizontal scrolling bar... only 2 or 3 letters should be removed, and there are different rows from which you can take them off, so I hope it's not too difficult...

I checked it out and it looks Ok (see here:
).
Nice Work on that tab.
I noticed that you changed the General tab a bit. Maybe you could insert some labels instead of blank lines. That would give the options more structure. Would be great.

@Ruff: I just took a closer look at the victory screen and encountered a problem:

The text of the object's name is displayed as a whole instead of just the first one before the ":". Can you fix it?

 

[Cybah]

Added translations to UnitGrouper.py and CvBUGMilitaryAdvisor.py, for showing translated texts in Military Advsior.

you forgot to delete the following caesium mod addition:

screen.setLabel(self.HEADER_ID, "Background", u"<font=4b>" + localText.getText("TXT_KEY_MILITARY_ADVISOR_TITLE", ()).upper() + " - " + localText.getText("TXT_KEY_CAESIUM_VERSION_SMALL", ()) + u"</font>", CvUtil.FONT_CENTER_JUSTIFY, self.X_SCREEN, self.Y_TITLE, self.Z_CONTROLS, FontTypes.TITLE_FONT, WidgetTypes.WIDGET_GENERAL, -1, -1)


(CvBUGMilitaryAdvisor.py)

 

[Cammagno]

I checked it out and it looks Ok (see here:
).

On my screen it is a bit different...
(View attachment 186303)

I noticed that you changed the General tab a bit. Maybe you could insert some labels instead of blank lines. That would give the options more structure. Would be great.

To tell the truth, I changed (only a bit) several tabs (4 or 5)
I like your idea of adding labels, and I also wish to update the structure of some tabs, but I'll wait that the new core is in place (and I also have to improve my pyton capabilities).

@Ruff

About Victory screen, I've noticed that the corresponding options in BUG Option Screen haven't yet been XMLized for translation... are you waiting for some change in the next future or can this be done? (supposing that I'm able to do it )
The same for the UnitNaming Test.

 

[ruff_hi]

On my screen it is a bit different...

Maybe we can widen the option screen for screens that are wider than 1024 pixels.

@Ruff

About Victory screen, I've noticed that the corresponding options in BUG Option Screen haven't yet been XMLized for translation... are you waiting for some change in the next future or can this be done? (supposing that I'm able to do it )
The same for the UnitNaming Test.

I knew that EF was re-writing that code so I sort of waited ... I'll look at it and see what needs to be done. Or you can. Or not.

 

[The Doc]

Maybe we can widen the option screen for screens that are wider than 1024 pixels.

I knew that EF was re-writing that code so I sort of waited ... I'll look at it and see what needs to be done. Or you can. Or not.

Some stuff at the BUG MA is also missing.
Did you notice the problem at the victory screen I mentioned above?

@Cam: I forgot that I'm not using the standard font. I'll think about some better terms that are also shorter.

 

[EmperorFool]

Check out the core branch. I seem to recall doing something about victory options. There are definitely the two options in it (though I thought they already were). I finally nailed down the last problem I was having with the new core last night.

Speaking of the new core, could I get a couple people to grab it and pound on it for a little bit? Just start a few games, load some games, open screens, etc. Don't worry about exercising it too much, I just want to catch the glaring stuff right now.

 

[ruff_hi]

Speaking of the new core, could I get a couple people to grab it and pound on it for a little bit? Just start a few games, load some games, open screens, etc. Don't worry about exercising it too much, I just want to catch the glaring stuff right now.

hey - I figured out how to add a new repository all by myself . Grabbed a copy of your new (apple) core and will fire it up tonight.