Panopticon
Utilitarian
I'll download it and try it out.
Feedback thread
- Thread starter Maniac
- Start date
Panopticon
Utilitarian
The save game is temperamental.
1. I tried to end the turn. It crashed almost instantly, before new tech options and all that.
2. I reloaded Civ, deleted all cities in WB except Santiago/Lal capitals. It works fine.
3. I reloaded Civ, deleted one civ. It works fine.
4. I reloaded Civ, deleted a civ in WB, then used "Load Game" to go back to the original file again. Again, it works fine.
5. I reloaded Civ, entered WB, left WB without changing anything, then ended turn. It crashed like it did in 1.
So I can't figure out what is happening, because whether it crashes or not seems to have something to do with long-term Civ IV memory. I will try the debug idea.
1. I tried to end the turn. It crashed almost instantly, before new tech options and all that.
2. I reloaded Civ, deleted all cities in WB except Santiago/Lal capitals. It works fine.
3. I reloaded Civ, deleted one civ. It works fine.
4. I reloaded Civ, deleted a civ in WB, then used "Load Game" to go back to the original file again. Again, it works fine.
5. I reloaded Civ, entered WB, left WB without changing anything, then ended turn. It crashed like it did in 1.
So I can't figure out what is happening, because whether it crashes or not seems to have something to do with long-term Civ IV memory. I will try the debug idea.
Maniac
Apolyton Sage
Are you saying that in test 4, you reloaded the save, you then ended the turn and then it didn't produce a crash, despite the game situation being the same as in tests 1 and 5? Does it matter which faction you delete?
Do you know how to debug with Visual Studio? I used refar's guide in case you need a guide.
Do you know how to debug with Visual Studio? I used refar's guide in case you need a guide.
Panopticon
Utilitarian
I deleted a civ - any civ will work, as far as I can tell - and ended the turn. No problem. Then I reloaded the save file, and simply ended the turn. No problem.
I have compiled but not yet debugged. I have VS 2008 Express. It tells me it needs to convert your project to a new version.
Pfeffersack
Deity
Thank you for picking this up
I made a quick test myself, which supports your findings. Loaded the savegame, went to the worldbuilder, deleted Morgan completely - the tried to end turn...and no more crash! Then I loaded directly - without ending Civ - the original save again, ended turn and had no crash as well (I created a 2186 save then, which loads fine from outside the game as well and lets me continue the game 
)I tried then - after closing Civ4 - again by deleting Miriam and it works fine as well. However, just deleting on city of Morgan still lets the save crash, when ending turn.
However, if I load the original save directly from outside and press enter, I still run into the crash again.
Maniac
Apolyton Sage
Have you tried with two different factions?
Could you please redo this test, with autosaves turned off?
I can't remember ever encountering something like this though.
That's the free edition right? If so, I guess you must have done something different than me. In case this might help, I have attached the makefile and the instructions I followed. They're for VS 2005, but IIRC they're still valid. At least I got everything working without a problem.
Maniac
Apolyton Sage
Have you guys also tried loading the save, immediately reloading the save, and then pressing end turn, without any worldbuildering?
Pfeffersack
Deity
I tried and it seems to have no impact which faction is destroyed...
Maniac said:
...because it seems that worldbuildering isn't needed - indeed loading the save from outside the game, then immeditely reloading it inside the game makes the save crashing no longer as well
However, just loading the Planetfall mod alone and then loading the save once from in game does not help to avoid the crash.
Maniac
Apolyton Sage
Hmm, this might be a general enough question that I could ask it in the SDK & Python forum. Perhaps I'm not initializing some value somewhere or something.
I'll wait a little and see if Panopticon can get a debug DLL working.
I'll wait a little and see if Panopticon can get a debug DLL working.
Panopticon
Utilitarian
Sorry, I ended up playing Victoria. 
I'll try now.
I'll try now.Panopticon
Utilitarian
I'm afraid I can't compile the DLL correctly. It gives me an Abort/Retry/Fail error upon load.
Maniac
Apolyton Sage
With all DLLs, or only the debug DLL? I always get the following message with the debug DLL, but I can just click Ignore, and the game works just fine.
Panopticon
Utilitarian
OK I'll click Ignore.
Panopticon
Utilitarian
This is what I have gathered:
In CvCity:
doTurn calls doRiots calls angryPopulation calls unhappyLevel calls getReligionPercentAnger calls getReligionCount calls isHasReligion.
The last line of isHasReligion, line 10800, is where the programme crashes. It simply reads "return m_pabHasReligion[eIndex];". My programming experience is very limited, but it looks like it might be calling an incorrect part of memory. I can't find any of the variables in memory, e.g. which city it is.
Unfortunately Visual Studio has just crashed, so that's all I can remember.
Maniac, do you have any tips on how I should use debug mode to isolate a CTD caused by CvCity?
In CvCity:
doTurn calls doRiots calls angryPopulation calls unhappyLevel calls getReligionPercentAnger calls getReligionCount calls isHasReligion.
The last line of isHasReligion, line 10800, is where the programme crashes. It simply reads "return m_pabHasReligion[eIndex];". My programming experience is very limited, but it looks like it might be calling an incorrect part of memory. I can't find any of the variables in memory, e.g. which city it is.
Unfortunately Visual Studio has just crashed, so that's all I can remember.
Maniac, do you have any tips on how I should use debug mode to isolate a CTD caused by CvCity?
Panopticon
Utilitarian
When it checks New Jerusalem for religions, it starts forgetting things like New Jerusalem's name. I don't have any other information, I'm afraid; it's all a bit cryptic.
Maniac
Apolyton Sage
m_pabHasReligion, that's the same issue as the previous crash report by Pfeffersack. That code hasn't been altered by Planetfall at all.
To figure out if it's Vista or something with Pfeffersack's install which causes m_pabHasReligion to get messed up, could you please download and load the save attached in this post, and end the turn TWICE, to 2367?
Myself I got a crash when ending turn of a 2366 Pfeffersack save, but didn't get one when ending turn twice on a 2365 save. Pfeffersack however also got a crash upon ending turn of the 2365 autosave twice.
To figure out if it's Vista or something with Pfeffersack's install which causes m_pabHasReligion to get messed up, could you please download and load the save attached in this post, and end the turn TWICE, to 2367?
Myself I got a crash when ending turn of a 2366 Pfeffersack save, but didn't get one when ending turn twice on a 2365 save. Pfeffersack however also got a crash upon ending turn of the 2365 autosave twice.
Pfeffersack
Deity
Maybe this is useful as well - when I pick up my very orginal "2366crashfile" (which crashes for you as well) and do the load from outside of the game, then reload immediate from ingame procedure, the save no longer crashes. It is a quite long interturn and Menschenwimmeln switches over to barbarian control and creates two Partisan units.
Here is a picture and a save after the interturn:
Maniac
Apolyton Sage
Looks like the crash is indeed caused by the base switching owner. The m_pabHasReligion check comes shortly after the base switches owners.
Could you please test if any of your two crashing saves still crash with the attached DLL?
Could you please test if any of your two crashing saves still crash with the attached DLL?
Pfeffersack
Deity
Panopticon
Utilitarian
Hurrah!
