FfH2 0.31 Cosmetic Issues

[Shakiko]

Just got the "dwarven adept transforms copper into gold"-event:
It's just a minor error, but option #1 reads:
- Yes, we could use the gold to fill out vaults.

----------

"Bandit Lord Nietz"-event:
Option #3: Everything's fine, but at the end of the sentence there is a "[]" instead of an exclamation mark (or point)
(Btw, is it intended that you can see how long you'll get +1 Happiness when choosing option #1 and #2, but can't see how long the -5 unhappiness lasts ? )


In case you choose to take Option #3, the unit "Nietz" you get is totally messed up (Str -3, some 8-digit movement points, -12 digit city bombard and so on...)
I uploaded a savegame here

-----------------
"Tree sparkling with a 1000 of lights"-event:
Option #2: Hire some spirits to calm those spirits ...

I'm not that sure about this one, but shouldn't it read like "Hire some priests..." or something similar like that ?

At the end of the last Option (#4 in this case) I get another "[]" instead of a point/exclamation mark again.
Strangely this isn't true for all events so far, just the 2 mentioned in this post.

On top of that, if you choose Option #2 the armageddon counter does not decrease.

 

[KillerClowns]

[*]Lucian_Pedia probably ought to be slightly re-worded to make it read better: "The secret of a forced march, promise the men paradise at the other end. For the Doviello that is a feast." changed to "The demand of a forced march, promising the men a feast at the other end. For the Doviello that is paradise."

The way you'd change it, it would state that the forced march itself is the paradise. I read it differently, and think it should be changed to:
The secret of a forced march is to promise the men paradise at the other end. For the Doviello, that paradise is a feast.

 

[MagisterCultuum]

Actually, I think that his suggestion would really be saying that the act of promising is paradise to the Doviello.

Just changing the comma in the original to a colon would be best I think (I read it the same way you did, but having it as a command seems more forceful) . It is probably also better to say "that paradise is a feast" though, just to be clear.

 

[xienwolf]

I like how you worded it Killer, I honestly couldn't understand why it said secret at all, so I ditched the word. But your way it makes sense.

 

[Zifnab]

Not sure if this has been mentioned before, but you can see that Cardith Lorda follows the Council of Esus as shown in the picture.

 

[MagisterCultuum]

That is well known, but I would like to see it addressed.


I just read the new history in patch d. Overall I like the new changes to the story, but on my first read through I'm thinking much of it could use rewording, because the style just doesn't seem as good as before. I believe I also saw several typos (wrong commas, mispellings, odd tenses, etc), but the only one I remember is "Teybrrn Asbandi" is misspelled.

 

[xienwolf]

I do believe that you changed the wrong event entry for the Obelisk events. You changed DEDICATE_OBELISK_1 to yield 2 instead of changing DEDICATE_OBELISK_2 to yield 2 (Since that was what people claimed would balance the options).

TXT_KEY_CONCEPT_FALL_FROM_HEAVEN_HISTORY_PEDIA

• "This orb he named Temporance Temperance" Unless you are meaning to make up a word based on Temporal
• "The one One entered creation where he stood upon a white stone slab and viewed all things." In General there are many places with need of Capilalization or Commas, but I am ignoring most for now. This one seemed important though.
• "Seeing Agares's blasphemy he sought to remove it from all of creation Creation." This is purely asthetical because you very shortly after use the same phrase "all of Creation" and it flows poorly when words are repeated in a non-lyrical context
• "Dragons, giants, great elementals and the gods themselves unleashed incredible magic and threaten threatened to destroy creation with it." From this point on much of what you write is in the present tense instead of the past tense. It is mildly odd, but not technically wrong, as long as the tense change isn't within a single sentence, to my knowledge. However, since this article is the History of Erebus, speaking in present tense makes it feel less like a story and more like notes
• "the Hippus; horselords and mercenary's mercenaries;" I thought there was a problem with using apostrophes in the text file and so you avoided them? If that isn't the case then there are as many of those missing as commas!
• "With Bhall fallen their lord was unopposed, and this the dispossessed people saw an opportunity to have more than the scraps left for them by the rest of humanity."
• "The gods considered this breaking of the compact."
• "Lead by Tebryn Asbandi Arbandi and Os-Gabella they are called the Sheaim, powerful summoners who share their secrets openly."

Personal Gripes/Questions:

Is it intentional that Agares' Personal World is called Nyx, and we have a Svartalfar unit named the Nyxkin? Seems the wrong race to have it if the names are connected...

Who is Kheldon Ki (Creator of the Dwarves), why is he imprisoned and how can he create an entire Race? It seems he ought to have been mentioned before he is if possessed of such power, and thus I wonder if you meant Odio (the only Archangel who is said to be imprisoned), even though it makes little sense that way either (unless he is sucking up to Kilmorph).
EDIT: Ok, I found the answer to this one myself. But it needs to be a bit clearer in the story that though Kheldon created them, Kilmorph gave them life IMO. Overall I wouldn't mind if the entire history was made a LOT shorter by only vaguely mentioning some of the bits which are detailed elsewhere in the pedia and possibly giving a link to those entries for people wanting more. But I can understand why you might want a "Reader's Digest Condensed" version of all the stories so that it can be read in one sitting.

Kylorin's Students: You mention which are Elven, but don't mention which are Aifon or Dwarven? I know at least 1 was an Aifon because you talk about Trenton a short while later.

 

[xienwolf]

In CvGameUtils.py:

Brewery is listed twice as "Cannot Construct" while running Crusade.
Why isn't Workboat also denied during Crusades?

It seems that Graveyard should be added to this list:

Spoiler :

		if pUnit.getOwner() == gc.getBARBARIAN_PLAYER():
			pPlot = pUnit.plot()
			if pPlot.getImprovementType() == gc.getInfoTypeForString('IMPROVEMENT_BARROW') or pPlot.getImprovementType() == gc.getInfoTypeForString('IMPROVEMENT_RUINS') or pPlot.getImprovementType() == gc.getInfoTypeForString('IMPROVEMENT_HELLFIRE') or pPlot.getImprovementType() == gc.getInfoTypeForString('IMPROVEMENT_BEAR_DEN') or pPlot.getImprovementType() == gc.getInfoTypeForString('IMPROVEMENT_LION_DEN'):
				if pPlot.getNumUnits() == 1:
					return 1

In CvEventManager.py:

You define for OnCityBuilt that if a city is built on a mana node to clear the Mana node, but you had defined elsewhere that a city cannot be built on a Mana Node, so this should be useless.

In CustomFunctions.py

Why is there a function "getHero" when the Hero unit is also defined in the CIV4CivilizationInfos.xml? Hopefully One of them is obsolete or it will be easy to cause bugs if Hero units are ever renamed.

Why is it LESS likely for a high XP unit to become a Manes or Angel upon death?

The following chunk of code from WarScript is useless since you do not spend any turns actually in the process of making those Altars

Spoiler :

if (pPlayer2.getBuildingClassMaking(gc.getInfoTypeForString('BUILDINGCLASS_ALTAR_OF_THE_LUONNOTAR_DIVINE')) > 0 or pPlayer2.getBuildingClassMaking(gc.getInfoTypeForString('BUILDINGCLASS_ALTAR_OF_THE_LUONNOTAR_EXALTED')) > 0):
							if pPlayer.getAlignment() == gc.getInfoTypeForString('ALIGNMENT_EVIL'):
								if eTeam.getAtWarCount(True) == 0:
									self.startWar(iPlayer, iPlayer2)

 

[Kael]

Thats awesome feedback xienwolf, im not a programmer in any fashion so i appreciate anyones help trying to improve my butchered code.

I dont really want barb untis guarding graveyards (I thought about having barb undead sitck around on them but I havent done that yet).

I dont mind the extra check on the mana nodes, who knows what methods we will use to drop cities in the future and it doesnt cost much to keep that check.

The same with getHero, I couldnt probably rewrite into SDk calls but its okay for now.

Having Xp makes it more likely that a mane or angel will be produced. At least thats how im reading it.

I cleaned up the 2nd brewery, disabled workboats during crusades, and switched the warscript so they will actually declared war now. Great stuff!

 

[xienwolf]

You are right, the != caught me and made me read the Angel/Manes gifting backwards.

I'll be going through Spells sometime soonish hopefully to offer some more feedback. I don't ENTIRELY understand all of python quite yet sadly so I can't five perfect information, but glad to help where I can

 

[Inkling]

i just played to turn 134 before suddenly realizing my capital was 2 tiles away from the prison of odin. honestly, i checked the civilopedia and reloaded, thinking that it surely must have been revealed with some technology, but it so easily blends in with the dark terrain that i was oblivious that it was sitting there the whole time. obviously you don't want the thing neon or anything like that, but it would be nice if it were slightly more prominent, assuming its easy to do.
Please do not misunderstand me, its a very nice graphic, it just blends a little too well.

 

[seZereth]

i just played to turn 134 before suddenly realizing my capital was 2 tiles away from the prison of odin. honestly, i checked the civilopedia and reloaded, thinking that it surely must have been revealed with some technology, but it so easily blends in with the dark terrain that i was oblivious that it was sitting there the whole time. obviously you don't want the thing neon or anything like that, but it would be nice if it were slightly more prominent, assuming its easy to do.
Please do not misunderstand me, its a very nice graphic, it just blends a little too well.

hmm, well i never thought that, as it is really huge (the prison)

 

[Inkling]

hmm, well i never thought that, as it is really huge (the prison)

ah, but the dark and gloomy forest is bigger.

i only noticed him when one of my units stood just above him, then i saw the arm, cause it lined up perfectly at that zoom level so it looked like the units emblem was a little flag in odin hand.

 

[black_imperator]

thanks for the french translations issue, xienwolf, I corrected them. But i didn't understand the "period" thing. can you show me exactly what it is ?

 

[xienwolf]

Actually that was typically done everywhere BUT in the german & french translations.

All that happened was removing a lot of periods at the end of a sentence. So for instance it would change:

The rain in Spain falls mostly on the plain.

to:

The rain in Spain falls mostly on the plain


So I just mentioned it because it seemed wierd that someone would take the time to do so much tedious work that seemed useless (maybe it was part of the conversion that Kontroller had asked for for encoding?)

 

[xienwolf]

Just wanted to ask to be certain:

Did you intentionally make Winterborn available through Mutation? It seems appropriate since there are other Resistance promotions available, but seems odd since it is essentially a "Raical" promotion.

EDIT: Summon Djinn still has the Pedia text from Summon Earth Elemental

 

[Grunthex]

Apologies for not screencapping to get the exact text, but whenever your Mimics (Balseraph) win a combat, you get the text key about stealing a promotion, instead of a real message (like TEXT_STOLEN_PROMOTION_BLAH_BLAH)... that's not the exact message, but you get the idea.

 

[smjjames]

Here is one, Kandros Fir is referring to Ethne the White and Hannah the Irin as he, but they are both female! lol, and no I didn't do random leader personalities and I'm playing as one of the female leaders of Ljossafar.

 

[Mewtarthio]

"Bah. How are we dwarves to recognize human women? We can barely recognize human men! Half you people don't even wear beards!"

 

[black_imperator]

I don't know if it has already been reported but the manticore Pedia entry still explain they need the large animal stable to spawn.