[Fixed][1.0.0.262] Harald's boost for naval melee ships not working for Longships

[Infixo]

Norwegian Longship has no PseudoYield assigned and Harald has a boost for Naval Melee ships in his strategy! Effectively, this boost doesn't work for his most important unit.

UPDATE Units SET PseudoYieldType = 'PSEUDOYIELD_UNIT_NAVAL_COMBAT' WHERE UnitType = 'UNIT_NORWEGIAN_LONGSHIP';

Someone could think that Longship, being the UU, is boosted enough. However all other unique ships like Jong, De Zeven Provincien, U-Boat, Minas Geraes, Seadog - they all have this PseudoYield.

 

[Laurana Kanan]

Not sure what you mean by boost here. Isn't 'PSEUDOYIELD_UNIT_NAVAL_COMBAT' only the AI preference for building naval combat units?

I don't think I've seen a lack of Longship builds by Norway. And, in any event, 'PSEUDOYIELD_UNIT_NAVAL_COMBAT' is already attached to Harold's Leader Agenda "Last Viking King" with a value of 100. So he's already predisposed to building these types of naval units. So would adding a value to the pseudoyield column of the Longship unit essentially be redundant and/or possibly cause a conflict?

 

[Infixo]

I don't think I've seen a lack of Longship builds by Norway.

Probably because this is his UU. In Civ5 all uniques were extra boosted by default and I believe the same approach is used in Civ6.

, 'PSEUDOYIELD_UNIT_NAVAL_COMBAT' is already attached to Harold's Leader Agenda "Last Viking King" with a value of 100. So he's already predisposed to building these types of naval units. So would adding a value to the pseudoyield column of the Longship unit essentially be redundant and/or possibly cause a conflict?

That's the point - it is added to his agenda but doesn't do anything. Having this is his agenda means that he will value more units that are marked as PSEUDOYIELD_UNIT_NAVAL_COMBAT. However, Longship is NOT. That is the only exception - see my second comment about other UUs.

I find it really bizarre that Longship is the only naval unit without that param and my other explanation, beside a bug, is that it was removed on purpose because Longship is his UU and is already boosted. But this is a bad implementation. If that was the case,
- all ships should have PseuoYield set properly
- Harald should have a boost for Naval Melee
- to remove a boost from Longship, you need to use AiList Units with Longship and set its Value = -100 to counter boost from PseuoYield.

 

[Infixo]

The issue has been corrected in Gathering Storm.
From Units.xml: <Row UnitType="UNIT_NORWEGIAN_LONGSHIP" Cost="65" Maintenance="1" BaseMoves="3" BaseSightRange="2" ZoneOfControl="true" Domain="DOMAIN_SEA" Combat="30" FormationClass="FORMATION_CLASS_NAVAL" PromotionClass="PROMOTION_CLASS_NAVAL_MELEE" AdvisorType="ADVISOR_CONQUEST" Name="LOC_UNIT_NORWEGIAN_LONGSHIP_NAME" Description="LOC_UNIT_NORWEGIAN_LONGSHIP_DESCRIPTION" PurchaseYield="YIELD_GOLD" PseudoYieldType="PSEUDOYIELD_UNIT_NAVAL_COMBAT" MandatoryObsoleteTech="TECH_ELECTRICITY" TraitType="TRAIT_LEADER_UNIT_NORWEGIAN_LONGSHIP" PrereqTech="TECH_SAILING"/>