Your pseudo-code does show me I should be explicitly saving the data immediately if it changes though.
In Reminders I load the queue in the OnLoad event and save it in OnPreSave. There's no reason to save it every time it changes. It's not a huge deal, and eventually I'll rewrite SdToolkit to do the same thing for all mods, but I tend to optimize up-front since I don't have an analysis tool for Python.
A couple random notes while looking over your code. I hope you don't mind. I'm a) trying to maintain a coding standard for BUG code (this will be the start of it), b) using it as a way to go through the code so I understand it, and c) love giving coding advice without being asked.
1. You only need to declare a variable as a global if you are going to assign it a new value. You can freely modify the object it points to (a list or set or some other mutable object) without declaring it global.
2. gc.getActivePlayer() always returns a human. It is the human that is sitting at the computer. I typically even skip the check for None and isNone() with it because if those fail, the game has clearly gone off into the weeds.
This is a matter of saving you typing and making code easier to read. It won't cause any problems or slowdown.
3. Python deals with "not" in if-tests well. No need to wrap "not x" in ()s. I find this easier to read as matching up ()s can be a PITA. Also, comparison operators have higher precedence than boolean operators (and or not), so you have more opportunities to trim ()s.
4. If you're going to use the players' teams throughout a block of code, it improves readability to assign them to variables. Ah, and after doing the search/replace, I see you only used them twice and once. It's still good for shortening the overall line lengths.
That's my story and I'm sticking to it!
5. Please use BugUtil.debug() instead of CvUtil.pyPrint(). This way all debugging can be centrally controlled, and eventually you will be able to enable/disable it from the options screen.
6. It looks like you print out that you've found an AI's favorite civic each time doUpdate() is called once you've found it.
7. Make sure to skip all possibilities where the same player is checked against itself.
8. Always put spaces around binary operators, including % between the string and its replacement values. Always put a space after a comma.
9. Consider replacing the string keys used in the dictionaries with integer constants. This will save space and time when packing into the saved game.
POSSIBLE_FAVORITES = 0
FAVORITE_CIVIC = 1
10. Using global variables like this can get dicey, but for something like this it works okay. If you want to expand your Python knowledge, consider creating a class to hold the data for each AI with functions for modifying the data. (next post)
Code:
'def doUpdate ():
""" Goes through the current diplomacy situation to determine potential favorite civics for each civ. """
if isDetectionNecessary():
iActivePlayer = gc.getGame().getActivePlayer()
pActivePlayer = gc.getActivePlayer()
pActiveTeam = gc.getTeam(pActivePlayer.getTeam())
if not pActivePlayer or pActivePlayer.isNone() or not pActivePlayer.isHuman():
return
for iPlayer in range(gc.getMAX_PLAYERS()):
if iPlayer == iActivePlayer:
continue
pPlayer = gc.getPlayer(iPlayer)
iTeam = pPlayer.getTeam()
pTeam = gc.getTeam(iTeam)
if ( pPlayer and not pPlayer.isNone() and pPlayer.isAlive()
and not pPlayer.isBarbarian() and not pPlayer.isHuman()
and pActiveTeam.isHasMet(iTeam) ):
BugUtil.debug("Checking Player %s (ID %d)" % (pPlayer.getName(), iPlayer))
if not isFavoriteCivicKnown(iPlayer):
for iOtherPlayer in range(gc.getMAX_PLAYERS()):
if iOtherPlayer == iPlayer:
continue
pOtherPlayer = gc.getPlayer(iOtherPlayer)
iOtherTeam = pOtherPlayer.getTeam()
if ( pOtherPlayer and not pOtherPlayer.isNone()
and pOtherPlayer.isAlive() and not pOtherPlayer.isBarbarian()
and pActiveTeam.isHasMet(iOtherTeam) and pTeam.isHasMet(iOtherTeam) ):
BugUtil.debug(" -- Testing against Player %s (ID %d)" % (pOtherPlayer.getName(), iOtherPlayer))
bFoundPossibleFavorite = AttitudeUtils.hasModifier(iPlayer, iOtherPlayer, "TXT_KEY_MISC_ATTITUDE_FAVORITE_CIVIC")
for iCategory in range(gc.getNumCivicOptionInfos()):
iCivic = pPlayer.getCivics(iCategory)
if (iCivic == pOtherPlayer.getCivics(iCategory)):
if bFoundPossibleFavorite:
BugUtil.debug(" -- Players share %s's favorite civic!" % (pPlayer.getName()))
BugUtil.debug(" -- (%d) %s: (%d) %s might be it" % (iCategory, gc.getCivicOptionInfo(iCategory).getText(), iCivic, gc.getCivicInfo(iCivic).getText()))
addPossible(iPlayer, iCivic)
else:
BugUtil.debug(" -- Players do not share %s's favorite civic." % (pPlayer.getName()))
BugUtil.debug(" -- (%d) %s: (%d) %s is NOT it" % (iCategory, gc.getCivicOptionInfo(iCategory).getText(), iCivic, gc.getCivicInfo(iCivic).getText()))
addNotPossible(iPlayer, iCivic)
else:
if bFoundPossibleFavorite:
BugUtil.debug(" -- Players share %s's favorite civic!" % (pPlayer.getName()))
BugUtil.debug(" -- (%d) %s: (%d) %s is NOT it" % (iCategory, gc.getCivicOptionInfo(iCategory).getText(), iCivic, gc.getCivicInfo(iCivic).getText()))
addNotPossible(iPlayer, iCivic)
# using the direct length rather than the getNumPossibleFavoriteCivics() accessor
iNumFavorites = len(gFavoriteCivicData[iPlayer]['iPossibleFavorites'])
if iNumFavorites == 1:
BugUtil.debug("We found the favorite civic for %s (ID %d)!" % (pPlayer.getName(),iPlayer) )
iCivic = gFavoriteCivicData[iPlayer]['iPossibleFavorites'][0]
iCategory = gc.getCivicInfo(iCivic).getCivicOptionType()
BugUtil.debug("-> It's (%d) %s in the category (%d) %s" % (iCivic, gc.getCivicInfo(iCivic).getText(), iCategory, gc.getCivicOptionInfo(iCategory).getText()))
gFavoriteCivicData[iPlayer]['iFavoriteCivic'] = iCivic
gFavoriteCivicData[iPlayer]['iNotFavorites'] = []
gFavoriteCivicData[iPlayer]['iPossibleFavorites'] = []
elif iNumFavorites == 0:
BugUtil.debug("Don't have any possibilities at all yet!")
else:
BugUtil.debug("Still too many possibilities.")
dataDump(iPlayer)
dataDump()
)
Yeah the only reason I used teams was for the isHasMet() checks. I generally don't bother with variables if I'm using a function that sparsely.
