Great People Name Not translated properly.

zx1111

Warlord
Joined
Oct 31, 2005
Messages
235
Names of all the Great People are not translated. They are displayed only in "English" name in "Assets/XML/Units/CIV4UnitInfos.xml"
Changing localized names in "Assets/XML/Text/CIV4GamesTextInfos_Greatpeople.xml" has NO effect.

This may not bug, but design/implementaion error, I think.
Proper solution should be like below.

In "Assets/XML/Units/CIV4UnitInfos.xml"
Code:
<UnitInfo>
	<Class>UNITCLASS_ARTIST</Class>
	<Type>UNIT_ARTIST</Type>
	<UniqueNames>
	<UniqueName>Homer</UniqueName>
.....
This should be changed like
Code:
<UniqueNames>
	<UniqueName>TXT_KEY_GREAT_PERSON_HOMER</UniqueName>

And displayed after translation by localText.getText(pyUnit.getNameKey())

Currently CyUnit.getNameKey() returns same string as CyUnit.getNameNoDesc().

I think that ...
CyUnit.getNameKey() should return "TXT_KEY_GREAT_PERSON_HOMER"
CyUnit.getNameNoDesc() should return "Homer" or translated "Omer" in Italian.
CyUnit.getName() should return "Homer (Great Artist)"

PS) I suggest to include description (like "Great Artist") in "Great People was born" announcement. and event logging.
i.e. "Hormer (Great Artist) was born in Washington"...
.
 
Back
Top Bottom