Historic Ship Names Modcomp [WIP]

orlanth · Mar 12, 2010

As a Perl learning project, I made some quick regular expressions to extract arrays of historic ship names from wikipedia articles. It worked well and I'll paste a list of the resulting ship names below.

Spoiler :

I'm hoping to make use of these lists by making a quick modcomp that anyone can include in their mods, which randomly assigns an appropriate historic ship name from the above lists to each ship unit in the game. I've got a bit stuck on the Python part though, I guess I'm not understanding the object names correctly. Here is what I tried so far:

In CyEventManager.py, added the following block

PHP:

#shipname modcomp
		unit = iPlayer.getUnit(iUnitId)
		if unit.getUnitCombatType() == gc.getInfoTypeForString('UNITCOMBAT_NAVAL'):
			newName = NameGen(unit)
			unit.setName(newName)
#end shipname modcomp

to these existing functions:
def onUnitCreated(self, argsList):
def onUnitBuilt(self, argsList):
def onUnitBoughtFromEurope(self, argsList):

And here's an outline of a function to assign the random ship names:

Spoiler :

where the actual historic lists could be pasted in when working.

To TC01, Androrc, or anyone with python skills, could you maybe help out with getting this into a working modcomp? Whoever is the first to finish it gets to name some ships after themselves!

Androrc the Orc · Mar 13, 2010

I'm not very good with python either... I believe this could be done through the SDK and xml though, changing the already existing "<UniqueNames>" field in UnitInfos to account for different civilizations, like this:

Code:

			<Type>UNIT_CARAVEL</Type>
			<Class>UNITCLASS_CARAVEL</Class>
			<UniqueNames>
				<CivilizationUniqueName>
					<Civilization>CIVILIZATION_SPAIN</Civilization>
					<UniqueName>Nina</UniqueName>
					<UniqueName>Pinta</UniqueName>
					<UniqueName>Santa Maria</UniqueName>
				</CivilizationUniqueName>
			</UniqueNames>

And then replace the check in CvUnit.cpp for the unit's name with an appropriate check. Well, it could work.

TC01 · Mar 13, 2010

What exactly isn't working?

Do you have Python exceptions turned on?

orlanth · Mar 13, 2010

After some trial and error, I think I've almost got it working. The remaining issue seems to be that it's not getting the unit owner's civilization type correctly (eg CIVILIZATION_SPAIN). I'm using the code below, but pCiv seems to never match the if statements and always just uses the default contents of lName. There are no python exceptions. Any ideas how to access civ type appropriately?

Spoiler :

TC01 · Mar 13, 2010

Code:

pCiv = pPlayer.getCivilizationType

I think you're missing a "()" on the end of this line.

orlanth · Mar 13, 2010

Doh! You're right TC01. I must have been smoking too much Soma.. :crazyeye:

Looks like it's nearly working now, just have to add something to name the starting ships & hopefully I'll post the modcomp soon.

orlanth · Mar 13, 2010

Great, here's the (almost) completed modcomp. The changes are limited to several blocks in CvEventManager.py marked with "#shipnames modcomp" so it should be easy to add to an existing mod.

The last remaining issue is that it doesn't assign names to the starting ships; I unsuccessfully tried adding the block below to onBeginGameTurn and also tried it on onGameStart. I guess that doesn't matter too much though.

Spoiler :

Androrc the Orc · Mar 13, 2010

Did you try setting the:

Code:

        if iGameTurn == 1:

to

Code:

        if iGameTurn == 0:

?

Anyway, this modcomp is looking good

orlanth · Mar 13, 2010

Solved it! Just needed to add
player = gc.getPlayer(iPlayer)
to the block. Well I'll post it in the files forum so anyone can use it.

Anyway, this modcomp is looking good

Obrigado! Se vc quiser, para o seu mod posso fazer listas para Russia e Sweden. The wikipedia only shows 6 ships for Austria though

Androrc the Orc · Mar 13, 2010

orlanth said:
Solved it! Just needed to add
player = gc.getPlayer(iPlayer)
to the block. Well I'll post it in the files forum so anyone can use it.

Obrigado! Se vc quiser, para o seu mod posso fazer listas para Russia e Sweden. The wikipedia only shows 6 ships for Austria though

Sim, eu gostaria bastante

Androrc the Orc · Mar 28, 2010

I noticed a small "bug"; when a ship is gained through a founding father, it doesn't get a name.

Historic Ship Names Modcomp [WIP]

orlanth

Storm God. Yarr!

Attachments

Androrc the Orc

Emperor

TC01

Deity

orlanth

Storm God. Yarr!

TC01

Deity

orlanth

Storm God. Yarr!

orlanth

Storm God. Yarr!

Androrc the Orc

Emperor

orlanth

Storm God. Yarr!

Androrc the Orc

Emperor

Androrc the Orc

Emperor

Similar threads