Huh. I've barely ever used Python, so I wasn't aware of that. I tried again, with a new copy-paste, but it still didn't work, though. The indentation of the first line didn't change visibly when I overwrote the old stuff.
[MOD] MagisterModmod
- Thread starter MagisterCultuum
- Start date
MagisterCultuum
Great Sage
Just found one more bug.
in both lines 35548 and 35585 of CvSpellInterface.py it seems I forgot to change pCity to pUnit
While fixing that I noticed that the code would also have a problem if the spell was miscast by a player with no capital city, so I added checks to stop that too in this fixed code.
It should be like this
I used tabs in the code but just noticed that when I copied the code from my last post that it changed everything to spaces. Python can use spaces instead of tabs but you have to be really consistent. Generally it will interpret 4 spaces and 1 tab, but sometimes may use 8 spaces per tab. Having 3, 5, 7, or 9 tabs can bad. It is best to just use tabs. Notepad ++ should change the spaces to tabs if you highlight a block of code and press the tab key to indent it all, and then shift+tab at the same time to unindent it.
Code:
Traceback (most recent call last):
File "CvSpellInterface", line 115, in miscast
File "<string>", line 0, in ?
File "CvSpellInterface", line 35585, in miscastSteal
UnboundLocalError: local variable 'pCity' referenced before assignment
ERR: Python function miscast failed, module CvSpellInterfacein both lines 35548 and 35585 of CvSpellInterface.py it seems I forgot to change pCity to pUnit
While fixing that I noticed that the code would also have a problem if the spell was miscast by a player with no capital city, so I added checks to stop that too in this fixed code.
It should be like this
Spoiler :
Make sure you have the ¶ (Show All Characters) toggle button turned on so that you can see the difference between tabs, spaces etc.
I used tabs in the code but just noticed that when I copied the code from my last post that it changed everything to spaces. Python can use spaces instead of tabs but you have to be really consistent. Generally it will interpret 4 spaces and 1 tab, but sometimes may use 8 spaces per tab. Having 3, 5, 7, or 9 tabs can bad. It is best to just use tabs. Notepad ++ should change the spaces to tabs if you highlight a block of code and press the tab key to indent it all, and then shift+tab at the same time to unindent it.
That worked. Thanks!
What the heck? I don't know if this is vanilla FFH, or the modmod, but I've been attacked by a barbarian Aquilan really early game. Like "just researched bronze working and am building my first axemen" early. Is this meant to happen, and if so, how am I meant to deal with a 15 strength enemy that can move way faster than anything I can field?
Update: I have a second, completely unrelated question. Is there a way to stop the Grigori adventurers from downgrading if you don't want them to? I can't use them to cast spells on my cities long term because they reset to adventurer and lose their free promotions.
Edit: Or...do they? I'm so confused, my adept adventurers seem to have gained several different spell promotions that don't match up at all with the mana I have access to.
Update: I have a second, completely unrelated question. Is there a way to stop the Grigori adventurers from downgrading if you don't want them to? I can't use them to cast spells on my cities long term because they reset to adventurer and lose their free promotions.
Edit: Or...do they? I'm so confused, my adept adventurers seem to have gained several different spell promotions that don't match up at all with the mana I have access to.
Last edited:
Nothrazim
Warlord
- Joined
- Oct 12, 2009
- Messages
- 152
Aquilians spawning from lairs was removed by Magister some time ago, but it might still be spawnable from Letum Frigus by exploration. I am not sure if they are a timed duration spawn or pemanent - but they ought be timed at least.
The Adventurer promotion will randomly cause them to revert, but only in cities. So unfortunately aside from some early game Muse or Ring of Warding, they tend to lose value pretty quickly as city mages. Though since the Grigori have 2 of each mana to start with, getting a few Adepts with Creation Affinity is easier than for other civs (especially if you also get the Museum of Maponos).
I don't recall precisely how Adepts getting their first random spell works, but i think it is random albeit heavily favoured towards mana you have access to. The two adepts the Amurite start with can have any spell sphere promotion to begin with, although it favours the civ/leader choice as usual.
The Adventurer promotion will randomly cause them to revert, but only in cities. So unfortunately aside from some early game Muse or Ring of Warding, they tend to lose value pretty quickly as city mages. Though since the Grigori have 2 of each mana to start with, getting a few Adepts with Creation Affinity is easier than for other civs (especially if you also get the Museum of Maponos).
I don't recall precisely how Adepts getting their first random spell works, but i think it is random albeit heavily favoured towards mana you have access to. The two adepts the Amurite start with can have any spell sphere promotion to begin with, although it favours the civ/leader choice as usual.
MagisterCultuum
Great Sage
An Aquilan in the early game does seem quite odd. The only ways I can think of an Aquilan showing other than being summoned by a High Priest of the Hand (or the high priest versions of Anagantios, Riuros, or Dumannios), in which case they would have limited duration, is being spawned by the doFlareDimensionalNode random event. That can only happen on a tile with either a Dimensiona Node or a Planar Gate. Are there more advanced players in the game who might have built a Dimensional Node or Planar Gate?
Spoiler :
Adventurers get bored easily if left in safe cities, but they won't revert types if away from a city, or if the city is mosly a foreign culture, or is still under occupation, or if there are any hostile units (including hidden nationality units of neutral players) nearby.
Spoiler :
The rather complicated code is here:
Spoiler :
The Grigori don't get 2 sources of each type of mana from their palaces anymore in the newest version. I got rid of that when I added the Monothiest Meetinghouse temple building for the Children of the One.
That is a bug I had not noticed before.
My first few attempts to fix it (adding delayed death checks, checking the req within the spell, etc) did not work.
Ultimately the only thing that did help was restoring a few lines that I had commended out, giving the commander the golem promotion and killing.
At one point I recall I used to apply the commanders promotions, name, religion, etc manually but then found using pCaster.convert(pUnit)worked better. I was thinking killing the unit after pCaster.convert(pUnit) would cause an error as the unit would already be dead by then, but it seems not to have any issues in my test so far.
Spoiler :
The only dimensional mana I can see in worldbuilder are the soul gates and tapestry house, so I don't think it can be that. The Sheaim got defeated quite a long time ago in my game. Worldbuilder records show that they did manage to research Knowledge of the Ether, and its prerequisites. They didn't manage to research anything else so this must have been pretty near their demise, but perhaps they managed to finish the planar gate, got stupidly unlucky and immediately had the Aquilan show up and wipe them out?
Edit: Wait, no, the Sheaim are apparently still around. I guess they came back thanks to a revolution. And they're across the water in the direction the Aquilan came from.
Last edited:
MagisterCultuum
Great Sage
You could look at the code
Spoiler :
Or wait until the next release when I intend to pedia and mouseovers for the temples and religions to make it clear in game. (I had intended to do that before the last release but it somehow slipped by mind.)
In case you cannot read the code and don't want to wait, I'll summarize it here.
The Empyrean's Fenestran Temple will be hostile unless you have the Empyrean State religion, or a Good alignment, or join the Overcouncil.
The Brotherhood of Warden's Safehouse will be hostile unless you have the Brotherhood of wardens State religion, or Good alignment, or the Pacifism civic.
(Note that this does not apply to the Calabim, for whom both versions of the Safehouse are replaced by the Almshouse unique building, since the heterodox Blinded Brotherhood are welcomed there but the Orthodox Wardens who try to fight injustice instead of teaching absolute submission are not. I am thinking of changing this so that other player's Rescuers can found hostile Safehouses in Calabim cities unless the Calabim build an Almshouse there. Note that the Rescue Refugees spell should always be able to be used in cities with a hostile Safehouse, whereas without a safehouse it depends on factors like the current level of hurry anger.)
The Ringgivers's Artificery will be hostile unless you have the Ringgivers State religion, or Good alignment, or the Arete civic (which requires either Runes of Kilmorph or Ringgivers state religion).
The Order's Basilica will be hostile unless you have the Order State religion or Good alignment.
The Unblemished's Healing Garden will be hostile unless you have the Unblemished or Fellowship of the Leaves State religion or Good alignment.
The Rune of Kilmorph's Kilmorphian Grotto will be hostile unless you have the Rune of Kilmorph State religion or a non-Evil alignment and not the Foxmen state religion.
The Undertow's Asylum will be hostile unless you have the Undertow state religion or a non-Good alignment.
The Steward of Inequity's Gambling House will be hostile unless you have the The Steward of Inequity state religion or a non-Good alignement.
The Annointed's Abattoir will be hostile unless you have The Annointed as state religion or the Evil alignment.
The Ember Legion's Tophet will be hostile unless you have The Ember Legion as state religion of the evil alignment.
The Between Coven's Interstice will be hostile unless you have the Coven as you state religion or have the evil alignment and are not Calabim (since they are canonically very much at odds with Ceridwen's other cult called the Chainbreakers, which is merged with The Between and Emrys in my modmod.)
The White Hand's Temple of the Hand will be hostile unless you have the White hand state religion or are a teammate of vassal of Auric Ulvin after the completion of The Draw ritual.
The Council of Esus's Aphotic Throne will be hostile unless you have the Council of Esus state religion, or the evil alignment, or are a member of the Undercouncil.
The other temples do not currently have hostile versions.
I may decide to tweak these prereqs in the next version.
Billlington
Chieftain
- Joined
- Jul 11, 2023
- Messages
- 3
hey! great mod, but im running into an issue - as Lanun, my pirate coves are not upgrading at all. The upgrade timer runs down, and on the turn they're supposed to upgrade, it gives the "needs to be worked" note and then on the next turn the upgrade timer starts over. I have checked - the city is working those tiles, I have warriors and boats stationed on those tiles, and I can't even place upgraded harbors/ports in the worldbuilder - it just places a cove instead.
Last edited:
Dracosolon
Emperor
Do you have any plan to update the "KE huge ICE Empires" map (the one with the civs already spread across Erebus, the Mercurians and Infernals summoned, etc) at some point? I'd be interested in your choice of location for the new resources and Unique Features you've introduced so that I may update the unsettled version of the map in turn. Alternatively, just the general location you'd choose for them would be interesting.
Semi-related: I've noticed that in pre-made scenarios, Dragon Bones seem to reload a random choice of mana every time a new game is started. Is there a way to stop this from happening?
Semi-related: I've noticed that in pre-made scenarios, Dragon Bones seem to reload a random choice of mana every time a new game is started. Is there a way to stop this from happening?
I think i found 2 bugs with Auric Ulvin, and i dont know if they are related. First of, Auric spawns with only "channeling" 2 and 3. Every time he levels up, i have the option to take "channeling 1", with does nothing (you just waste the level). Second, Auric starts with no affinity, and gets an affinity (TEMPORARILY) based on the mana he stands on (see attached screen shot). I do not have entropic mana, but still, he gets entropic affinity. If i move to any tile without entropic mana, he loses it, same as every other mana tile he stands on.
Attachments
Last edited:
There's also a bug with commanders. If you build a unit and this unit has free promotions, "attaching" a commander without picking the promotions will make them vanish, making your unit vanilla (i know this can be edited with ctrl+w, but it is not, try it in game).
Attachments
Billlington
Chieftain
- Joined
- Jul 11, 2023
- Messages
- 3
This seems to have resolved itself. I think maybe it's tied to techs? But if there is a tech requirement it's not listed anywhere I've seen.
Also, is The Draw a particularly reosurce/script heavy ritual? This has been awhile and on the previous version but when it finished the game hangs but doesn't freeze (spinning globe forever). What's odd is that I see everyone else declare war on me and a few cpu actions complete before it hangs.
Last edited:
ssmage
Warlord
The second Auric thing isn't a bug, the tile that he is standing on gives entropy mana, the side bar does not matter for him. And yes, the draw causes everyone who is not teamed or vassaled with auric to dec war on you, this is a big AI tax as the AI starts casting spells everywhere. You could stop a bunch of the casting lag if you could somehow make the interturn go full fog so the game doesn't load the spell effects and sound off screen from tiles you have vision on but are not focused.
The Shades have 0 attack and invisibility, and my workers disappeared without messages.
MagisterCultuum, when to expect a new version of mod? I hope not in a year.
==========
SPELL_BREATH_LIGHT spell does not give effects to own team, it should be?
Last edited:
Similar threads
