Modmodding Q&A Thread
- Thread starter Leoreth
- Start date
1SDANi
Sister Lady
- Joined
- Oct 27, 2014
- Messages
- 2,931
Do you have any idea what to check or what keywords/programs might help me find it? I've searched the terms independent, minorciv, >= 5, and > 4 to no avail.
1SDANi
Sister Lady
- Joined
- Oct 27, 2014
- Messages
- 2,931
I just found this block, don't know how I missed it earlier today.
Code:
if (getCommerceRate(COMMERCE_CULTURE) <= 4)
{
changeCultureTimes100(getOwnerINLINE(), getCommerceRateTimes100(COMMERCE_CULTURE), false, true);
return;
}EDIT: Looking at it, it's probably not the culprit, but it reminded me that <= 4 and < 5 is a thing, It didn't occur to me to look for an inversion.
1SDANi
Sister Lady
- Joined
- Oct 27, 2014
- Messages
- 2,931
I figured it out. As I looked more into the line above I noticed it was to make it so that modifiers are not applied when their culture per turn is 4 or less. When I bumped the Indy's culture modifier up to 100 it was fixed. I was going off of the ctr z command, and when I selected Indy cities it was displaying what the culture would be with either no modifier or with the modifier of my current nation. So that's probably a bug. The fact that city view while using ctr z doesn't take into count the modifier of the selected city's nation.
1SDANi
Sister Lady
- Joined
- Oct 27, 2014
- Messages
- 2,931
Why is it that Gilgamesh refuses to allow their Bowmen to have the Attack City AI? Even when I remove the bowmen's city defense modifier and set the only available AI to be attack city they just build them as Reserves instead of as City Attackers.
Spoiler Gilgamesh :
1SDANi
Sister Lady
- Joined
- Oct 27, 2014
- Messages
- 2,931
I've turned Scouts into a skirmisher unit but now have no idea how to bar independent states from using the UNITAI_EXPLORE, does making a unique unit for them and inserting the following code not work?
Code:
<UnitAI>
<UnitAIType>UNITAI_EXPLORE</UnitAIType>
<bUnitAI>0</bUnitAI>
</UnitAI>
If you want the AI to NEVER use them with UNITAI_EXPLORE, you need to use this: (Note that this is under NotUnitAIs which is directly following UnitAIs.)
Code:
<NotUnitAIs>
<UnitAI>
<UnitAIType>UNITAI_EXPLORE</UnitAIType>
<bUnitAI>1</bUnitAI>
</UnitAI>
</NotUnitAIs>
Last edited:
1SDANi
Sister Lady
- Joined
- Oct 27, 2014
- Messages
- 2,931
Did not know you could do that, thanks!
Tigranes
Armenian
- Joined
- Sep 11, 2008
- Messages
- 9,926
Suppose I made a pull request that Leoreth does not like. How can I cancel my pull request on github? And how then I can sync my fork to look like main develop copy? So that I can make some other new request based on latest official version of this mod?
In general, it is good practice not to make pull requests from your develop branch, but to create a feature branch first. Suppose you want to change uranium locations on the map, you first create a branch e.g. "uranium-locations". This new branch will be identical to your current develop, but when you make changes they only apply to the branch but not to your develop. This way you can keep develop synched to my repository while working on your current changes. If you don't like the branch anymore, you can delete or abandon it, and even work on multiple features at the same time.
However, in case your not aware, if you update a branch of an ongoing pull request these changes will become part of the pull request. So no need to close and reopen it after your changes.
I assume though that you have now made changes to your local develop branch. You should get rid of that by setting your origin to "https://github.com/dguenms/Dawn-of-Civilization.git" and doing a force pull. This will overwrite your changes with my develop state (irretrievably!). The command line is "git pull --force https://github.com/dguenms/Dawn-of-Civilization.git develop".
However, in case your not aware, if you update a branch of an ongoing pull request these changes will become part of the pull request. So no need to close and reopen it after your changes.
I assume though that you have now made changes to your local develop branch. You should get rid of that by setting your origin to "https://github.com/dguenms/Dawn-of-Civilization.git" and doing a force pull. This will overwrite your changes with my develop state (irretrievably!). The command line is "git pull --force https://github.com/dguenms/Dawn-of-Civilization.git develop".
Temüjin VIII
Fluyts, Grand Vizier of Your Mind
Has the administrative center + palace bug already been fixed? I can recall a commit which automatically removes an administrative center when it becomes a capital city. It still does not work for me, but maybe I just messed up my copy of the mod.
Btw, while randomly investigating it, I found the code which is supposed to trigger it in CvRFCEventHandler.py:
I notice that it uses the isHasRealBuilding() function. How is it different from hasBuilding() function?
EDIT: Oh okay, I understand, the trigger is onBuildingBuilt and not onCityAcquired.
Btw, while randomly investigating it, I found the code which is supposed to trigger it in CvRFCEventHandler.py:
Code:
def onBuildingBuilt(self, argsList):
if city.isHasRealBuilding(iAdministrativeCenter): city.setHasRealBuilding(iAdministrativeCenter, False)I notice that it uses the isHasRealBuilding() function. How is it different from hasBuilding() function?
EDIT: Oh okay, I understand, the trigger is onBuildingBuilt and not onCityAcquired.
Temüjin VIII
Fluyts, Grand Vizier of Your Mind
Yes. Mexican spawn, for instance. Again, I may have messed up my copy of the mod because it's so dirty, so I'm not sure if that one has already been accounted for, as well.
Pavel Chichikov
King
- Joined
- May 26, 2012
- Messages
- 674
Where is the TechInfos python data located, it used to be in RiseAndFall.py but it's since been moved?
merijn_v1
Black Belt
You means which techs civs recieve on spawn? That is in Civilizations.py.
I put this on the back burner for a while, but I'm trying do work (and finish) my Israel mod once again. I'm still confused about this. I know how to change the yields of a building in the XML, and I suppose one (poor) solution could be to create a unique building that is identical to the palace, except it has extra yields. But I want to change the yields dynamically. Where in the code should I go? I can't find anything already implemented that looks like what I want to do, and my poor familiarity with most of the code makes it hard to get started.
You can change the yield and commerce outputs of all buildings you control (programmatically, i.e. Python or C++). The game actually uses this for some event effects like extra research for monasteries. Since Palaces are unique and always exist in the capital, that's a good way to do capital based effects. I'm using this for the Colonialism and Tributaries effects for example, see CvPlayer::updateCapitalCommerce() in the DLL. Another place where I use it is wonders since they are also unique, for example Empire State Building and Machu Picchu. Those are controlled by Python.
If your UP depends on a dynamically changing variable, you need to update the Palace yield every time this variable changes. What the precise triggers are depends on the effect. For example, for Empire State Building the initial gold output is set to city size when the wonder is built and then changed when the city shrinks/grows, every time using the right event handler in RFCEventHandlers.py.
In your case it would involve handling every time Judaism spreads to or disappears from a city (combined with an OB check) to increment/decrement the output. The same is required when you open/close borders where you would need to add/subtract the total number of Jewish cities they have.
If your UP depends on a dynamically changing variable, you need to update the Palace yield every time this variable changes. What the precise triggers are depends on the effect. For example, for Empire State Building the initial gold output is set to city size when the wonder is built and then changed when the city shrinks/grows, every time using the right event handler in RFCEventHandlers.py.
In your case it would involve handling every time Judaism spreads to or disappears from a city (combined with an OB check) to increment/decrement the output. The same is required when you open/close borders where you would need to add/subtract the total number of Jewish cities they have.
Similar threads
