More GPs Module
- Thread starter Asterix Rage
- Start date
pineappledan
Deity
Artwork that isn't divisible by 4 on 1 or more sides looks like this to me:
I suspect that if 1 pixel was shaved off both sides of the image (968x720) it would work
I can't open it up in GIMP to crop the image; the layer doesn't appear when I try
Spoiler example :
I suspect that if 1 pixel was shaved off both sides of the image (968x720) it would work
I can't open it up in GIMP to crop the image; the layer doesn't appear when I try
Asterix Rage
Warlord
- Joined
- Jun 6, 2010
- Messages
- 1,585
I'm 100% sure that i've seen this pic (I like it) I've not so much time to work on it right now.
This graphic bug will be fixed next release. For sure. I'll use the conventional way I use to make WW splash pic.
I suspect also that EraType causes this moreGP doing almost nothing! Vanilla Civ ignore EraType or something.
This graphic bug will be fixed next release. For sure. I'll use the conventional way I use to make WW splash pic.
I suspect also that EraType causes this moreGP doing almost nothing! Vanilla Civ ignore EraType or something.
psparky
King
- Joined
- Feb 24, 2011
- Messages
- 623
Re A__110 - it looks just like the image posted above when viewed in WTV and is transparent for me in-game, so I believe that making the sizes multiples of 4 will fix both problems 
It looks fine and I can manipulate it in GIMP (I'm running a fairly recent version 2.10.20)
Regarding era, the choice of great person runs in up to three passes. In the first pass it will accept any person from the current or an earlier era, so in a standard game, it will tend to pick the earlier era ones much of the time. And yes, looking at the code, I think in vanilla it is a completely random choice. As I said before, I tweaked my game so that in the first pass it picks from the current or later eras for GWAM and for exactly the current era for other types - just so I can see the new stuff!
However, for people playing with lots of civs, MoreGP should be fulfilling its primary objective of meaning the great works don't run out.
It looks fine and I can manipulate it in GIMP (I'm running a fairly recent version 2.10.20)
Regarding era, the choice of great person runs in up to three passes. In the first pass it will accept any person from the current or an earlier era, so in a standard game, it will tend to pick the earlier era ones much of the time. And yes, looking at the code, I think in vanilla it is a completely random choice. As I said before, I tweaked my game so that in the first pass it picks from the current or later eras for GWAM and for exactly the current era for other types - just so I can see the new stuff!
However, for people playing with lots of civs, MoreGP should be fulfilling its primary objective of meaning the great works don't run out.
I posted this in Github about problems with Unique_UniqueNames
https://github.com/LoneGazebo/Community-Patch-DLL/issues/7344
Maybe the same problem? But I don't have any answers at the moment.
psparky
King
- Joined
- Feb 24, 2011
- Messages
- 623
I may have stumbled on the reason. I found Gregor Mendel is in both vanilla and MoreGP. Since the game uses the names to determine if a GP is available, once one of them has been born the game will think they both have.
Looking now I also see two Alan Turing and two Dmitry Mendeleev (vanilla spelling) but the spelling is different on that one.
Perhaps there are more duplicates. I think it could also include cases where the same name is used for two kinds of GP e.g. Scientist and Engineer as there is only one list of names of born GPs.
BTW, will there be more Great Diplomats in V2? They seem to run out in a standard game. Also, the audio for great works of writing works fine for me but is a bit quiet compared to the vanilla ones.
Asterix Rage
Warlord
- Joined
- Jun 6, 2010
- Messages
- 1,585
I had a doubt about Turing. Thx
Current version is V2.
Great Diplomats? Why not.
But to be honest, MoreGP doesn't work (at all)
In my last test game, I was the first in ERA_FUTURE with not any GW and GA available!
I'm testing a sql without EraType.
I'm also wondering if there is a number max limit of GPs in the dbase. Does someone is able to investigate about that?
Before MoreGP, I made for my personnal use, a small mod with only ~20 GAs (The most boring when missing IMO). Without EraType. The new GAs was coming up after the last vanilla available. All was fine.
psparky
King
- Joined
- Feb 24, 2011
- Messages
- 623
Perhaps it would be helpful if I explain the mechanism that chooses which great person to use.
There are up to three phases. In each phase, it builds a list of eligible GPs and then picks at random from that list.
In phase one, GPs from the player's current era or any earlier era are eligible.
In phase two, GPs from the next era after the player's current era are eligible.
In phase three, any remaining GPs are eligible. This would include those with no set era and from even later eras.
For GWAM, all great people have an era set and all three phases potentially apply. For Great Diplomats, none have an era set, so phase 3 random picks always applies. For the other types, there is a mix or no era and set era, the latter being the ones added by MoreGP. For those types, all the new GPs added by MoreGP will get picked first, with the original GPs only getting picked if there are none left of the relevant eras.
So the behavior you are seeing makes sense to me. When you reached ERA_FUTURE, all the GW and GA had already been picked, either in the previous era with a phase 2 pick or as a random phase 3 pick in an earlier era when all the preferred ones had already been picked.
The behavior of your personal mod also makes sense; Artists would now be picked like the others kind with a mix of set era and no era, so the no era ones would tend to get picked last.
Note that the era assigned to a great work depends on the era when it is created, not the era set in the sql. Are you sure you didn't see any future-era works in earlier eras?
I think the reason you didn't see any once you reached ERA_FUTURE is simply because they had all been used already. How many civs were in the game? There are now 105 great works of writing so they could still easily run out if you have a lot of civs.
We need EvenMoreGP!
There are up to three phases. In each phase, it builds a list of eligible GPs and then picks at random from that list.
In phase one, GPs from the player's current era or any earlier era are eligible.
In phase two, GPs from the next era after the player's current era are eligible.
In phase three, any remaining GPs are eligible. This would include those with no set era and from even later eras.
For GWAM, all great people have an era set and all three phases potentially apply. For Great Diplomats, none have an era set, so phase 3 random picks always applies. For the other types, there is a mix or no era and set era, the latter being the ones added by MoreGP. For those types, all the new GPs added by MoreGP will get picked first, with the original GPs only getting picked if there are none left of the relevant eras.
So the behavior you are seeing makes sense to me. When you reached ERA_FUTURE, all the GW and GA had already been picked, either in the previous era with a phase 2 pick or as a random phase 3 pick in an earlier era when all the preferred ones had already been picked.
The behavior of your personal mod also makes sense; Artists would now be picked like the others kind with a mix of set era and no era, so the no era ones would tend to get picked last.
Note that the era assigned to a great work depends on the era when it is created, not the era set in the sql. Are you sure you didn't see any future-era works in earlier eras?
I think the reason you didn't see any once you reached ERA_FUTURE is simply because they had all been used already. How many civs were in the game? There are now 105 great works of writing so they could still easily run out if you have a lot of civs.
We need EvenMoreGP!
psparky
King
- Joined
- Feb 24, 2011
- Messages
- 623
I made a spreadsheet (csv) of all the great people that the game can see - this was made by adding logging to the game - and it looks like all from MoreGP are present to me. If you sort the list alphabetically you can see there are maybe 10-15 duplicates, sometimes with different spellings. It should also be a useful reference when choosing names for v3.
I've also been logging the process by which names are chosen and it seems to be operating perfectly so far.
Personally, my main interest in this module is to add diversity and variety to great people, especially GWAM. In my games (8 or 10 civs) I don't run out of great works. I have run out of other kinds of GP before but, hopefully, the extra names added in v2 will eliminate that (except for diplomats of course).
I think the only way to really solve the problem for games with lots of civs, where the generic GWAM can't create a great work, is to introduce generic great works. This would require a dll change and my impression is that the developers are reluctant to do the necessary work.
Failing that, I think a massive number of extra GWAMs will be needed. One possibility would be to add many autogenerated great people and great works, all referencing the same data file. So, for example, "Great Artist 1" creates "Painting 1" and so on, but all access the same art file "Great Painting.dds". This could, perhaps, be a separate mod "GenericGW", so only people who experience problems would need to load it.
I've also been logging the process by which names are chosen and it seems to be operating perfectly so far.
Personally, my main interest in this module is to add diversity and variety to great people, especially GWAM. In my games (8 or 10 civs) I don't run out of great works. I have run out of other kinds of GP before but, hopefully, the extra names added in v2 will eliminate that (except for diplomats of course).
I think the only way to really solve the problem for games with lots of civs, where the generic GWAM can't create a great work, is to introduce generic great works. This would require a dll change and my impression is that the developers are reluctant to do the necessary work.
Failing that, I think a massive number of extra GWAMs will be needed. One possibility would be to add many autogenerated great people and great works, all referencing the same data file. So, for example, "Great Artist 1" creates "Painting 1" and so on, but all access the same art file "Great Painting.dds". This could, perhaps, be a separate mod "GenericGW", so only people who experience problems would need to load it.
Asterix Rage
Warlord
- Joined
- Jun 6, 2010
- Messages
- 1,585
Yes, very very helpful.
How do you do that? I don't have those "great people that the game can see" in my log files.
Many thanks
psparky
King
- Joined
- Feb 24, 2011
- Messages
- 623
Total hack. Added some code to create the log file and log each name considered when a GP is born, rebuilt the dll (my old version), then created one GP of each type using IGE to trigger the logging. I've kept the code around as comments in case it's useful again one day.
Of course, you can see all the database entries using SQLiteSpy, but it's not easy to see duplicates or the names already used when adding new ones.
Asterix Rage
Warlord
- Joined
- Jun 6, 2010
- Messages
- 1,585
It will. Before the v.3 release, I'll send you the modul and you'll send me the log. OK with that?
I'm on this v.3 currently. It's a big work (DDS Re-encoding, All quotes re-balance and a lot more GPs of all kinds)
If someone want and can make a list of Great Diplomates, it will help a lot...
(Must be really great and multinational. Focus on industrial, modern and post-modern era) >> Format: Diplomate names . Date of birth
pineappledan
Deity
pineappledan
Deity
ideas for more great diplomats:
Johann Rudolf Wettstein (Swiss Mayor of Basel who showed up to the Wesphalian peace negotiations uninvited and unaccredited, and successfully negotiate Switzerland's independence at the conference)
Pope Leo I (The pope that met with Attila and negotiated for him to stop his invasion of Italy)
Ibrahim Pasha (Grand Vizier of the Ottoman Empire under Suleiman the Magnificent. Negotiated an alliance between the Ottomans and France against Spain, and negotiated for Hungary to become a vassal of the Ottomans without a war)
Jose Maria da Silva Paranhos (Diplomat for Brazil to Germany, Foreign Affairs Minister for both the empire and nation of Brazil. Negotiated the modern borders of Brazil with Paraguay, French Guiana, Argentina, and Bolivia. It can be argued that his successful diplomacy gave Brazil complete control of the entire Amazonian basin, and he gained entire provinces of land for Brazil in exchange for relatively minor concessions)
Moshoeshoe I (founder of Lesotho. Through tactics, intelligence, negotiation and persuasion, he forged alliances with many smaller African and refugees from the destabilization caused by the growth of the expanding Zulu empire. He created the kingdom of Lesotho, resisting the expansion of Afrikaaners, and his kingdom survives to this day. The prototypical pan-Africanist)
Jigonhsasee (Along with Hiawatha and the Great Peacemaker, created the Great Law of Peace which brought together the 5 nations to form the Haudenosaunee (Iroquois))
Kamehameha III (modernized the constitution and, through diplomatic means, ensured the survival of the kingdom of Hawai'i from various imperial interests)
Kosa Pan (The second Envoy sent from Siam to France. Established the Siamese embassy in France, had audiences with the Pope and Louis XIV. solidified French-Siamese alliance)
Johann Rudolf Wettstein (Swiss Mayor of Basel who showed up to the Wesphalian peace negotiations uninvited and unaccredited, and successfully negotiate Switzerland's independence at the conference)
Pope Leo I (The pope that met with Attila and negotiated for him to stop his invasion of Italy)
Ibrahim Pasha (Grand Vizier of the Ottoman Empire under Suleiman the Magnificent. Negotiated an alliance between the Ottomans and France against Spain, and negotiated for Hungary to become a vassal of the Ottomans without a war)
Jose Maria da Silva Paranhos (Diplomat for Brazil to Germany, Foreign Affairs Minister for both the empire and nation of Brazil. Negotiated the modern borders of Brazil with Paraguay, French Guiana, Argentina, and Bolivia. It can be argued that his successful diplomacy gave Brazil complete control of the entire Amazonian basin, and he gained entire provinces of land for Brazil in exchange for relatively minor concessions)
Moshoeshoe I (founder of Lesotho. Through tactics, intelligence, negotiation and persuasion, he forged alliances with many smaller African and refugees from the destabilization caused by the growth of the expanding Zulu empire. He created the kingdom of Lesotho, resisting the expansion of Afrikaaners, and his kingdom survives to this day. The prototypical pan-Africanist)
Jigonhsasee (Along with Hiawatha and the Great Peacemaker, created the Great Law of Peace which brought together the 5 nations to form the Haudenosaunee (Iroquois))
Kamehameha III (modernized the constitution and, through diplomatic means, ensured the survival of the kingdom of Hawai'i from various imperial interests)
Kosa Pan (The second Envoy sent from Siam to France. Established the Siamese embassy in France, had audiences with the Pope and Louis XIV. solidified French-Siamese alliance)
Last edited:
psparky
King
- Joined
- Feb 24, 2011
- Messages
- 623
That should be fine.
Asterix Rage
Warlord
- Joined
- Jun 6, 2010
- Messages
- 1,585
That's a good and quick start. Thx
@All VPfanatics :Tell me what GPs you want to see in VP (Artists, Musicians, Generals, Admirals, Merchants, Engineers, Scientists and mostly Diplomates)
Format: GP type . GP name . Date of birth
Must be really great and multinational. Focus on industrial (1840+), modern and post-modern era please.
pineappledan
Deity
Fritigern for GGeneral. Defeated the Romans at the battle of adrianople in 378. Wiped the Romans out, killed emperor Valens, made the Goths the de facto power in the balkans for the next 30 years
Asterix Rage
Warlord
- Joined
- Jun 6, 2010
- Messages
- 1,585
Last edited:
pineappledan
Deity
unknown. He was a chieftain of the Thervingi Goths leading a refugee group fleeing the Hunnic invasions in 376, so I would guess he was in his early-mid 30s. so c. 340?
Hinin
Agnostophile
For practical purposes, I made lists of all the GP added by the module. Of course, that's spoiler territory for those who want to discover them, but it's better to have this in order to not propose a GP that is already added.
Note : It appears there is a typo in the sql : The Temprtations => The Temptations
Note : You can simply put François Cheng without his Chinese chosen name. He was mostly famous with his French one.
Note : Typo for Toussain LOuverture + Vauban isn't present
Note : Ibn Khaldun wasn't a merchant (even though he traveled a bit). He was a scholar mostly known for example as the father of historiography (I will add him as a Great Writer)
Spoiler Great Musicians :
Note : It appears there is a typo in the sql : The Temprtations => The Temptations
Spoiler Great Artists :
Spoiler Great Writers :
Note : You can simply put François Cheng without his Chinese chosen name. He was mostly famous with his French one.
Spoiler Great Generals :
Note : Typo for Toussain LOuverture + Vauban isn't present
Spoiler Great Admirals :
Spoiler Great Merchants :
Note : Ibn Khaldun wasn't a merchant (even though he traveled a bit). He was a scholar mostly known for example as the father of historiography (I will add him as a Great Writer)
Spoiler Great Engineers :
Spoiler Great Scientists :
Last edited:
