Natural wonders development thread

[j_mie6]

they have spawning codes on gamestart

I should be able to do a pedia page for it at a later date, I like working with the Pedia, hopefully it will be pretty easy.

The thing that was missing isn't missing as such but if you read back though the past few pages dacubz wanted the cultural bonuses to be changed to money bonuses.

 

[Voyhkah]

Well, when I start a game in the mod, they don't spawn.

 

[Dancing Hoskuld]

Well, when I start a game in the mod, they don't spawn.

I am getting the following python error which is probably stopping the spawn.

Traceback (most recent call last):

  File "CvEventInterface", line 23, in onEvent

  File "CvEventManager", line 199, in handleEvent

  File "CvEventManager", line 345, in onGameStart

  File "CvEventManager", line 36, in doNaturalWondersConstantsInit

NameError: global name 'Game' is not defined
ERR: Python function onEvent failed, module CvEventInterface

Two lines down Game is defined.

Edit moving the definition line just leads to different errors.

 

[j_mie6]

I'll take a look

edit:

the global Game must be defined first.

anyway that error is impossible.....

def doNaturalWondersConstantsInit():
        iBaseCulture = 500 #amount of culture given to a city with natural wonder in radius (affected by gamespeed!)
        iDiscoveryCulturePercentage = 20 #percentage of culture gained when wonder discovered: if 20 and city has 200 culture it will become 240
        global iCulture
        global iGold
        global Game
        global fCultureModifier
        Game = CyGame()
        iModifier = gc.getGameSpeedInfo(Game.getGameSpeedType()).getUnitGreatWorkPercent()
        fCultureModifier = 100/float(iDiscoveryCulturePercentage)
        iCulture = iBaseCulture * iModifier /100
        iGold = 400 #Gold given to player for ownership

this should be the code. If this is what you guys have then I have no clue how...

 

[platyping]

1) Game undefined fixed
2) fCultureModifier typo fixed
3) bNotRevealed always false fixed
4) Missing Text messages TXT_KEY_WONDERDISCOVERED_YOU and TXT_KEY_WONDERDISCOVERED_ELSE added

Notes:
1) This is still the giving disgusting culture and gold version
2) Since no additional codes added, TXT_KEY_WONDERDISCOVERED_ELSE will inform you XXX has been discovered by certain leader, even if you have not met that leader
3) All others which I mentioned before

 

[j_mie6]

how was Game undefined then?

 

[platyping]

#Natural Wonders Contants
def doNaturalWondersConstantsInit():
        iBaseCulture = 500 #amount of culture given to a city with natural wonder in radius (affected by gamespeed!)
        iDiscoveryCulturePercentage = 20 #percentage of culture gained when wonder discovered: if 20 and city has 200 culture it will become 240
        global iCulture
        global iGold
        global Game
        global fCultureModifier
        iModifier = gc.getGameSpeedInfo([B][COLOR="Red"]Game.getGameSpeedType()[/COLOR][/B]).getUnitGreatWorkPercent()
        fCultureModifier = 100/float(iDiscoveryCulturePercentage)
        [B][COLOR="red"]Game = CyGame()[/COLOR]	[/B]
        iCulture = iBaseCulture * iModifier /100
        iGold = 400 #Gold given to player for ownership

 

[j_mie6]

I had that fixed in my version... I have a more recent version sitting around. oops. Should I upload my version?

 

[platyping]

Up to you lol, this is your project, not mine.
I am just loithering around

 

[j_mie6]

and thank god for your loitering

 

[dacubz145]

Not sure what all the errors are Here is my version of the mod, works fine without error and has 7 wonders in it. Took out art though since cant upload it with art, to big

 

[j_mie6]

thats because you had my version that doesn't have errors. They were errors I fixed before giving it to you, but then I uploaded the unfixed version

 

[thadian]

I would like this for RFC, what do i need to do to port this in?

 

[j_mie6]

you will need to merge in the code. the python will be quite easy to merge but then you need somebody to merge in my SDK code into rhyes DLL also

 

[Voyhkah]

Again, this seems to have stopped.

 

[dacubz145]

My understanding was you were helping jamie with the python codes

 

[j_mie6]

Same

I would have been working but I thought you were gonna finish it up (and I have been working on my 2000 line program for the strategy forum I just got a process down from taking 25 ms to 1 ms optimization ftw )

in any case, use dacubz posted version (thats my latest code) the last thing we need coded is the happiness instead of culture If you don't want to do it I will do it within the week.

 

[Voyhkah]

I'm not sure I have the latest version.

 

[dacubz145]

i posted it a bit ago (post 291)

 

[Voyhkah]

So, clarify. What is wanted?