[R&F] New Governor doesnt have any promotions

[Naeshar]

Hi guys, I have this issue I couldnt find on the forums: My governor mod shows the governor among others and can be chosen, but doesnt have any of the promotions.

I have simply copied much of the RnF code and created promotions with effects of my own, and adjusted the icons as well, to create a new governor type.
Maybe it just needs a skilled eye or another view. Can you help any?

Full code attached.

 

[Arstahd]

Have you tried adding one of your new promotions to an existing governor, or adding an existing promotion to your new governor? It might help you narrow down where your problem is.

 

[criZp]

Change the code like this:

<GlobalParameters>
<Update>
<Where Name="MAX_GOVERNOR_APPOINTMENTS"/>
<Set Value="8"/>
</Update>
</GlobalParameters>

Then you get some other errors that you can check in database.log, which you find in documents/mygames/civilizationVI/logs

 

[Naeshar]

Change the code like this:

<GlobalParameters>
<Update>
<Where Name="MAX_GOVERNOR_APPOINTMENTS"/>
<Set Value="8"/>
</Update>
</GlobalParameters>

Then you get some other errors that you can check in database.log, which you find in documents/mygames/civilizationVI/logs

I believe this is in the code already, and doesn't change much. I suppose this allows me to appoint up to 8 governors instead of the usual 7, which is on the point, but doesn't cause any errors.
I will try adjusting existing promotions or add these to the new one.

Something must be missing.

 

[criZp]

It's not in your code, your formatting was wrong and the way I wrote it fixed the issue

 

[Naeshar]

<GlobalParameters>
<Update>
<Where>Name="MAX_GOVERNOR_APPOINTMENTS"</Where>
<Set>
Value="8"
</Set>
</Update>
</GlobalParameters>

vs

<GlobalParameters>
<Update>
<Where Name="MAX_GOVERNOR_APPOINTMENTS"/>
<Set Value="8"/>
</Update>
</GlobalParameters>

I dont see a difference.
Anyway now I am getting the same error as previously with other attempts, the mods prevent the game from creating. They generate an error, possible because of new civ version, but one can not be sure...

 

[Gedemon]

that:

<Where>Name="MAX_GOVERNOR_APPOINTMENTS"</Where>
<Set>
Value="8"
</Set>

is a wrong syntax, the program does see a difference.

use

<Where Name="MAX_GOVERNOR_APPOINTMENTS"/>

or

<Where>
   <Name>MAX_GOVERNOR_APPOINTMENTS</Name>
</Where>

 

[Naeshar]

Alright, many thanks to all involved, esp. @criZp .

I have replaced the Where-Set syntax with <Replace>, as all other GlobalParameters are created like that. There was an issue in the logs, saying <Set> needs an argument in the correct syntax variation. GlobalParameters are a special table...
<GlobalParameters>
<Replace Name="MAX_GOVERNOR_APPOINTMENTS" Value="8" />
</GlobalParameters>

Anyway there were other errors from my side in the modifiers (the sub-modifier wasnt declared first) and the custom dynamic modifier didnt work at all.

But now the issue is solved and mod is kind of working. Of course it needs refining. And texts, and possibly a pictures/icons.