Platy's Peculiar Pleasant Posh Python

[isenchine]

I think there is a problem with your inclusion of BtS files.

In Charlemagne, I deleted the ART_DEF for Barracks, Trebuchet and Chilperic. If the checking of BtS is True, only Chilperic appears as missing art def because both barracks and trebuchets are in BtS. Still, the game will crash because the art def files of BtS are not read when there are art def files in a mod.

If I set it to False, then lots of Bonuses, Improvements, etc appear in the list + correctly Barracks, Trebuchet and Chilperic (EDIT - ADDED: because the mod has changed B&I but does not include a new art def file for them).

EDITED OUT unclear sentence.

I guess it's OK with False and skip manually Bonuses, Improvements if you have not added an art def file in your mod. Ideally, the code should be able to sort it out by itself without True or False, but we don't leave in an ideal world (or do we?)

 

[keldath]

ye ofc.
i love u both

you guys could develop this part even more, plenty of ideas.

i only wish i had this mod part 5 years ago would have saved me some head aches

 

[platyping]

Art Define Checker
Fix some issues with BTS files.

 

[isenchine]

Hmmm... I see only Chilperic as missing.

 

[platyping]

And Fixed again.

 

[isenchine]

Much better, now I see Chilperic, barracks and trebuchets!

Thank you.

 

[hrochland]

Hey . I managed to merge new goldenfaith with my mod and add developingtraits well.
I had a little trouble adding a button. This is my solution :

## Developing Traits ##
		iBtnX += iBtnAdvance
		screen.setImageButton("DevelopingTraitsButton", "Art/Traits.dds", iBtnX + 164, iBtnY - 0, iBtnWidth, iBtnWidth, WidgetTypes.WIDGET_PYTHON, 4242, 8)
		screen.hide("DevelopingTraitsButton")
## Developing Traits ##

Then there is a problem with faith . I will choose a religion first turn after is on the bar value 0 + 0
The next round is the value 25 + 0 ( see picture)
The next round is value 50 + 0
I do not know if the error is in my merge or in the new version .

In any case, thank you for your time and work. )

 

[platyping]

Of course it is in your merge.
I already stated effort is still needed to merge.
It is not simply c&p

 

[platyping]

Art Define Checker

1) Added a section below to indicate files checked.

 

[isenchine]

Art Define Checker

1) Added a section below to indicate files checked.

Not yet uploaded?

 

[platyping]

Done.

 

[isenchine]

Thanks.

If I trust the report, the modules files (see below) are not taken into consideration:

Spoiler :

class ArtDefChecker:
	def __init__(self):
		self.lModArt = 	["Mods/Platy UI/Assets/Modules/Gigapack/Gigapack_",
				"Mods/WWIIDecember1941/Assets/Modules/Units/XML/Air/",
				"Mods/WWIIDecember1941/Assets/Modules/Units/XML/Land/",
				"Mods/WWIIDecember1941/Assets/Modules/Units/XML/Sea/",
				"Mods/WWIIDecember1941/Assets/XML/Art/",
				]

		self.lModItems = ["Mods/Platy UI/Assets/Modules/Gigapack/Gigapack_",
				"Mods/WWIIDecember1941/Assets/Modules/Units/XML/Air/",
				"Mods/WWIIDecember1941/Assets/Modules/Units/XML/Land/",
				"Mods/WWIIDecember1941/Assets/Modules/Units/XML/Sea/",
				"Mods/WWIIDecember1941/Assets/XML/Buildings/",
				"Mods/WWIIDecember1941/Assets/XML/Civilizations/",
				"Mods/WWIIDecember1941/Assets/XML/Terrain/",
				"Mods/WWIIDecember1941/Assets/XML/Units/",
				]

What do you think?

PS: I took the spaces out in the mod's name to run CivChecker.

 

[platyping]

Generally, modular files are not CIV4ArtDefines_Movie or CIV4ArtDefines_Interface, but rather something like UltraPack_CIV4ArtDefines_Interface and UltraPack_CIV4ArtDefines_Movie.

If you look above at how I typed for Gigapack, modular files added should end with a "_" rather than a "/"

 

[isenchine]

Yeah I know but this mod is not like any other...

 

[platyping]

Then, that is not my problem

Anyway, if there is a space name, then it should be included, see Platy UI.

 

[isenchine]

Yes, but davidlallen's CivChecker does not work with spaces, that's why I took them out of from the mod's name and of course from this python file.

Also I think that there are two kind of modules, the regular ones and the ones who have special instructions in them, like CIV4ModularLoadingControlsSchema.xml and MLF_CIV4ModularLoadingControls.xml files (WoC format).

 

[platyping]

Either way, so long as the filepath is correct, it will be able to load the file, so long as it is one of the files it is supposed to check, such as CIV4ArtDefines_Movie.xml

P.S.
You sure Units come before XML in the filepath?

 

[hrochland]

Me found no where did I go wrong . Any idea please , described by error , where should I look ? Many times you determine the location of the error according to the nature of speech

 

[isenchine]

Either way, so long as the filepath is correct, it will be able to load the file, so long as it is one of the files it is supposed to check, such as CIV4ArtDefines_Movie.xml

P.S.
You sure Units come before XML in the filepath?

Saw your P.S. now: yes, I'm sure. The problem is that every file in these 3 folders have different names like 1st_Gen_CIV4ArtDefines_Unit.xml coupled with 1st_Gen_CIV4UnitInfos.xml, then 2nd_Gen... etc.

 

[platyping]

Ultrapack

Fix a bug with Tech Button selection when using Choose Religions, CvMainInterface

@Isenchine
Then if you want to load 1st_Gen_CIV4ArtDefines_Unit.xml, the input should be folder/1st_Gen_ rather than just the folder.