Promotions DLL

[TheLadiesOgre]

cannot compile a debug dll:

1>CvUnit.cpp(10664) : error C2296: '>=' : illegal, left operand has type 'int (__thiscall CvUnit::* )(void) const'
1>CvUnit.cpp(10664) : error C2297: '>=' : illegal, right operand has type 'int (__thiscall CvUnit::* )(void) const'
1>NMAKE : fatal error U1077: '"C:\Programme\Microsoft Visual C++ Toolkit 2003/bin/cl.exe"' : return code '0x2'

Spoiler :

void CvUnit::changeVictoryAdjacentTileHeal(int iChange)
{
	m_iVictoryAdjacentTileHeal += iChange;
	FAssert(getVictoryAdjacentTileHeal >= 0);
}

Not quite sure what to do about that, I've haven't made a debug dll before, let me take a look at it, I'll post in a little

 

[xienwolf]

You just need ()

 

[Cybah]

where?

 

[TheLadiesOgre]

I would assume right after getVictoryAdjacentTileHeal() <----- like that

 

[TheLadiesOgre]

Hey, I was just working on some <TEXT> stuff for the next version and realized I was going to need volunteers to translate the text into the non-english languages. Any assistance would be greatly appreciated. Either post here or PM me, though it may be a couple of weeks before I get the next version out as I want to make the remainder of the changes that I had in mind for PromotionInfos.xml (mostly all new-to-BtS tags and functionality at least AFAIK and some ports from UnitInfos) before releasing.

 

[Cybah]

I can do the German translations.

 

[TheLadiesOgre]

Thank you cybah, german covered, three left to go.

 

[Castor_Troy]

Im not french but i used to know french quite well i can give it a try with a online dictionary and such if you want and there isnt anyone better who can

 

[mechaerik]

Perhaps you could update and merge this?
http://forums.civfanatics.com/showthread.php?t=247180

 

[TheLadiesOgre]

Perhaps you could update and merge this?
http://forums.civfanatics.com/showthread.php?t=247180

Sure, the DL link is dead, but it shouldn't be hard just to implement those four tags.

 

[TheLadiesOgre]

Alright, so what should I do with Culture? I'm deciding on how a few promotions will work and I'm at a loss for what I should do with culture. I've added <PillageCommerceChange>, which (if all goes according to plan) will look something like this in the XML

Spoiler :

<PillageCommerceChanges>
  <PillageCommerceChange>
    <CommerceType>COMMERCE_CULTURE</CommerceType>
    <iCommerce>??</iCommerce>
  </PillageCommerceChange>
  <PillageCommerceChange>
    <CommerceType>COMMERCE_ESPIONAGE</CommerceType>
    <iCommerce>??</iCommerce>
  </PillageCommerceChange>
  <PillageCommerceChange>
    <CommerceType>COMMERCE_GOLD</CommerceType>
    <iCommerce>??</iCommerce>
  </PillageCommerceChange>
  <PillageCommerceChange>
    <CommerceType>COMMERCE_RESEARCH</CommerceType>
    <iCommerce>??</iCommerce>
  </PillageCommerceChange>
</PillageCommerceChanges>

Now, I'm doing it this way to get the *, **, *** effect. I'm figuring that * will allow you to gain this commerce in addition to the gold you normally get from pillaging (Marauder * will end up being more of a "double pillage" effect, twice the gold, twice the improvement loss). After that, ** will be where <bPillageOnMove> is turned on and then finally *** will be where <bPillageOnCombatVictory> is turned on (though it will be less of a pillage and more of a mugging as there will be no improvement loss). This is how I am converting The_J's/Tsentom1's Industry Espionage, Marauder and Sneak promotions to the DLL (and keep in mind everything will be editable in the XML so if you just want it to be one promotion for each with all three effects you'll be able to do that in the XML, hell if you want it to be one promotion that give you all three effects for every CommerceType you could do that too.... it'd be ridiculously overpowered though). However, this brings me to my problem, I cannot think of a reasonably justified way that culture could be pillaged (research could be stolen research documents, espionage could be state-secrets or classified documents, gold just means you rob people/places a little more throughly), which leads me to hesitate to add code to make a culture pillage actually work, so I guess what I am asking is: What is your opinion? Do I:

1) Have a culture pillage possibly in the XML but yet non-functioning or;
2) Include the code to allow culture pillage despite the fact it makes absolutely no sense

Edit: thinking about has also made me question whether I should change it from an integer array to a boolean array

 

[xienwolf]

Robin Hood was totally a Culture Pillager. Otherwise you can think slander campaign or other such propaganda pushes. Though having them happen in a battle is a tad weird, you can think of it as spreading false claims AFTER the battle (the winner writes history). If everyone thinks you only killed the town guards because they were attacking a helpless one-eyed beggar in a wheelchair with crutches and a blind dog, they might ignore the fact that he is bound up hand and foot with his skin in a neatly stacked pile of perfectly 1 inch by 1 inch squares next to him, while you are giving this rousing speech between bites of his liver (with no old man in sight, let alone his 2 legged dog)


You can run it as just a standard commerce array:

<PillageCommerces>
    <iCommerce>0</iCommerce>
    <iCommerce>0</iCommerce>
    <iCommerce>0</iCommerce>
    <iCommerce>0</iCommerce>
</PillageCommerces>

And specify as the integer precisely how MUCH of that type of commerce you get on pillage. More annoying to remember which Commerce goes in which slot, but easier to write the XML loading method since a function exists to do so automatically for you.

I would say that you ought to have a seperate array for each of the possible effects. So PillageCommerce, PostCombatCommerce, CommerceOnMove. Or whatever you intend the third to be, bPillageOnMove combined with PillageCommerces should attain that goal just fine, so potentially you only need 2 arrays.

You could also just have this integer be an indication of how to modify the base rate, and let the base rate be calculated by what you pillaged or what your opponent's stats were. Then you add this integer, or multiply by it (in which case you would probably use a percentage scale)

 

[TheLadiesOgre]

I have actually already started switching over to a boolean array with the thought that if it is toggled on, I'll hijack :illage so that when it spits out the iPillageGold that Python determines, it also applies that same number to whatever Commerce is toggled on, I was figuring that would be simpler, I don't know though

 

[The_J]

Stealing culture: I suggest, that you take as basis the total culture from the next city.
I would spread the stolen culture over all your cities. Or maybe you can add a popup, which lets you choose the city...both is not really satisfying...i have no better idea.

 

[xienwolf]

I figured it would run like influence driven war modcomp. You convert some culture in the current tile to sway who owns it.

 

[TheLadiesOgre]

I didn't even think of applying it like IDW, I was thinking that I would apply it to the capital, but now I'm going to have to take a look at the IDW code.

 

[Duque d'Caxias]

Please, please, please, could you add Tsentom's Survival Promotion. I've tried to merge this python promotion but it seems it is not entirely compatible with Dale&#8217;s Combat Mod (or another mod I&#8217;m using).

 

[TheLadiesOgre]

I was planning on it, I'm just trying to get a few things worked out, I want to add all of the promotions that will be added before I release the next version. I'm also going to doublecheck everything that I've done up to now.

 

[Duque d'Caxias]

This is nice! I can't wait to use it.

 

[Opera]

Did you make any progress with your PillageOnMove tag? I still didn't look at it further yet. At first sight it seemed decent. So I'm not sure what is wrong.