Quick Modding Questions Thread

I know

Honestly part of the reason is that using VS2017 still feels like using a ten year old IDE so with VS2010 I'm at least emotionally prepared for things being so terrible.

 

More questions! I am currently trying to fix an issue with the espionage advisor that I originally got from History Rewritten:

Spoiler :

The issue is with the city selection list titled "known cities". You can click the individual rows and the row is highlighted (here with Saint-Louis du Sénegal) but the selected city isn't updated in the backend. This is indicated by the cyan coloured text highlighting, which should have updated from Port-au-Prince to Saint-Louis along with the selection.

Here's the code that populates the table:

Code:

       if self.iTargetPlayer > -1:
           pTargetPlayer = gc.getPlayer(self.iTargetPlayer)
           iEspionage = self.pActiveTeam.getEspionagePointsAgainstTeam(pTargetPlayer.getTeam())

           # City Table
           screen.addTableControlGFC("CityTable", 3, self.X_CITY_LIST, self.Y_CITY_LIST, self.W_CITY_LIST, self.H_CITY_LIST, True, False, 24, 24, TableStyles.TABLE_STYLE_STANDARD)
           screen.setTableColumnHeader("CityTable", 0, u"<font=2>Known Cities</font>", self.W_CITY_LIST - 102)
           screen.setTableColumnHeader("CityTable", 1, u"<font=2>Spies</font>", 50)
           screen.setTableColumnHeader("CityTable", 2, u"<font=2>Cost</font>", 50)
           screen.setStyle("CityTable", "Table_StandardCiv_Style")
           screen.enableSelect("CityTable", True)

           (loopCity, iter) = pTargetPlayer.firstCity(False)
           while(loopCity):
               if loopCity.isRevealed(self.iActiveTeam, False):
                   iRow = screen.appendTableRow("CityTable")

                   if self.iTargetCity == -1:
                       self.iTargetCity = loopCity.getID()

                   if self.iTargetCity == loopCity.getID():
                       screen.selectRow("CityTable", iRow, True)

                   # Status
                   if loopCity.isCapital():
                       szStatus = u"%c" % CyGame().getSymbolID(FontSymbols.STAR_CHAR)
                   elif loopCity.isGovernmentCenter():
                       szStatus = u"%c" % CyGame().getSymbolID(FontSymbols.SILVER_STAR_CHAR)
                   else:
                       szStatus = u"%c" % CyGame().getSymbolID(FontSymbols.BULLET_CHAR)

                   # Name
                   szName = loopCity.getName()
                   if self.iTargetCity == loopCity.getID():
                       szName = CyTranslator().changeTextColor(szName, gc.getInfoTypeForString('COLOR_HIGHLIGHT_TEXT'))

                   screen.setTableText("CityTable", 0, iRow, szStatus + szName, "", WidgetTypes.WIDGET_ESPIONAGE_SELECT_CITY, loopCity.getID(), 0, CvUtil.FONT_LEFT_JUSTIFY)

                   # Spies
                   if self.iTargetCity == loopCity.getID():
                       del self.CitySpies[:]

                   iNumSpies = 0
                   loopPlot = loopCity.plot()
                   for iUnit in xrange(loopPlot.getNumUnits()):
                       pUnit = loopPlot.getUnit(iUnit)
                       if not pUnit.isNone():
                           if pUnit.isCounterSpy() and pUnit.getOwner() == self.iActivePlayer:
                               iNumSpies += 1
                               if self.iTargetCity == loopCity.getID():
                                   self.CitySpies.append(pUnit)

                   if iNumSpies > 0:
                       screen.setTableInt("CityTable", 1, iRow, str(iNumSpies), "", WidgetTypes.WIDGET_ESPIONAGE_SELECT_CITY, loopCity.getID(), 0, CvUtil.FONT_RIGHT_JUSTIFY)

                   # Mission Cost
                   if self.iMission > -1:
                       iCost = self.pActivePlayer.getEspionageMissionCost(self.iMission, self.iTargetPlayer, loopPlot, -1)
                       if iCost > -1:
                           if iEspionage < iCost:
                               szCost = CyTranslator().changeTextColor(str(iCost), gc.getInfoTypeForString('COLOR_NEGATIVE_TEXT'))
                           else:
                               szCost = CyTranslator().changeTextColor(str(iCost), gc.getInfoTypeForString('COLOR_POSITIVE_TEXT'))

                           screen.setTableInt("CityTable", 2, iRow, szCost, "", WidgetTypes.WIDGET_ESPIONAGE_SELECT_CITY, loopCity.getID(), 0, CvUtil.FONT_RIGHT_JUSTIFY)

                   iRow += 1
               (loopCity, iter) = pTargetPlayer.nextCity(iter, False)

Here is the handleInput function:

Code:

    def handleInput(self, inputClass):
       print "handleInput: button type: %d, data 1: %d, widget_espionage_select_city: %d" % (inputClass.getButtonType(), inputClass.getData1(), WidgetTypes.WIDGET_ESPIONAGE_SELECT_CITY)
   
       screen = self.getScreen()
       if self.iTargetPlayer > -1:
           if inputClass.getButtonType() == WidgetTypes.WIDGET_ESPIONAGE_SELECT_PLAYER:
               screen.setState("LeaderIcon" + str(self.iTargetPlayer), False)
               self.iTargetPlayer = inputClass.getData1()
               screen.setState("LeaderIcon" + str(self.iTargetPlayer), True)
               self.iTargetCity = -1
               self.updateRightPanel()

           elif inputClass.getFunctionName().startswith("WeightIncrease"):
               self.changeEspionageWeight(inputClass.getData1() - 1, self.iIncrement)

           elif inputClass.getFunctionName().startswith("WeightDecrease"):
               self.changeEspionageWeight(inputClass.getData1() - 1, -self.iIncrement)

       if inputClass.getFunctionName() == "EspionagePlus" or inputClass.getFunctionName() == "EspionageMinus":
           iChange = inputClass.getData2()
           if CyInterface().shiftKey():
               if iChange > 0:
                   iChange = 100
               elif iChange < 0:
                   iChange = -100

           CyMessageControl().sendModNetMessage(lNetworkEvents['CHANGE_COMMERCE_PERCENT'],  self.iActivePlayer, inputClass.getData1(), iChange, -1)

       elif inputClass.getButtonType() == WidgetTypes.WIDGET_ESPIONAGE_SELECT_CITY:
           self.iTargetCity = inputClass.getData1()
           self.updateRightPanel()

       elif inputClass.getButtonType() == WidgetTypes.WIDGET_ESPIONAGE_SELECT_MISSION:
           iSelectedMission = inputClass.getData1()
           if self.iMission == iSelectedMission:
               self.iMission = -1
           else:
               self.iMission = iSelectedMission

           self.updateRightPanel()

       elif inputClass.getButtonType() == WidgetTypes.WIDGET_GO_TO_CITY:
           screen.hideScreen()
           pCity = gc.getPlayer(inputClass.getData1()).getCity(inputClass.getData2())
           CyCamera().JustLookAtPlot(pCity.plot())
           if len(self.CitySpies) > 0:
               pSelectedUnit = self.CitySpies[0]
               for pSpy in self.CitySpies:
                   if not pSpy.hasMoved():
                       pSelectedUnit = pSpy
                       break
               CyInterface().selectUnit(pSelectedUnit, True, True, False)

       elif inputClass.getButtonType() == WidgetTypes.WIDGET_ZOOM_CITY:
           screen.hideScreen()
           CyInterface().selectCity(gc.getPlayer(inputClass.getData1()).getCity(inputClass.getData2()), True)

       if inputClass.getFunctionName() == "WeightIncrementSelect":
           iIndex = screen.getSelectedPullDownID("WeightIncrementSelect")
           self.iIncrement = screen.getPullDownData("WeightIncrementSelect", iIndex)

       elif inputClass.getFunctionName() == "WeightResetButton":
           self.resetEspionageWeights()

       elif inputClass.getFunctionName() == "DebugPlayerSelect":
           iIndex = screen.getSelectedPullDownID("DebugPlayerSelect")
           self.iActivePlayer = screen.getPullDownData("DebugPlayerSelect", iIndex)
           self.iTargetPlayer = -1
           self.iTargetCity = -1
           self.updateLeftPanel()
           self.updateRightPanel()

       return 0

As you can see, I have logged the metadata passed to the function when something is clicked. However, when I click around in the table, this is what I get:

Code:

handleInput: button type: 0, data 1: 0, widget_espionage_select_city: 189

handleInput: button type: 0, data 1: 0, widget_espionage_select_city: 189

handleInput: button type: 0, data 1: 0, widget_espionage_select_city: 189

handleInput: button type: 0, data 1: 0, widget_espionage_select_city: 189

handleInput: button type: 0, data 1: 0, widget_espionage_select_city: 189

handleInput: button type: 0, data 1: 0, widget_espionage_select_city: 189

handleInput: button type: 0, data 1: 0, widget_espionage_select_city: 189

handleInput: button type: 0, data 1: 0, widget_espionage_select_city: 189

handleInput: button type: 0, data 1: 0, widget_espionage_select_city: 189

This suggests that no button type is associated with the rows in the table. However, in setTableText it is clearly set to WidgetTypes.WIDGET_ESPIONAGE_SELECT_CITY, so I'd expect that to be passed as the button type (and also, the data1 field should be set to a city ID, not 0). I included this much information because I am not sure what is going on, because from my understanding everything should work. Am I missing something? The same issue exists in History Rewritten too by the way.

 

That's interesting, maybe there is another mapping in the call chain that uses the hover text for some reason? I'll look into it more.

 

Yeah, that fixed it, thanks. But I would like to find a way that also gets rid of the empty tooltip.

 

Welcome to the forums! There is no easy way, but there is a hard(er) way depending on your knowledge. It is possible to edit the rules of how diplomatic agreements and territorial access rules work, but you need to be able to compile a new DLL and probably edit the source code in many places.

 

You don't just have to be able to edit the files, you also need to be able to compile them to create a new CvGameCoreDLL file, so it's necessary to start with that. I have a created a step by step guide for it here.

 

Another question around the AI of waking up units building improvements. The code above only affects human units, but aren't AI workers also canceling their improvement building when they are threatened by an enemy unit moving close to them? I've looked into CvUnitAI::AI_update() and it is only called if the unit is not currently performing a mission (including building), so I assume this has to be the case. But where does it happpen?

For a bit of context, I have given a combat unit the ability to build roads, but they are not woken up by nearby enemies, which I assume is because they can theoretically defend themselves. I would still like to wake them up because they should reconsider their purpose if enemies are nearby and start defending cities or attacking enemies.

 

Ah, nice. Thanks a lot!

 

You mean find text keys that aren't defined yet? I think event infos are exposed to Python, I suggest you go into the Python console and do something like (note: I didn't test this):

Code:

for i in range(gc.getNumEventInfos()): print gc.getEventInfo(i).getText()

And then see which undefined text keys are shown (EventInfo are the event options while EventTriggerInfos are the events themselves, in case you need both).

 

Are you sure? If you have logging enabled, the output should also show up in PythonDbg.log. Or something is different in C2C, it works in my mod at least.