ShadesOfTime
Chieftain
- Joined
- May 3, 2012
- Messages
- 31
Hi all!
I had less stress in my private life and job lately and I so I returned to RaR and fiexed the Imports-/Exports-Limits Bug. Just to notice that Nightinggale fixed it in july already ( https://sourceforge.net/p/religion-.../ci/c0ba2ba2ad09bb70d6cbe3a1bdb8714fe3212863/ ).
My next step would have been to push it to my fork on sourceforge and ask Nightinggale for a code review. Making the code review the other way around now, I can say ... @Nightinggale, my code almost looks exactly like yours. I even did the code cleanup like you (e.g. put all the checks for changed data in one line each) and had similar comments - also about nice and selfexplaining variable names. I guess I have similar views regarding coding and readability like you. This gives me confidence that I can contribute to the project.
And obviously this time I was able to install the dev-environment and compile the project, mostly thanks to @devolution's post here: https://forums.civfanatics.com/thre...ild-environment-for-rar.632502/#post-15138038
I had less stress in my private life and job lately and I so I returned to RaR and fiexed the Imports-/Exports-Limits Bug. Just to notice that Nightinggale fixed it in july already ( https://sourceforge.net/p/religion-.../ci/c0ba2ba2ad09bb70d6cbe3a1bdb8714fe3212863/ ).
My next step would have been to push it to my fork on sourceforge and ask Nightinggale for a code review. Making the code review the other way around now, I can say ... @Nightinggale, my code almost looks exactly like yours. I even did the code cleanup like you (e.g. put all the checks for changed data in one line each) and had similar comments - also about nice and selfexplaining variable names. I guess I have similar views regarding coding and readability like you. This gives me confidence that I can contribute to the project.
And obviously this time I was able to install the dev-environment and compile the project, mostly thanks to @devolution's post here: https://forums.civfanatics.com/thre...ild-environment-for-rar.632502/#post-15138038