Requesting following features

[Baldyr]

I'm afraid I don't understand. Do you have autosaves enabled? In that case you should be able to post one of those...

 

[j_mie6]

I didn't find the error It was TopSecret that found it and also make sure you download the current version in my thread just in case

 

[j_mie6]

doesn't matter I have it myself

this bug could also be because of a forest having been removed during the checking or change in territory as I think you fix fixed the unit death one... not sure... lets be more thorough this time

however it seems I can't upload for the mintue so I will get back to you

 

[j_mie6]

do you have it?

 

[j_mie6]

right, I checked the log and there it is: Greek valid catapult constructors: (884927088, -65210) (-2147483647, -2147483647) (-2147483647, -2147483647) (1166766952, 1166763784) (19, 36) (-2147483647, -2147483647)

so I have an idea... heres the code itself:

        def checkUnits(self):
                for pUnit, pPlot in list((pUnit, pUnit.plot()) for pUnit in self.iterateUnits()):
                        if pPlot.getFeatureType() == eForest:
                                if pPlot.isNone() or pUnit.isDead(): continue
                                if isEnemyTerritory(pUnit, pPlot, self.pCivPlayer.get(CyTeam)) or self.isUsed(pUnit): return
                                self.activateOverwatch(pUnit, pPlot)
                                break

I say that in the datastorage there should be very long tuple of tuples which consists of every coordinate possible... and then pPlot i schecked against these?

I made code for generating all plots:

x = 0
y = 0
VP = (x,y)
while VP <= (82, 51):
    VP = (x, y)
    if y == 51:
        x =+ 1
        y = 0
    else:
        y += 1

logical

anyway what do you think (you haven't spoken recently )

 

[Baldyr]

(884927088, -65210) (-2147483647, -2147483647) (-2147483647, -2147483647) (1166766952, 1166763784) (19, 36) (-2147483647, -2147483647)

These tuples are supposed to be map coordinates. The only valid one seems to be (19, 36) and I have no idea what those others are all about.

IIRC the actual exception is caused by this line:

if pPlot.getFeatureType() == eForest:

I would suggest that this line should appear before the former:

if pPlot.isNone() or pUnit.isDead(): continue

The code would look like this:

        def checkUnits(self):
                for pUnit, pPlot in list((pUnit, pUnit.plot()) for pUnit in self.iterateUnits()):
                        [B]if pPlot.isNone() or pUnit.isDead(): continue[/B]
                        if pPlot.getFeatureType() == eForest:
                                if isEnemyTerritory(pUnit, pPlot, self.pCivPlayer.get(CyTeam)) or self.isUsed(pUnit): return
                                self.activateOverwatch(pUnit, pPlot)
                                break

You could test it, while I scramble to get the time to test things myself.

I say that in the datastorage there should be very long tuple of tuples which consists of every coordinate possible... and then pPlot i schecked against these?

I don't think that the invalid plot coordinates are the problem - they are more likely just a symptom of invalid CyUnit and/or CyPlot entries.

 

[j_mie6]

ok
also what were the errors in my civic function posted ages ago?

 

[Baldyr]

You basically need to test your code and read the resulting errors. This is the default way of programming.

But the errors I could spot right away were:

def FreeCivic():
        bBasic = True
        pPlayer = gc.getPlayer(eRome)
                if [COLOR="Red"][B]B[/B][/COLOR]basic [COLOR="Red"][B]=[/B][/COLOR] True:
                        pCivic = gc.getInfoTypeForString('CIVIC_REPUBLIC')
                        if pPlayer.isCivic(pCivic):
                                pPlayer.setCivics(0, pCivic)
                                showPopup(senateHeader, freeCivicMessage)
                        else:
                                print "No usable civic for FreeCivic()"
                                
                else:
                        pass

Also, you could rename pCivic something else, like eCivic or iCivic. If this doesn't make sense to you I could explain why. The name doesn't affect performance however.

 

[j_mie6]

how did I not see those lol and how did I make the = one!?

 

[j_mie6]

Traceback (most recent call last):

File "CvEventInterface", line 23, in onEvent

File "CvEventManager", line 187, in handleEvent

File "CvEventManager", line 382, in onBeginGameTurn

File "CatapultConstruction", line 178, in process

RuntimeError: dictionary changed size during iteration
ERR: Python function onEvent failed, module CvEventInterface




whats this one on about

edit:

log from turn

PYlayer 0 Civilization Roman Empire Unit Advanced Archer was killed by Player 28
PYlayer 1 Civilization Greek Empire Unit Archer was killed by Player 0
PYlayer 1 Civilization Greek Empire Unit Galley was killed by Player 0
PY:City Acquired Event: Argos
PYlayer 1's alive status set to: 0
PY:City Acquired and Kept Event: Argos
PY:Rhodes has grown
this is grantExtraXP() calling!

this is grantExtraXP() calling!

PYlayer 28 Civilization Barbarian State Unit Archer was killed by Player 5
PYlayer 5 Civilization Egyptian Empire Unit Warrior was killed by Player 9
this is grantExtraXP() calling!

PY:Memphis has grown
this is grantExtraXP() calling!

PY:Alexandria has grown
PY:Giza has grown
PY:Scone has grown
PY:Corduba has grown
this is grantExtraXP() calling!

PY:Numantia has grown

*** Rebellion Debug ***
Active on Game Turn 149:
<Rebellion.MinorRevolt instance at 0x0EF2CDC8> (city: Thebes, starting turn: 89)
<Rebellion.Resistance instance at 0x0EF2CEB8> (city: Tarsa, starting turn: 145)
***

Greek valid catapult constructors:

 

[Baldyr]

I'm not sure about versions of files anymore - could you attach your copy of CatapultConstruction.py?

 

[j_mie6]

ok, however I am away from home so I will have to send you the release version one (after downloading it here, how useful) and make the edits I did last night...

called do not move to stop people moving it

 

[Baldyr]

Without testing anything out, this should amend my mistake causing the exception:

def process():
        if not CatapultOverwatch.bEnabled: return
        [B]lDeletePlayers = list()[/B]
        for ePlayer, pCatapultOverwatch in overwatchDict.iteritems():
                debug(ePlayer, pCatapultOverwatch)
                if not pCatapultOverwatch.pCivPlayer.isAlive():
                        [B]lDeletePlayers.append(ePlayer)[/B]
                elif not pCatapultOverwatch.constructionTimer():
                        pCatapultOverwatch.checkUnits()
        [B]for ePlayer in lDeletePlayers:
                del overwatchDict[ePlayer][/B]

Basically, I can't delete defunct players from the dictionary while I'm iterating the same dictionary. Makes sense, and I simply added a separate additional process for deleting those entries.

 

[j_mie6]

so, why is it in there? What was it meant to do and why isn't it needed? Of course I could be completly wrong

 

[Baldyr]

The dictionary stores information on on-going catapult construction, and is organized by player. But once a player is eliminated these dictionary entries should be deleted also.

Note that the code posted above is the amended version that you should use. (Compare with the original function!) Its supposed to do the same thing, but actually work.

 

[j_mie6]

with out me having to look... what was the original like then how does it differ?

 

[Baldyr]

I believe it looked like this:

Spoiler :

def process():
        if not CatapultOverwatch.bEnabled: return
        for ePlayer, pCatapultOverwatch in overwatchDict.iteritems():
                debug(ePlayer, pCatapultOverwatch)
                if not pCatapultOverwatch.pCivPlayer.isAlive():
                        [B]del overwatchDict[ePlayer][/B]
                elif not pCatapultOverwatch.constructionTimer():
                        pCatapultOverwatch.checkUnits()

The highlighted line is invalid, apparently ("dictionary changed size during iteration"). Because the for-in loop is iterating the same dictionary (overwatchDict).

The problem is of course that I missed to test this myself - the eventuality that some player constructing a catapult is killed off. Sorry for that...

 

[j_mie6]

lucky that after you fixed the other bug I went and killed greece the turn after I was annoyed at them for giving me an exception Providing this works my Patch testing empire can rule over Italy, Greece, byzantium and turkey! (I am going that way to fully in game test byzantium )

 

[Baldyr]

All this testing is actually also an integral part of any software design, so keep up the good work finding all those bugs!

 

[j_mie6]

From adding new unit art the other day I found a bug in how some of the units were named which forced me to unpak the art files and change some of egypts unit's names as I have never tested with the latest art for eygpt (which I found would cause errors all over the place ) I never found this before the pak let's hope nobody has played with eypgt yet