RFCEurope 1.0

[HolyHandGrenade]

Here is a proposed fix for the buggy Polish UHV3 (for old and future versions). I changed the code to

• always accept Wonder Kazimierz as the target "2 Jewish Quarters"
• show the achieved number of buildings in the "Victory Screen"

1st image shows victory screen before Kazimierz is build, 2nd image after. The zip-file includes 4 files:

• Assets/Python/Victory.py:
  • Polish UHV3 when building wonder Kazimierz fixed.
  • Upper boundary checks for all religious building counter added.
• Assets/Python/screens/CvVictoryScreen.py:
  • Current Status for Polish UHV3 added (see images)

The additional 2 files are for minor problems:

• Assets/Python/RiseAndFall.py: Most of the time England doesn't get a galley on start. This is due to the "Calais" culture preventing the spawn. I just changed the "spawn"-range for the galley from "2" to "3" in line 2236.
• Assets/Python/Stability.py: Line 412: comment says Paganism but check is for DivineMonarchy. Paganism is correct here - fixed.

All changes are based on the original 1.01 sources without any additional modifications.

I hope I could contribute a little bit to this wonderful mod

 

[AbsintheRed]

Thx for your help, HolyHandGrenade!
Answered your PM too, be sure to check it

 

[AbsintheRed]

Btw, in your code you set the check for iOrthCath >= 2
It should be 3 IIRC

Also, does the overall check for UHV3 work right now?
I don't see any setUHV for Poland's 3rd UHV, at least not in the checkPoland section

 

[AbsintheRed]

I could let their UP create a plague in the cities. That will discourage the humans player to convert to Judaism as Arabia for sure.

Sry Merijn, but I will remove this
Feels ahistorical and imbalanced. Not to mention it may offend some players

Arabian UP with Judaism as state religion won't give any free buildings on conquest/flip/city build
It will still spread Judaism to the new cities

 

[AbsintheRed]

Attached is an adjusted Spawn-Map for 1.0 including spawn dates

Looks great, I will definitely include it!
Will you care to update it later?
If there are some small further changes in the map/spawns/indies?

 

[lzd]

Since this thread seems to be more regularly checked for fixes I'll use this post to point the maintainers' attention towards a bug (and fix!) for the Spanish.

Clicky

After all, 4 UHV:s for one civilization seems a bit much

 

[AbsintheRed]

Since this thread seems to be more regularly checked for fixes I'll use this post to point the maintainers' attention towards a bug (and fix!) for the Spanish.

Clicky

After all, 4 UHV:s for one civilization seems a bit much

Uhh, thank you!
Not sure how I missed your post
I read all the RFCE threads...

EDIT:
can you upload your full victory.py file?
would be easier to check/merge everything
especially since the file was changed since revision 933

 

[lzd]

Uhh, thank you!
Not sure how I missed your post
I read all the RFCE threads...

EDIT:
can you upload your full victory.py file?
would be easier to check/merge everything
especially since the file was changed since revision 933

Hmm, if Victory.py was changed since 933 it hasn't been committed, just updated to 937 without any modifications to it (e.g, svn diff had the same output before and after).

Oh well, attached in any case.

 

[AbsintheRed]

Hmm, if Victory.py was changed since 933 it hasn't been committed, just updated to 937 without any modifications to it (e.g, svn diff had the same output before and after).

Oh well, attached in any case.

Indeed, there were no changes in the SVN
But I meant that the file is changed in my work version
Actually I just uploaded revision 938, with a couple improvements

 

[AbsintheRed]

Alright, your fix is also up on the svn
Thanks!

 

[HolyHandGrenade]

Btw, in your code you set the check for iOrthCath >= 2
It should be 3 IIRC

Correct, please change it in your release version.

Also, does the overall check for UHV3 work right now?
I don't see any setUHV for Poland's 3rd UHV, at least not in the checkPoland section

The "setUHV" is done (as before) in function "onBuildingBuilt" (Line 393) I made a test with "checkPoland" function where I tried to sweep over all cities and recalculate what was there but this failed. You have to "build" the buildings, so "checkPoland" will not know if you conquered a city or if you lost a city. The only exception is Kazimierz wonder which prevents to build more Jewish Quarters! So Kazimierz is checked in function "onCityAcquired" (Line 316) too.

Edit: Fixed Victory.zip added. screens/CvVictoryScreen.py check for 3 OrthCath is OK.

 

[AbsintheRed]

Correct, please change it in your release version.
The "setUHV" is done (as before) in function "onBuildingBuilt" (Line 393) I made a test with "checkPoland" function where I tried to sweep over all cities and recalculate what was there but this failed. You have to "build" the buildings, so "checkPoland" will not know if you conquered a city or if you lost a city. The only exception is Kazimierz wonder which prevents to build more Jewish Quarters! So Kazimierz is checked in function "onCityAcquired" (Line 316) too.

Edit: Fixed Victory.zip added. screens/CvVictoryScreen.py check for 3 OrthCath is OK.

Thx! Actually I already uploaded it to the SVN last night
Btw, you should also use the latest svn version: http://sourceforge.net/projects/rfceurope/develop
Are you familiar with TortoiseSVN or another similar program?

 

[The Flame8]

Anyone else still on for the idea of splitting Germany into Bavaria and Saxony? Honestly, the mod would be almost perfect in my mind if this was changed...

 

[AbsintheRed]

Anyone else still on for the idea of splitting Germany into Bavaria and Saxony? Honestly, the mod would be almost perfect in my mind if this was changed...

Not for 1.0
There are plans to improve the HRE system of RFCE++ for RFCE2.0, Morholt had some cool ideas.
But now that Morholt is absent too, progress for 2.0 is really slow
I hope he will be back by the time I finish the new map

 

[AdrienIer]

How is the map going by the way ? How much have you already done ?

 

[The Flame8]

Alright, I'll still try and help with ideas and post feedback. The modmods gone a long way!

 

[AbsintheRed]

How is the map going by the way ? How much have you already done ?

Very slowly, only the base is ready

 

[HolyHandGrenade]

Thx! Actually I already uploaded it to the SVN last night
Btw, you should also use the latest svn version: http://sourceforge.net/projects/rfceurope/develop
Are you familiar with TortoiseSVN or another similar program?

I checked out the code with "cygwin-svn" - works perfectly.

In the attached zip (based on 942) I added a lot of German translations and fixed some minor english textes as I stumbled upon. In the "civics" and the UP file I added some ICON images to the text to see if it looks prettier.

Should I upload zip-files here in the forum or are there any other prefered methods?

 

[HolyHandGrenade]

UP: +2 , +1 per city without state
Pagan Shrine: +1 without state , +1 with Paganism

Problem: no city shows any for a pagan shrine

The city sliders are OK:
Vilnius: expected 5 got: 5 (palace, UP, shrine)
Gardinas: expected 4 got: 4 (UP, shrine, religion)
Ryga: expected 5 got: 5 (UP, shrine, orthMon, religion)
.
.
.
Minskas: expected 2 got: 2 (UP)

It seems only the city manager was unable to show the bonus. I tried to figure out how in RFC the Apostolic-Palace-Production-Bonus works but failed. Any ideas?

 

[AbsintheRed]

I checked out the code with "cygwin-svn" - works perfectly.

In the attached zip (based on 942) I added a lot of German translations and fixed some minor english textes as I stumbled upon. In the "civics" and the UP file I added some ICON images to the text to see if it looks prettier.

Should I upload zip-files here in the forum or are there any other prefered methods?

Zip files are prefect
Merged in all your translations, it's up in the SVN