1. We have added a Gift Upgrades feature that allows you to gift an account upgrade to another member, just in time for the holiday season. You can see the gift option when going to the Account Upgrades screen, or on any user profile screen.
    Dismiss Notice

Some modding questions

Discussion in 'Rhye's and Fall Modmods' started by Leoreth, Mar 27, 2010.

  1. Leoreth

    Leoreth 心の怪盗団 Moderator

    Joined:
    Aug 23, 2009
    Messages:
    33,052
    Gender:
    Male
    Location:
    Leblanc
    Well, making mistakes is the best way to learn. Knowing that, it seems I'll learn Python very fast :lol:
     
  2. Baldyr

    Baldyr "Hit It"

    Joined:
    Dec 5, 2009
    Messages:
    5,530
    Location:
    Sweden
    Well, not the best way. If you really wanna learn Python, for real, I could point you to a freely available entry level textbook. Since you already have some basic knowledge you'll be doing some pretty advanced stuff within a couple of weeks. :king:

    But still, the only way to really learn you have to use that knowledge. Only then will it all you learned start to work for you. I could however have saved hundreds of hours of head-scratching and trial-and-error if I would have taken the time to learn the basics first, instead of jumping in the deep end immediately. :p
     
  3. Leoreth

    Leoreth 心の怪盗団 Moderator

    Joined:
    Aug 23, 2009
    Messages:
    33,052
    Gender:
    Male
    Location:
    Leblanc
    I've got another problem now. I was playing with Plague deactivated for a longer time now (followed the advice of someone in this forum without really knowing what I was doing). Now I want to reactivate it, but can't find out how. My Plague.py is exactly the same as the file that comes with RFC (even compared them with WinMerge), and the only other file that seems to be accessing it (RFCEventHandler.py) also isn't changed.

    What am I missing?
     
  4. Baldyr

    Baldyr "Hit It"

    Joined:
    Dec 5, 2009
    Messages:
    5,530
    Location:
    Sweden
    Another module (.py file) is probably causing an exception making the Event Handler not access the Plague module. Have you enabled debugging yet?

    Well, its a theory...
     
  5. embryodead

    embryodead Caliph

    Joined:
    Jan 1, 2003
    Messages:
    5,179
    Location:
    basement
    If communications (embassies etc.) don't work either, Baldyr's theory is spot on. Another thing, have you added/removed any buildings or techs?
     
  6. Leoreth

    Leoreth 心の怪盗団 Moderator

    Joined:
    Aug 23, 2009
    Messages:
    33,052
    Gender:
    Male
    Location:
    Leblanc
    Yes, I've added one building, but changed the building ids in Consts.py accordingly:
    Spoiler :
    Code:
    #Buildings (update Persian UHV every time this is changed)
    iTemple = 77 #generic
    iCathedral = 78 #generic
    iShrine = 80 #generic
    
    
    iPalace = 0
    iGreatPalace = 1
    iSummerPalace = 1 #
    iVersailles = 2
    iForbiddenPalace = 2 #
    iWalls = 3
    iCelticDun = 4
    iCastle = 5
    iSpanishCitadel = 6
    iBarracks = 7
    iZuluIkhanda = 8
    iStable = 9
    iMongolGer = 10
    iBunker = 11
    iBombShelter = 12
    iGranary = 13
    iIncanTerrace = 14
    iAqueduct = 15
    iOttomanHammam = 16
    iKhmerBaray = 17
    iHospital = 18
    iRecyclingCenter = 19
    iLighthouse = 20
    iVikingTradingPost = 21
    iHarbor = 22
    iCarthageCothon = 23
    iCustomHouse = 24
    iPortugalFeitoria = 25
    iDrydock = 26
    iAirport = 27
    iForge = 28
    iMaliMint = 29
    iFactory = 30
    iGermanAssemblyPlant = 31
    iCoalPlant = 32
    iJapaneseShalePlant = 33
    iHydroPlant = 34
    iNuclearPlant = 35
    iIndustrialPark = 36
    iObelisk = 37
    iEgyptianObelisk = 38
    iEthiopianStele = 39
    iNativeAmericaTotem = 40
    iPublicTransportation = 41
    iAcademy = 42
    iLibrary = 43
    iArabianMadrassa = 44
    iUniversity = 45
    iChineseAcademy = 46
    iKoreanSeowon = 47
    iObservatory = 48
    iLaboratory = 49
    iRussianResearchInstitute = 50
    iTheatre = 51
    iFrenchSalon = 52
    iByzantineHippodrome = 53
    iColosseum = 54
    iGreekOdeon = 55
    iMayaBallCourt = 56
    iBabylonGarden = 57
    iBroadcastTower = 58
    iMarket = 59
    iRomanForum = 60
    iPersianApothecary = 61
    iGrocer = 62
    iBank = 63
    iEnglishStockExchange = 64
    iSupermarket = 65
    iAmericanMall = 66
    iCourthouse = 67
    iAztecSacrificialAltar = 68
    iHolyRomanRathaus = 69
    iSumerianZiggurat = 70
    iJail = 71
    iIndianMausoleum = 72
    iLevee = 73
    iNetherlandsDike = 74
    iIntelligenceAgency = 75
    iNationalSecurity = 76
    iJewishTemple = 77
    iJewishCathedral = 78
    iJewishMonastery = 79
    iJewishShrine = 80
    iChristianTemple = 81
    iChristianCathedral = 82
    iChristianMonastery = 83
    iChristianShrine = 84
    iIslamicTemple = 85
    iIslamicCathedral = 86
    iIslamicMonastery = 87
    iIslamicShrine = 88
    iHinduTemple = 89
    iHinduCathedral = 90
    iHinduMonastery = 91
    iHinduShrine = 92
    iBuddhistTemple = 93
    iBuddhistCathedral = 94
    iBuddhistMonastery = 95
    iBuddhistShrine = 96
    iConfucianTemple = 97
    iConfucianCathedral = 98
    iConfucianMonastery = 99
    iConfucianShrine = 100
    iTaoistTemple = 101
    iTaoistCathedral = 102
    iTaoistMonastery = 103
    iTaoistShrine = 104
    iHeroicEpic = 105 #
    iFlavianAmphitheatre = 105
    iNationalEpic = 106
    iTriumphalArch = 106 #
    iGlobeTheatre = 107
    iNationalPark = 108
    iHermitage = 109
    iNationalGallery = 109 #
    iChannelTunnel = 110
    iWallStreet = 111
    iIronWorks = 112
    iTradingCompany = 113
    iMtRushmore = 114
    iRedCross = 115
    iScotlandYard = 116
    iInterpol = 116 #
    iPyramid = 117
    iStonehenge = 118
    iGreatLibrary = 119
    iGreatLighthouse = 120
    iHangingGarden = 121
    iColossus = 122
    iOracle = 123
    iParthenon = 124
    iAngkorWat = 125
    iHagiaSophia = 126
    iChichenItza = 127
    iTempleOfKukulkan = 127 #
    iSistineChapel = 128
    iSpiralMinaret = 129
    iNotreDame = 130
    iTajMahal = 131
    iKremlin = 132
    iEiffelTower = 133
    iStatueOfLiberty = 134
    iBroadway = 135
    iWembley = 135 #
    iRocknroll = 136
    iGraceland = 136 #
    iHollywood = 137
    iGreatDam = 138
    iPentagon = 139
    iUnitedNations = 140
    iSpaceElevator = 141
    iMilitaryAcademy = 142
    iArtemis = 143
    iSankore = 144
    iGreatWall = 145
    iStatueOfZeus = 146
    iMausoleumOfMaussollos = 147
    iCristoRedentor = 148
    iShwedagonPaya = 149
    iMoaiStatues = 150
    iCorporation1 = 151
    iCorporation2 = 152
    iCorporation3 = 153
    iCorporation4 = 154
    iCorporation5 = 155
    iCorporation6 = 156
    iCorporation7 = 157
    iApostolicPalace = 158
    iLeaningTower = 159
    iOlympicPark = 160
    iTempleOfSalomon = 161
    
    iNumBuildings = 162 
    iPlague = 162
    iNumBuildingsPlague = 163
    
    iEgyEmbassy = 163
    iIndEmbassy = 164
    iChiEmbassy = 165
    iBabEmbassy = 166
    iGreEmbassy = 167
    iPerEmbassy = 168
    iCarEmbassy = 169
    iRomEmbassy = 170
    iJapEmbassy = 171
    iEthEmbassy = 172
    iMayEmbassy = 173
    iVikEmbassy = 174
    iAraEmbassy = 175
    iKhmEmbassy = 176
    iSpaEmbassy = 177
    iFraEmbassy = 178
    iEngEmbassy = 179
    iGerEmbassy = 180
    iRusEmbassy = 181
    iHolEmbassy = 182
    iMalEmbassy = 183
    iPorEmbassy = 184
    iIncEmbassy = 185
    iMonEmbassy = 186
    iAztEmbassy = 187
    iTurEmbassy = 188
    iAmeEmbassy = 189
    
    iNumBuildingsEmbassy = 190

    The conqueror's plague also still works. Exceptions and logging are activated and show no problems.
     
  7. embryodead

    embryodead Caliph

    Joined:
    Jan 1, 2003
    Messages:
    5,179
    Location:
    basement
    Consts.py is not enough, you have to update the building IDs in CvRhyes.h. This isn't directly related as plague works with python only, but still, the constants in CvRhyes.h are used in a number of places in the SDK and if wrong, they're guaranteed to cause some problems with embassies and wonders at least - I'm not even sure if they're wrong, but it's worth checking.
     
  8. Baldyr

    Baldyr "Hit It"

    Joined:
    Dec 5, 2009
    Messages:
    5,530
    Location:
    Sweden
    If I'm not mistaken, the Plague is a building. So if the buildings in the mod aren't defined correctly that could very well affect how the Plague feature works.
     
  9. Leoreth

    Leoreth 心の怪盗団 Moderator

    Joined:
    Aug 23, 2009
    Messages:
    33,052
    Gender:
    Male
    Location:
    Leblanc
    Oh, wasn't aware of that. I'll look into the file.

    Still: there doesn't seem to be a problem with the building ids, as the conqueror plague works. Rather seems the normal plague doesn't trigger for some reason.
     

Share This Page