Start from Play Now testing phase

[merijn_v1]

- fixed unit AI for spawned naval units

In the commit of this change, consts.py changed iTransport is changed to iRaidSea. But RFCUtils uses the old iTransport.
https://github.com/dguenms/Dawn-of-Civilization/commit/b1ca3e9bb67e7e081c76ef18c68732348556759b

 

[Leoreth]

New update:
- you do no longer receive expansion spawns when declaring war on minor civs
- fixed unit role constants

Thank you, Leoreth!
Also, I have noticed in the Arabia game after the switch from Egypt (epic speed) I get perhaps too many conquerros. Two stacks at spawn, one stack in the middle of Algiers dessert for some reason shortly after and two massive stacks from wars deceleration on Rome and Persia. Not sure what could cause it.

What happened here was ultimately caused by the Persian collapse. If you are at war with a collapsing player, you automatically declare war on the independent player(s) receiving their cities, so your units do not get bumped out of their territory entirely. This war declaration against independents in turn triggered a spawn of expansion units.

In the commit of this change, consts.py changed iTransport is changed to iRaidSea. But RFCUtils uses the old iTransport.
https://github.com/dguenms/Dawn-of-Civilization/commit/b1ca3e9bb67e7e081c76ef18c68732348556759b

Good catch. I thought a separate iRaidSea unit role was needed but in the end it was still the same as iTransport. At the end of it I accidentally removed iTransport instead of iRaidSea.

 

[Leoreth]

New update: fixed autoplay observer mode.

 

[stillblackadder]

Thank you for updates. A couple of more bugs:
- Probably not related to the branch, but Tamil trade goal not ticking, stays at 0.
- After switching to Khmer, I am getting series of Python errors every turn

 

[Just an idea]

I tried to get custommap branch by downloading Zip file. When I launch a game I got error message about global name PARSER not being defined. Whole map was flat grassland. I've included pictures and save game from start of the game in case those are any help.

 

[Leoreth]

I tried to get custommap branch by downloading Zip file. When I launch a game I got error message about global name PARSER not being defined. Whole map was flat grassland. I've included pictures and save game from start of the game in case those are any help.

For all files in the Private Maps folder, open them with Notepad++ and use Edit > EOL Conversion > Windows.

 

[Leoreth]

Thank you for updates. A couple of more bugs:
- Probably not related to the branch, but Tamil trade goal not ticking, stays at 0.
- After switching to Khmer, I am getting series of Python errors every turn

Neither reproduce for me, when I end the turn on the first save it ticks up for me. Are you seeing Python errors there? The Khmer switch also works without issues.

 

[AOS9001]

In my Dutch playthrough I was still getting the [x] civilization has been destroyed message before they spawned, even after pulling the update yesterday. I thought it was because it was an old save so I started a new game, where it still appears. Not sure if this is just me somehow screwing up Github updates or if the fix didn't actually work in all cases. Looking back at the event log shows I've gotten the message for every civilization, I just hadn't noticed.

I also saw some weird congress behavior in the Dutch game but I want to see if its replicated in this update.

 

[1SDANi]

Latest revision, ending the turn ends all three of my cities, my only cities, declaring independence from me and joining Arabia. Players are no longer able to play as Egypt beyond 620 AD

 

[Leoreth]

I also saw some weird congress behavior in the Dutch game but I want to see if its replicated in this update.

Can you be more specific?

 

[AOS9001]

Can you be more specific?

There were several python exceptions and only my civ, Japan, and America were invited (twice in a row). I haven't gotten far enough in my current game to have congresses but here's some more random python exceptions:

Edit: I think this is related to Mexico, because Spain seems to have refused the city flip somehow and is not at war with Mexico. Mexico's starting units just sit in Mexico City and do nothing.

Edit 2: Colombia spawned without any techs, pic related. Peru actually has techs at spawn now but they're stuck in the early Renaissance in the 1800s.

 

[AOS9001]

I managed to get another congress with only four participants, but it snuck up on me and I didn't have a savepoint anywhere near the congress date. I went back to an autosave and tried to get there again, but this time I got two congresses at once. I wonder if the small congresses I've been getting are the result of wars ending and not the regular vanilla RFC congress?

 

[stillblackadder]

Neither reproduce for me, when I end the turn on the first save it ticks up for me. Are you seeing Python errors there? The Khmer switch also works without issues.

I have just loaded those saves myself and everything is fine on my end now too - gold started tickling and there is no python errors after Khmer switch. I make sure to take a few screenshots next time.

 

[Just an idea]

Played Egypt game on Epic. Culture goals seem to display amount required on normal. In 200 BC I got Python Error regarding some conqueror event. 240 BC save is last I have before that. In 80 AD save game allows me to build cottage or farm on desert tile with no flood plains.

 

[Leoreth]

Yes, yesterday I noticed that currently all goals that should be sensitive to game speed are not (even on the develop branch). Will investigate that first thing when I have time.

In 80 AD save game allows me to build cottage or farm on desert tile with no flood plains.

That should have been fixed on the develop branch already, after this one branched off. So it will be fixed on merge/rebase.

 

[stillblackadder]

Opening victory screen as Ethiopia gives Python Exception

 

[AOS9001]

Today's bug report is only a weird little python exception about map sizes that popped up when I discovered Refining.

Edit: It's happened several times since, both when discovering techs and when not discovering techs. Attached is another save where it happens if you want to compare it to the first.

Not a bug, but is it possible to prevent the AI from asking you to join their war against Independents? It's very annoying for everyone and their mother to ask you to join their war every other turn, and then to top it off you get an opinion malus for refusing to join their war too (or the opposite, you get a bonus just from fighting the same set of Independents other civs are fighting, even if you're on opposite sides of the planet). I've also noticed the AI really likes to go after certain independents. Athens in particular has attracted armies from France, the Netherlands, the Mughals, and Arabia, despite it being off their expansion maps as far as I know. I've been keeping it alive in this save in the hopes Greece will spawn but no such luck yet.

On the plus side, the time between turns is sometimes as short as 30 seconds, which is a massive increase in performance, older versions would have a turn change in the late 1800s taking up to 3 minutes on my machine.

 

[Leoreth]

Not a bug, but is it possible to prevent the AI from asking you to join their war against Independents? It's very annoying for everyone and their mother to ask you to join their war every other turn, and then to top it off you get an opinion malus for refusing to join their war too (or the opposite, you get a bonus just from fighting the same set of Independents other civs are fighting, even if you're on opposite sides of the planet). I've also noticed the AI really likes to go after certain independents. Athens in particular has attracted armies from France, the Netherlands, the Mughals, and Arabia, despite it being off their expansion maps as far as I know. I've been keeping it alive in this save in the hopes Greece will spawn but no such luck yet.

Yeah, the AI should not ask you about that, it never did on the develop branch. Looks like the condition that filters them as possible targets got broken by the change.

On the plus side, the time between turns is sometimes as short as 30 seconds, which is a massive increase in performance, older versions would have a turn change in the late 1800s taking up to 3 minutes on my machine.

Oh, that's great to hear. We haven't even seen the most significant possible performance improvement yet. Was that on the 1700 AD scenario? That one should be the most improved already.

 

[Just an idea]

Babylonia game. Susa culture flipped to me and I ordered city to disband. What would you like to build screen opened and game crashed. When I reloaded game had lost track of what techs I had discovered first.

EDIT: Doesn't seem to be issue with just reloading. Started new game and it didn't register any discoveries.

 

[Dracosolon]

Game keeps spamming this Python error at the start of turn:

Traceback (most recent call last):

File "CvScreensInterface", line 941, in canEverRespawn

File "RFCUtils", line 804, in canEverRespawn

File "DataStructures", line 54, in __getitem__

AttributeError: 'NoneType' object has no attribute 'getCivilizationType'
ERR: Python function canEverRespawn failed, module CvScreensInterface