Randomly test abit and some bugs for you.
1) onBuildingBuilt is pretty screwed.
if BuildingInfo.getReligionType() == pPlayer.getStateReligion():
does not check that the State Religion can be -1.
All the following elif statements for Nazca, Brandenburg etc are all turned off due to this statement.
2) MapScript Tools
Code:
lx = xrange(x0, x0+3)
ly = xrange(y0, y0+3)
if bSide:
lx.append( x0+3 )
else:
ly.append( y0+3 )
xrange cannot append...
3) Hagia Sophia
Already mentioned before. Capture of UB is a screwed effect.
The UB does not count when Building Class is needed for other stuff.
For instance, lighthouse is needed for Great Lighthouse.
Captured lighthouse UB will not allow you to build Great Lighthouse.
4) Advisor Screen
At low resolutions like 1024x768, all the Advisor Screens are truncated. You cannot see everything.
5) Victory Screen
Going to Members is screwed.
6) Insularity Tenet
Will not work due to Apolistic Palace, since it only checks the Capital and assume it is the same for all cities.
Apolistic Palace resolution anger will only affect cities with the religion, which the capital may not be affected.
7) Incapacitate
It doesn't check the victim's ownership.
Which means you may end up stunning your own invisible troops on the loser plot.
8) Great People Bar
self.Y_GREAT_PERSON_BAR += self.H_DEFAULT_BAR - 2
Because of this statement, every time you load a game, the codes are activated and the GP Bar shifts downwards.
9) Incapacitate and Fire
if not pUnit.isNone() or not pUnit.isDead():
Shouldn't it be AND instead
10) Changing Religion via WB will bring up the Tenet page
11) Pollution
All those Pollution Removal Buildings only check when they are built.
When 2 rival cities are nearby, after awhile if a polluted mine becomes under my city culture, it will remain polluted even if I have the respective removal building in the nearby city.
12) Goody Barbarians
Not under water plot check. Screwed for land goodies.
13) setNumRealBuilding
Will not trigger onBuildingBuilt codes.
Thus, all codes using this code and are supposed to have effects onBuildingBuilt are screwed, such as free Temples and Wonders
14) Building Class Count
All those checking BC Count == 1 should be changed to > 0.
Because if I want to create a scenario with multiple copies of World Wonders, I may end up with 2 similar Wonders, which would disable the code.
Similarly, break statements should be removed. Just because a World Wonder is found, does not mean there may not be a 2nd one for scenarios.
15) World Wonders
Most of the XML World Wonders are Team Based, such as Stonehenge will benefit all cities of all team members.
Python World Wonders however, are mostly done as Player only effects. Should consider changing all to team effects.
16) Taj Mahal
Only checks for onGoldenAge and onEndGoldenAge
There should be more checks such as onBuildingBuilt, already in Golden Age.
Else, I don't get a boost if I build TM during GA, but when GA ends, I get a penalty.
Similarly, there should also be checks for vassals spawned during a TM GA, else boost not applied, but penalty will.
Other areas such as razing and wonder change hands blah blah blah.
17) Colonists
Mentioned before, it can be easily screwed, so long as CyInterface().getHeadSelectedUnit() is not Colonist, even though city founded by a Colonist.
18) Capture Research onCityAcquired
Triggered even not by Conquest. Meant to be?
Why should it be so, if I give the city free.
19) onCultureExpansion
Triggered even when a city comes out of disorder.
Culture Level Yield is screwed effect.
20) cannotTrain
if pPlayer.getUnitClassCountPlusMaking(UnitInfo.getUnitClassType()) >= HR_Religion.getMaxReligiousUnit(pPlayer):
This means if Max Limit is 4 =>
When I have 3 of those units, my city can still build a 4th one.
But on the next turn, since getUnitClassCountPlusMaking will now == 4, the city building the 4th one will no longer be able to train it and will be stopped.
21) Great General Bar
What has this gotta do with Anarchy? GG can still spawn during Anarchy
