Or for that matter is the upgrade from assassin to sniper worth it if they can't get the same promos? That is why I would like to have that system changed in the Combat mod.
The point is that the sniper, being so similar in nature, should have a shared combat class with the assassin and the promos that we are feeling shouldn't have been removed in the transition should be on that shared combat class. That resolves the issue and is the way it was intended to work. There is no reason for it not to be adjusted that way and a lot of reasons to not undo or rework the coding side of it.
This should be seen as a positive rather than a negative. It gives us more control and a capacity to find, via these reports, where our promotion chains have irrational linkages in the first place. I mean, you could be asking right now, "What's the point of having the promotion removed when the Assassin upgrades to the Sniper" OR you could adjust perspective and ask
"Why aren't Snipers able to get these promotions that seem to fit them in the first place"???
Haven't you ever been irritated to see a Machine Gunner who can't attack carrying around a City Raider promo from a previous unit class promotion selection? Wouldn't it be nice, now that you've upgraded to the Machine Gunner that can't attack, to be able to reselect that decision now that its worthless to the new form of the unit? That's what this allows.
My point is, it's not that Snipers should be losing Stealth style promos, its that they should've had access to them in the first place. And that's what this 'bug' report is showing us. Not that the system needs to change to adjust for the desire to have less work to do there.
If the B Elep is in the Tank line, how come i am losing its promotions?
Also shouldn't the Tank Factory, be added to the + category?
Again, because although the Elephant is in the Tank line, as in, it can promote to Tanks, it does not share the same combat class(es) as the tanks they can upgrade to. When they become tanks, those promos that elephants can get but tanks can't are lost, but if you selected any promotions that were lost as a result of leveling up your unit and those lost promos weren't 'free' in the first place, you get to reselect them from among the promos that tanks CAN get.
And again... if there are promotions that elephants can get that tanks can't, we should be asking, Should tanks be able to get these promotions then? Is there a good reason they can't? If so, it should be acceptable that they lose those promos. If not, then the promotion prerequisites should be adjusted so that the tank combat classes have access to them.
I've done a lot of work to make prerequiste establishments a far easier affair in the combat mod so as to minimize the impact of these kinds of adjustments.
And all they are catching seems to be the frustrating things I've been noting for years about our promotion prerequisite structures anyhow. There's tons of places I've seen in play where I must shake my head wondering why the new upgraded unit can't select what it was able to before the upgrade. This mechanism is now highlighting those spots for us so we can address them as they come up.
(There's also been a lot of those Machine Guns with City Raider kinds of situations and those don't seem right either.)
Another argument to keep the system as is and continue to adapt our promotion prerequisite structures instead: ONLY the human players have the cleverness necessary to take advantage of knowledge of the unit promotion tree to promote in such a way as to provide promotions for units that would otherwise never have access to those promotions. This mechanism takes that edge over the AI decision making processes out of the equation helping to bring the AI closer to the human player in 'skill'.