C2C SVN Changelog

10854
  • Fix steam batch file to add the mod command line. If you already have a command line setup in steam this will interfere with it though! It also brings up a warning about the command line existing.
 
10858
Removed unnecessary stuff from scenarios.

All those starting eras, flag decals, civic options being here only made maps more prone to be broken.
Also flags of custom civs are broken for V39 scenario players (generated map players are fine), if scenarios had flag paths defined.
Flags were moved to FPKs, and their relative patches were changed in xml.
No one noticed, that bonuses in some scenarios had wrong names for 5 years or so until SO reported, that something was wrong :lol:
Similarly starting dates and units were broken for few years in scenarios too.
 
Last edited:
10859 (Branch only)
  • Update to BuildingClass project branch: WonderClass code refactoring, see my changelists.
  • Save game breaking due to changes in building count cache in CvGame and CvTeam, though I forgot to edit the save game version declaration.
 
Last edited:
10860
  • Performance improvements in CvPlayer::canTrain.
  • Optimized some usages of the CvUnitInfo tag Buildings.
@billw2015 @Anq
Then you guys change the data storage of CvInfo tags from arrays to vectors some things will become slower as they where before especially if the usages of these tags don't get adjusted as well!!!!!!!
Those really small memory usage reductions are really not worth it if the turn times increase.
 
Those really small memory usage reductions are really not worth it if the turn times increase.
Obviously, for me the intent WAS to reduce round time, which my profile results showed that I did (at least in my case), memory saving was just a benefit. It may have reduced it in some other place in some other case of course, but that doesn't mean it was a net loss. My intent is to continue profiling and fixing up other places where the performance is affected, but you have beaten me to it!
 
10862

  • Fixed the CvUnitInfo::getHasBuilding python export.

Obviously, for me the intent WAS to reduce round time, which my profile results showed that I did (at least in my case), memory saving was just a benefit. It may have reduced it in some other place in some other case of course, but that doesn't mean it was a net loss. My intent is to continue profiling and fixing up other places where the performance is affected, but you have beaten me to it!

If it's possible try to avoid looping through getNumBuildingClassInfos() and searching something in a vector in every iteration. That will definitely be slower as just returning a bool from an array.
 
If it's possible try to avoid looping through getNumBuildingClassInfos() and searching something in a vector in every iteration. That will definitely be slower as just returning a bool from an array.
Yeah I'm not done yet it was just a first step.
/edit Also if you have save game that shows a round time increase with my changes I would love to see it so I can compare and use it in future.
 
Last edited:
10865
  • Added a tooltip for commerce percent buttons, right click the buttons for it to show.
  • Adjusted how the modifier keys change the commerce slider increments.
  • Added a pedia concept shortcut sub-category for the commerce distribution control buttons.'
    • Pedia shows the same as the tooltip though.
  • 8800_20190802185801_1.jpg
@strategyonly: try right clicking the commerce percent buttons.
Edit: Oh now it occured to me that it might have been best to use right click to adjust to max/min and drop the tooltip.... Damn, what do you think SO?
 
Last edited:
10866 (branch only)
  • Adding some experimental batch files, one for setting up directory junctions, one for perform a directory restructure using svn move.
 
10872
  • FPK scripts improved. They now ask where to unpack to, saving that for future runs. Introduction text added.
  • Install script added that links SVN workspace outside of Mods directory into the Mods directory, so it can be run/modified without copying.
 
10873 (Branch only)
Branch: fixed Pepper2000 Ascension Gate which sets the bForceOverwrite flag so tags have to be copied over.
10874 (Branch only)
Branch: moved isWorldProject etc to CvProjectInfo from CvGameCoreUtils
10875 (Branch only)
Branch: moved UnitClassInfo tags into UnitInfo, refactored isWorldUnit etc., see my changelog-3.
10876 (Branch only)
Branch: fix some places from the last commit​
 
10877 (Branch only)
Branch: Easier way to do Religion and Corporation sorting by TGA index.​
10878
[reverted] Merge revision 10877 from branches/newXMLLoadUtility: Easier way to do Religion and Corporation sorting by TGA index.​
10879
[reverted] (Also a simpler function to sort civilization and leader infos alphabetically in the XML Loader class.)​
10880
Revert change from last revision back to 10878. Sorry.
10881
  • Revert to 10872. Sorry again.
 
Back
Top Bottom