45°38'N-13°47'E
Deity
I can check, I put it on my to do list.Here's something I just came across. The Mercantilism civic uses a tag for <iSharedCivicTradeRouteModifier>. Its effect is supposed to be -25 trade income from nations with same civic.
Does this tag even do anything any more, now that trade routes have been replaced by connectedness? I tried looking through the sources files and I could only find references in the CvInfos files. My guess is that this was taken out of the source files along with everything else that depended on trade routes. If this is true, then it's a bullet point we don't need.
Edit: I think it's still being used:
Code:
int CvCity::totalTradeModifier(CvCity* pOtherCity) const
{
int iModifier = 100;
iModifier += getTradeRouteModifier();
iModifier += getPopulationTradeModifier();
/************************************************************************************************/
/* Afforess Start 03/8/10 */
/* */
/* */
/************************************************************************************************/
iModifier += GET_TEAM(getTeam()).getTradeModifier();
/************************************************************************************************/
/* Afforess END */
/************************************************************************************************/
if (isConnectedToCapital())
{
iModifier += GC.getDefineINT("CAPITAL_TRADE_MODIFIER");
}
if (NULL != pOtherCity)
{
if (area() != pOtherCity->area())
{
iModifier += GC.getDefineINT("OVERSEAS_TRADE_MODIFIER");
}
if (getTeam() != pOtherCity->getTeam())
{
iModifier += getForeignTradeRouteModifier();
/************************************************************************************************/
/* Afforess Start 3/8/09 */
/* */
/* */
/************************************************************************************************/
iModifier += GET_PLAYER(getOwnerINLINE()).getForeignTradeRouteModifier();
iModifier += GET_TEAM(getTeam()).getForeignTradeModifier();
CvPlayer &kOtherPlayer = GET_PLAYER(pOtherCity->getOwnerINLINE());
CvPlayer &kPlayer = GET_PLAYER(getOwnerINLINE());
for (int iI = 0; iI < GC.getNumCivicOptionInfos(); iI++)
{
if (kPlayer.getCivics((CivicOptionTypes)iI) == kOtherPlayer.getCivics((CivicOptionTypes)iI))
{
iModifier += GC.getCivicInfo(kPlayer.getCivics((CivicOptionTypes)iI)).getSharedCivicTradeRouteModifier();
}
}
/************************************************************************************************/
/* Afforess END */
/************************************************************************************************/
iModifier += getPeaceTradeModifier(pOtherCity->getTeam());
}
}
return iModifier;
}
I need to check the revision where Trade Routes have been removed but I think this modifier applies to the trade created by connectedness too.
Edit2: ok, it's probably not being used. totalTradeModifier is used inside a loop for Trade Routes which is never being passed because number of trade routes is set to 0.