Current (SVN) development discussion thread

[banestrider]

Spoiler :

There would appear to be some bugs to still work out.

 

[Leoreth]

I had a python exception while playing with the current version.
Happened in the following turn of my save, I've updated with SVN just one hour ago, I hope it could help :

Spoiler :

Took me a while to figure out what's wrong but the save was very helpful there! Turns out that it was possible to lose contact to a civ but still remain in contact with their vassal or master, and the BUG scoreboard couldn't handle that. Instead of adapting the scoreboard I forbade this counter-intuitive outcome altogether.

(This is part 143 of my ongoing series: "Rhye's code is horrible and I'd rather completely rewrite it than fix it".)

Spoiler :

View attachment 360593

There would appear to be some bugs to still work out.

Yep, that's what Lone Wolf was talking about with the city's BFC. Thinking about it, maybe uncontrolled tiles should also be excepted ...

In any case, both issues have been fixed with the most recent SVN commit.

 

[Malchar]

I had a python exception on one of the newer svn's last night. Sometimes when I gifted techs to weaker AI civs it would cause an exception and then the civ would collapse, and a local civ would respawn there immediately. It happened twice: Korea collapsed into China when I gave rifling and chemistry, and my vassal Bolivar collapsed into Spain when I gave biology.

I have all the details written down along with a few other exceptions that I can post later when I get off work. So far, the new SVN has been great though. No game-ending errors, and I haven't even had any bad memory allocations (I think that those are a problem on my end though).

 

[Bocator]

Got this while loading a French game :

Spoiler :

However I still can play my game at the moment.

 

[blizzrd]

I got similar problems on an Ethiopian start too:

Spoiler :

But I did get my workers this time.

 

[Leoreth]

Sorry, I've already fixed this in my working copy but forgot to commit. Now it's online. Also: spawning resources now come with a notification.

 

[Oregon Lee]

What about despawning, like the ivory near Carthage?

 

[Malchar]

Here's the full information about all the stuff I have encountered so far in 575:

Spoiler :

First off, I do have one thing that wasn't necessarily related to an exception. I noticed at one point that the avatars for the Independent civs on the military advisor deployment tab had been replaced by the avatar for Peter the Great. It might have something to do with this exception that I got randomly at the beginning of a turn, but that's just my speculation. I don't remember how many turns there were between this happening and when I noticed the avatars:

Spoiler :

NameError: global name 'iIndependent' is not defined
File "Stability", line 1754 in getResurrectionTechs
File "Stability", line 1624 in doResurrection
File "Stability", line 1522 in checkResurrection
File "RiseAndFall", line 1250 in checkTurn
File "CvRFCEventHandler", line 571 in onBeginGameTurn
File "BugEventManager", line 401 in _handleDefaultEvent

When I gifted rifling and chemistry to Korea, I got this exception and then Korea collapsed and China respawned. I also got an identical exception when the Moors, who were a vassal of the Ottomans, spontaneously collapsed. Perhaps an AI traded them a technology? Also, I don't have the exception written down from when Bolivar collapsed, but it was probably the same as this.

Spoiler :

IndexError: list index out of range
File "RFCUtils", line 1628 in getHighestEntry
File "Stability", line 1787 in relocateCapital
File "Stability", line 1677 in doResurrection
File "Stability", line 565 in secedeCities
File "Stability", line 586 in completeCollapse
File "Stability", line 331 in triggerCrisis
File "Stability", line 294 in checkStability
File "Stability", line 59 in onTechAcquired
File "CvRFCEventHandler", line 661 in onTechAcquired
File "BugEventManager", line 401 in _handleDefaultEvent

When I captured the Austrian capital Budapest, I got this exception and then Austria collapsed and Italy respawned with their remaining cities (which were Rome and the one south of Rome).

Spoiler :

IndexError: list index out of range
File "RFCUtils", line 1628 in getHighestEntry
File "Stability", line 1787 in relocateCapital
File "Stability", line 1677 in doResurrection
File "Stability", line 565 in secedeCities
File "Stability", line 586 in completeCollapse
File "Stability", line 225 in checkLostCoreCollapse
File "Stability", line 50 in onCityAcquired
File "CvRFCEventHandler", line 173 in onCityAcquired
File "BugEventManager", line 401 in _handleDefaultEvent

I got this exception when I went to the menu to release cities as a vassal but I chose not to release any. I think you mentioned that this might have already been fixed.

Spoiler :

IndexError: list index out of range
File "RFCUtils", line 1628 in getHighestEntry
File "Stability", line 1787 in relocateCapital
File "Stability", line 1697 in doResurrection
File "CvRFCEventHandler", line 736 in onReleasedPlayer
File "BugEventManager", line 401 in _handleDefaultEvent

I got this exception when I went to the info screen where it shows the graphs for each civ. I went to GNP and it worked, but when I set the other dropdown box to show "last 50 turns", it didn't do anything and I got this.

Spoiler :

File "CvScreensInterface", line 1030 in handleInput
File "CvInfoScreen", line 3138 in handleInput
AttributeError: CvInfoScreen instance has no attribute 'szGraphSmoothingDropdownWidget_1in1'

I also have one last exception as an attached image:

 

[billyleeback16]

Here's a whole bunch of Python exceptions I got in SVN 578 when I finished researching Economics. Apparently something about the stability check that happens when you reach that tech didn't work quite right.

 

[billyleeback16]

Here's another batch of Python exceptions from the same game and same version, this time generated by the dynamic resources appearing in 1500:

 

[Oregon Lee]

EDIT:
So, when is the VD going to be updated . Then the map will be nearly perfect from here on out.
Unless what you're doing will obsolete them real soon..

 

[Daffy]

delete

 

[Leoreth]

Is it intentional that America no longer gets New York, Boston & Charleston as flipped cities?
Had the issue both in rev. 575 and 578 now.

It's not, seems like there was an error that got in the way. Maybe it's even one of the already reported ones, I hope I can get to fixing them today.

 

[borhap88]

If I can give my feedback, new Keshik combined with new Mongolian UP work very well

 

[Leoreth]

Great to hear, that was also my impression from my short test invasion of China.

 

[Malchar]

1700 AD Prussia. I got the first UHV, verified it on the victory tab, and saved the game a few turns later. When I loaded the game, now it says "Not yet" even though it's past the required year. I reloaded a save from before I accomplished the victory, got it again, verified it, saved, reloaded, and it says "Not yet" again. I think the same thing happened with the second UHV as well, but I can't double check that one as easily.

This happened on 575. I updated to 578, and it still seems to be messed up.

I also got this exception which can't be clicked-through on a few occasions immediately after having loaded a save.

 

[Leoreth]

I also got this exception which can't be clicked-through on a few occasions immediately after having loaded a save.

Did this happen in 578?

 

[Leoreth]

New commit: should take care of everything reported here since yesterday.

 

[Malchar]

Did this happen in 578?

Yea, but I was loading games that had been saved from previous versions. I think they were all from 575 originally.

 

[Leoreth]

Yea, but I was loading games that had been saved from previous versions. I think they were all from 575 originally.

Yeah, that's bound to cause trouble. One of the revisions between 575 and 578 broke savegame compatibility because there was something wrong with how game data was saved and I had to redo everything.