DLL - Unified Yields

[bane_]

Just for the record, pretty cool Tourism icon.

 

[bane_]

Yields from Traits (requires V57a)

Culture Faith Food Gold Production Science Tourism Golden Age
Trait_ExtraYieldThresholds test test test test test test test impl
Trait_ImprovementYieldChanges xml test test test xml xml test test
Trait_PlotYieldChanges test test test test test test test test
Trait_SpecialistYieldChanges test test test test test xml test test
Trait_TerrainYieldChangestest test test test test test test test test
Trait_UnimprovedFeatureYieldChanges xml test test test test test test test
Trait_YieldChanges test test test test test test test test
Trait_YieldChangesIncomingTradeRoute test test test xml test test - impl
Trait_YieldChangesNaturalWonder test test test test test test test test
Trait_YieldChangesPerTradePartner xml test n/a xml n/a test - test
Trait_YieldChangesStrategicResources test test test test xml test test test
Trait_YieldModifiers test test test test test test test test

No idea what the first one does.
Re-testing the other two.

EDIT: ChangesIncomingTradeRoute did not work.

 

[bane_]

Yields from Buildings (requires V57a)

Culture Faith Food Gold Production Science Tourism Golden Age

Building_AreaYieldModifiers test test test test test test test impl

Building_BuildingClassYieldChanges xml test test xml test test test test
Building_FeatureYieldChanges test test xml xml xml xml test test
Building_GlobalYieldModifiers test test xml test test test test test
Building_LakePlotYieldChanges test test xml test test test test test
Building_PlotYieldChanges test test test test test test test test
Building_ResourceYieldChanges xml xml xml xml xml test test test
Building_ResourceYieldModifiers test test test test test test - brkn¹
Building_RiverPlotYieldChanges test test test test xml test test test
Building_SeaPlotYieldChanges test test xml test test test test test
Building_SeaResourceYieldChanges test test test xml xml test test test
Building_SpecialistYieldChanges test test test test xml xml test test
Building_TechEnhancedYieldChanges xml test test test test test test test
Building_TerrainYieldChanges test test xml test xml test test test
Building_YieldChanges xml xml xml xml xml xml test test
Building_YieldChangesPerPop test test test test test xml test test
Building_YieldChangesPerReligion test xml test test test test - brkn²
Building_YieldModifiers test test xml xml xml xml test test

¹ Apparently it is not requiring the building, only that the resource is improved.
² I don't know exactly how it is broken, but it is not adding the values correctly. I used the Candi as a template, so for each Religion present in the city I should get 2 golden age points, this last test gave me 6. It is not based on the amount of citizens or followers either, as I had only 2.


Haven't tested the first because I have no clue how to.

I have to go now, but if it's still available later, I'll try the Improvements.

 

[whoward69]

Thanks for those. Building_AreaYieldModifiers adds the bonus to all yields on the same land mass

 

[Ulixes]

Hi Everybody,

I see there are new things to test, as always, really good job Whoward!

If nobody else is doing it, I'm going to test policies.

 

[whoward69]

If nobody else is doing it, I'm going to test policies.

Not as far as I'm aware. Note that I don't expect Policy_GreatWorkYieldChanges to work (as it uses the same logic for GA points as it does for Tourism, and Tourism is broken)

 

[Ulixes]

Tested all Policy Tables with YIELD_GOLDEN_AGE_POINTS

All tables work except, as you expected, "Policy_GreatWorkYieldChanges"
All the others work just fine, no problem noticed.

I'm going to test "Policy_PlotYieldChanges" and "Policy_TerrainYieldChanges" with all other Yields

 

[whoward69]

Tested all Policy Tables with YIELD_GOLDEN_AGE_POINTS

All tables work except, as you expected, "Policy_GreatWorkYieldChanges"
All the others work just fine, no problem noticed.

Cheers, I'll update post #2

 

[Ulixes]

tested "Policy_PlotYieldChanges" and "Policy_TerrainYieldChanges" with all other Yields:

Congratulations , everything works just fine, no problems noticed !

Later, if nobody will have already did it, I'll test beliefs tables

 

[Ulixes]

Sorry if it toke so long but I had troubles.
Here the first results:

The following tables work, no problem noticed:
Belief_ImprovementYieldChanges
Belief_YieldChangeNaturalWonder
Belief_ResourceYieldChanges
Belief_TerrainYieldChanges
Belief_YieldChangeAnySpecialist
Belief_FeatureYieldChanges

The following tables don't work

Belief_YieldChangeWorldWonder (higher numbers than expected, from 4 to 14 GA Points, increased when I entered in the city menu)
Belief_PlotYieldChanges (no GA point appeared on the mountain and the mountain tile was not selectable)

There are other tables that don't seem to work but I want to test them again.

I'm testing right now (slowly because I have to restart the game many times)

 

[Ulixes]

Other results:

This table worked: Belief_HolyCityYieldChanges

Those tables didn't:

Belief_BuildingClassYieldChanges (increasing numbers entering city screen)
Belief_CityYieldChanges (increasing numbers per turn 1, 3, 5...)
Belief_YieldChangePerXForeignFollowers (it does nothing)

 

[whoward69]

Post #2 and #3 updated with Ulixes latest results, and I've also finished testing the Improvements table

 

[Ulixes]

Those tables don't seem to work:

Belief_MaxYieldModifierPerFollower:
with 13 happiness and 11 followers there should be 1 GA point bonus, so I assume it doesn't work.

Belief_YieldChangeTradeRoute:
the bonus was correct in the first turn (+2), then was +8 in the second, +19 in the third

 

[Ulixes]

Here the last two:

This table works just fine:
Belief_YieldChangePerForeignCity

This table seem to do nothing at all:
Belief_YieldModifierNaturalWonder
(I assume the GA point should increase of x% in a city with a natural wonder,
anyway no GA point was added in any city, or on any tile or at national level

 

[whoward69]

 

[ExpiredReign]

Is that band playing this song?

 

[Ulixes]

 

[whoward69]

Except I've managed to break "FirstFinderGold" in the process (no idea how!)

 

[whoward69]

I've fixed FirstFinderGold (I actually broke it with a new event )

A quick update.

I missed a table for testing - Terrain_Yields - so if someone wants to quickly do that for all yield types ...

I've also added 7 new tables - Belief/Policy/Trait_YieldFromKills, Feature/Terrain_CoastalLandYields and Feature/Terrain_FreshWaterYields - and am in the process of adding 18 more - Belief_CapitalYieldChanges, Belief_CoastalCityYieldChanges, Belief_GreatWorkYieldChanges, Belief_SpecialistYieldChanges, Policy_FeatureYieldChanges, Policy_ResourceYieldChanges, Policy_SpecialistYieldChanges, Policy_YieldChangeTradeRoute, Policy_YieldChangeNaturalWonder, Policy_YieldChangeWorldWonder, Trait_CapitalYieldChanges, Trait_CityYieldChanges, Trait_CoastalCityYieldChanges, Trait_GreatWorkYieldChanges, Trait_FeatureYieldChanges, Trait_ResourceYieldChanges, Trait_YieldChangeTradeRoute, Trait_YieldChangeWorldWonder

At which point I'll release v58a for final testing. Then comes the joy of merging the code bases!

 

[Ulixes]

Tested "Terrain_Yields" table with all yields. Everything worked just fine.

I'm glad you solved the problem, waiting for v58!