DLL - Unified Yields

[whoward69]

Testing Terrain_Yields right now.

Thanks.

I'm not expecting any errors, just find it kinda funny that no one spotted it had been dropped off the bottom of the Terrains table

 

[Ulixes]

I didn't read your last post so I wrote the results in my previous post. However:

"Tested "Terrain_Yields" table with all yields. Everything worked just fine.

I'm glad you solved the problem, waiting for v58! "

 

[whoward69]

Thanks.

V58a is progressing nicely - so much so that I've updated post #2 with what's going to need testing!

 

[bane_]

What would you say is the percentage of the elephant eaten by now?
I honestly had fun doing these tests, winning by Tourism the turn after you meet other civs, having cities with 14 Citizens at the 16th turn, etc.

 

[whoward69]

What would you say is the percentage of the elephant eaten by now?

A good question. It all depends on which elephant The one labelled "Holy Grail 1" - probably about 10-15%. The one labelled "As much as I'm going to do for the time being" - about 90-95%

 

[bane_]

Cool.
I'm currently reading some manuals on C++, so if there is need for some grunt work to be done on the DLL part I'll be happy to try.
This way your's and Gazebo's knowledge can be better utilized for refined coding.

 

[whoward69]

winning by Tourism the turn after you meet other civs,

Which reminds me, I need to add a couple of defines to control TourismStartEra and/or TourismStartTech (defaults Ancient and Agriculture), before attaining which the player can't accumulate Tourism!

I honestly had fun doing these tests,

And the fun's not over yet - see post #2

 

[bane_]

Huzzah!
My testing mod is prep'd already. Waiting for the command(/DLL)...

 

[whoward69]

All new secondary tables (that I'm adding this time around) now compile ... and don't CTD during game start/setup

For the record

Features Improvements Terrains
#Feature_CoastalLandYields* Improvement_CoastalLandYields #Terrain_CoastalLandYields
#Feature_FreshWaterYields* Improvement_FreshWaterYields #Terrain_FreshWaterYields
Feature_HillsYieldChanges* Improvement_HillsYields Terrain_HillsYieldChanges
Feature_RiverYieldChanges* Improvement_RiverSideYields Terrain_RiverYieldChanges
#Feature_TechYieldChanges Improvement_TechYieldChanges #Terrain_TechYieldChanges
Feature_YieldChanges* Improvement_Yields Terrain_Yields

Beliefs Policies Traits
#Belief_CapitalYieldChanges Policy_CapitalYieldChanges #Trait_CapitalYieldChanges
Belief_CityYieldChanges Policy_CityYieldChanges #Trait_CityYieldChanges
#Belief_CoastalCityYieldChanges Policy_CoastalCityYieldChanges #Trait_CoastalCityYieldChanges
Belief_FeatureYieldChanges #Policy_FeatureYieldChanges #Trait_FeatureYieldChanges
#Belief_GreatWorkYieldChanges Policy_GreatWorkYieldChanges #Trait_GreatWorkYieldChanges
Belief_ImprovementYieldChanges Policy_ImprovementYieldChanges Trait_ImprovementYieldChanges
Belief_PlotYieldChanges #Policy_PlotYieldChanges #Trait_PlotYieldChanges
Belief_ResourceYieldChanges #Policy_ResourceYieldChanges #Trait_ResourceYieldChanges
#Belief_SpecialistYieldChanges #Policy_SpecialistYieldChanges Trait_SpecialistYieldChanges
Belief_TerrainYieldChanges #Policy_TerrainYieldChanges #Trait_TerrainYieldChanges
Belief_YieldChangeTradeRoute #Policy_YieldChangeTradeRoute #Trait_YieldChangeTradeRoute
Belief_YieldChangeNaturalWonder #Policy_YieldChangesNaturalWonder Trait_YieldChangesNaturalWonder
Belief_YieldChangeWorldWonder #Policy_YieldChangesWorldWonder #Trait_YieldChangesWorldWonder
#Belief_YieldFromKills #Policy_YieldFromKills #Trait_YieldFromKills

Beliefs Policies Traits
Belief_BuildingClassYieldChanges Policy_BuildingClassYieldChanges
Policy_BuildingClassYieldModifiers
Policy_CapitalYieldModifiers
Policy_CapitalYieldPerPopChanges
Trait_ExtraYieldThresholds
Policy_SpecialistExtraYields
Trait_UnimprovedFeatureYieldChanges
Belief_YieldChangeAnySpecialist
Trait_YieldChanges
Trait_YieldChangesIncomingTradeRoute
Trait_YieldChangesPerTradePartner
Trait_YieldChangesStrategicResources
Belief_YieldModifierNaturalWonder
Policy_YieldModifiers Trait_YieldModifiers

 

[whoward69]

V58a is now ready for testing, and can be downloaded from here

There are 207 entries to be tested - so if anyone else want's to help out, I'm sure bane_ and Ulixes will still have more than enough to keep themselves amused!

 

[Gazebo]

V58a is now ready for testing, and can be downloaded from here

I thought there were infinite numbers and we didn't need to resort to silly decimals or the alphabet?

G

 

[whoward69]

I thought there were infinite numbers and we didn't need to resort to silly decimals or the alphabet?

G

Now I know that you don't read the code

From CustomMods.h

#define MOD_DLL_VERSION_STATUS "a" // a (alpha), b (beta) or blank (released)

 

[Gazebo]

Now I know that you don't read the code

Reading is what I make my students do.

 

[whoward69]

Reading is what I make my students do.

QED

 

[whoward69]

As there are only 6 new tables left to test, please check post #2 before starting testing.

 

[bane_]

Testing what's left of the traits...

EDIT: Just realized my UnifiedYields.log was 6GB+.

Trait_YieldChangeTradeRoute and Trait_GreatWorkYieldChanges do not work, the latter does update the GreatWork tooltip, however.
Testing Trait_YieldChangesWorldWonder, btw, since we are trying to unify and all that, shouldn't we use the same convention when porting the names? I mean, the Belief counterpart is Belief_YieldChangeWorldWonder, in its singular form, instead of plural.

Hmm, I'm afraid Trait_YieldChangesWorldWonder didn't worked either. I'll test one of the already tested entry to make sure the problem isn't here in the operative layer.


I'm having a ton of these:

Spoiler :

[6343.094] no such column: PolicyType
[6343.094] In Query - select Yields.ID, Yield from Belief_YieldFromKills inner join Yields on YieldType = Yields.Type where PolicyType = ?
[6343.094] no such column: PolicyType
[6343.094] In Query - select Yields.ID, Yield from Belief_YieldFromKills inner join Yields on YieldType = Yields.Type where PolicyType = ?

With only the testing civilization, the v58a DLL and GameEditor loaded.


When testing Trait_CityYieldChanges, I only got a fraction of the input. I thought "Modifier" was the descrimination for % and "Change(s)" was a direct augmentation/reduction.

 

[bane_]

Okay, I must be screwing up really badly right now.

Spoiler :

<Policy_YieldChangesWorldWonder>
<Row>
<PolicyType>POLICY_HONOR</PolicyType>
<YieldType>YIELD_GOLD</YieldType>
<Yield>500</Yield>
</Row>
</Policy_YieldChangesWorldWonder>

Started working after I got a(ny) Belief... The same as with Policy_YieldChangeTradeRoute.

 

[whoward69]

When testing Trait_CityYieldChanges, I only got a fraction of the input.

I'd missed the fact that Firaxis multiply the change by 100 in one part of the code and then divided by 100 in a completely different part of the code, but haven't added the usual "Times100" to the end of the getter/setter - way to go!

Testing Trait_YieldChangesWorldWonder, btw, since we are trying to unify and all that, shouldn't we use the same convention when porting the names? I mean, the Belief counterpart is Belief_YieldChangeWorldWonder, in its singular form, instead of plural.

The problem is caused by Trait_YieldChangesNaturalWonder, should it be Trait_YieldChangesWorldWonder to match that or Trait_YieldChangeWorldWonder to match the (inconsistently) named Belief_YieldChangeWorldWonder. As almost every other table is Changes I went with consistency that way.

I'm having a ton of these:

Someone missed a search and replace for Policy(Type) with Belief(Type)

Okay, I must be screwing up really badly right now

Probably not. It's just the dregs left (ie the ones I couldn't test quickly) and I've already had to fix several issues with the Belief based tables not working for pantheon beliefs and the Policy tables just not working (they have a completely different methodology to the beliefs and traits)

 

[whoward69]

Trait_YieldChangeTradeRoute ...

Are you testing this against "Trade Routes" or "City Connections" - took me ages to work out that it's actually the latter (ie old style, pre-BNW trade routes) and not the former!

 

[bane_]

City connectinos, but in light of the recent comments, I'll try again with a VeryBigNumber (TM).
Although Policy_YieldChangeTradeRoute worked on a 1-per-1 basis... well, I'll try again anyway, nothing to lose.