DLL - Unified Yields

[bane_]

- Tested the first again, this time with Temple. The bonus kept re-adding itself, but not every turn; when I removed the Temple, the Tourism bonus was kept (ie, did not disappear with it's enabler) but did not rose anymore.

- Belief_YieldModifierNaturalWonder doesn't seem to do what it is supposed to, as far as I understand, unless it modifies it's own Yields? In which case I'm multiplying by 0.

- Belief_MaxYieldModifierPerFollower doesn't seem to work either. Even with big numbers.

Spoiler :

- Belief_PlotYieldChanges after enabling the custom options (as confirmed in the log) disables Pantheon founding:

...and that's turn 3 in Ancient Era.

 

[whoward69]

So to confirm, the following have been tested and (appear to) work correctly

• Belief_CityYieldChanges
• Belief_HolyCityYieldChanges
• Belief_FeatureYieldChanges
• Belief_ImprovementYieldChanges
• Belief_ResourceYieldChanges
• Belief_TerrainYieldChanges
• Belief_YieldChangePerForeignCity
• Belief_YieldChangePerXForeignFollowers

everything else in Beliefs I need to test and fix

 

[bane_]

Confirmed. Tested and retested all you just mentioned.

 

[Ulixes]

Keep up at the back - http://forums.civfanatics.com/showthread.php?t=528999

Great!

Tested the following Tables with tourism Yield.
They all worked as expected , no problem noticed.

Trait_ExtraYieldThresholds
Trait_ImprovementYieldChanges
Trait_SpecialistYieldChanges
Trait_UnimprovedFeatureYieldChanges
Trait_YieldChangesStrategicResources
Trait_YieldChanges
Trait_YieldModifiers

I'm testing the remaining two:
Trait_YieldChangesIncomingTradeRoute
Trait_YieldChangesPerTradePartner

EDITED:
"Trait_YieldChangesPerTradePartner" works fine, no problem noticed.

"Trait_YieldChangesIncomingTradeRoute" doesn't seems to work. The other player doesn't seems to receive the tourism bonus from the trade route.

 

[bane_]

Yields from Policies

Culture Faith Food Gold Production Science Tourism
Policy_BuildingClassYieldChanges test xml test xml xml xml test
Policy_BuildingClassYieldModifiers test test test xml test test test
Policy_CapitalYieldChanges test test test xml test xml test
Policy_CapitalYieldModifiers test test xml test test test brkn?¹
Policy_CapitalYieldPerPopChanges test test test xml test test test
Policy_CityYieldChanges xml test xml xml xml xml test
Policy_CoastalCityYieldChanges test test test test xml test test
Policy_GreatWorkYieldChanges xml test test test test test brkn
Policy_ImprovementYieldChanges test xml test xml xml xml test
Policy_SpecialistExtraYields test test test test test xml test*
Policy_YieldModifiers test test test test test test brkn? ²

¹ It works with every other yield change, but doesn't work with the Eiffel Tower nor faith-enabled buildings with the Reformation belief that gives +2 Tourism for each of them. (I made 12 runs with this one! )

² You probably already know that, but there is already a tooltip for this for Food (or was that your DLL working?)! "Misc. Player Modifier"
Also, this one seem to have the same limitations as it's Capital-only counterpart. Unless you can attest this with ease (like you did with the belief_s in page4), I can test this one with the others too.

* Even the tooltip shows the +2 Tourism from the Specialist!

==================

On another note, couldn't Unit_YieldFromKills work with Tourism if you somehow anchor the 'cultural hit' with the unit's owner? I don't know the limits of the DLL or the engine itself, so if this sounded stupid disregard.

 

[Ulixes]

Tested again "Building_ResourceYieldModifiers", didn't worked.

I tested it wit gold, production and tourism yields,
tried differnt buildings and numbers. No results, I didn't notice any bonus of any kind.

This table doesn't seem work, maybe I'm missing something but I really don't know what.

Maybe the original tester colud help me understand.

However, if there's no other explanation, I think you should change the "test" entry in the table with "impl" for this table, at least for production and gold (I can't make other tests on other yields today but at this point I think they will be the same)

Let me know if I can do something else.
Of course as you progress with DLL work, I will be glad to do other testing.

 

[JFD]

Tested again "Building_ResourceYieldModifiers", didn't worked.

I tested it wit gold, production and tourism yields

It should work with Production at least. I use it in my Peter the Great mod.

 

[Ulixes]

Thank you JFD, you're right.

My mistake, production works now.

I purchased the building after gaining the technology (instead of placing it without the required tech in the city with IGE) and it worked, I'm not sure why, but it worked.

Still, I did the same with tourism and didn't worked.
So, I have to confirm: "Building_ResourceYieldModifiers" doesn't work with tourism.

 

[whoward69]

Just to stir the interest again

(Also posts #2 and #3 have been updated - hopefully V57a will be stable in the next few days for my loyal testers to rip to shreds )

 

[Lord Tirian]

(Also posts #2 and #3 have been updated - hopefully V57a will be stable in the next few days for my loyal testers to rip to shreds )

Oooh, brilliant. By the way, seeing that... I think I'll revise the GA yield icon, the gold diamond with purple background is for great people, while the GA icon is just the gold diamond with a silver trim.

Should probably go for a plain black background or something grey/silver.

 

[whoward69]

It's easy enough to swap the texture sheets over now

 

[bane_]

Awesome!
More testing to come...

 

[whoward69]

V57a of the DLL mod is here

Please check post #2 for what needs testing, ie all the impl entries

Note that there are 5 new tables (1 building, 2 policy and 2 trait) to fully check

Please leave the "dash" (-) entries under Tourism for me to test; they have already been reported as "broken" and I'm in the process of working out why. I do not need further confirmation that they are still broken!

It would NOT surprise me if all the Golden Age yields that correspond to the "dash" (-) entries in the Tourism column are also broken.

Please note that V57a is NOT save game compatible with V56a and it is unlikely to be save game compatible with V58a

Enjoy!

W

 

[Gazebo]

You may earn CBE for this, Whoward. You just may.
G

 

[bane_]

Ok, testing Traits now.
Is it YIELD_GOLDEN_AGE or YIELD_GOLDENAGE? So far neither worked for me.

EDIT: I must be doing something wrong, nothing in the trait table worked for me (I didn't tried the two 'new' rows though). I tried them all three times with different yield names for Golden Age and with custom civs or editing Fireaxis files directly.

EDIT2: Forgot to ask: The tables for the new Trait rows are equal to their relatives (i.e. Building_PlotYieldChanges)?

 

[JFD]

Is it intentional that Policy_GreatWorkYieldChanges ignores the value set in the Yield column? It seems to yield +2, no matter the value one sets.

 

[whoward69]

You may earn CBE for this

Commander of the Borg Empire? - You have been assimilated

 

[whoward69]

Ok, testing Traits now.
Is it YIELD_GOLDEN_AGE or YIELD_GOLDENAGE? So far neither worked for me.

YIELD_GOLDEN_AGE_POINTS - I went with the same name in Gazebo's prior additions

 

[whoward69]

The tables for the new Trait rows are equal to their relatives (i.e. Building_PlotYieldChanges)?

Yes, and Building_PlotYieldChanges works the same for plot type as Building_TerrainYieldChanges does for terrain type

 

[whoward69]

Is it intentional that Policy_GreatWorkYieldChanges ignores the value set in the Yield column? It seems to yield +2, no matter the value one sets.

No, it's a bug