How to build and contribute to the Community Patch DLL

I'm going to release the new version today, so I'll post it all then, but in the future I'll post stuff as I work on it. I promise.

G

Did you update the Github? Maybe I'm just looking in the wrong place.. :confused:

\Skodkim
 
I need to add CvDistanceMap.h/.cpp CvGreatPersonInfo.h/.cpp to the build path.
It could be useful to say that in the tutorial.
 
Thanks for the push.

But, for me, the master branch is completely dammed: the Diplomacy/Diplomacy/Diplomacy (and again, again....) subfolders was screwed with windows 7 os. The only way to checkout the code after commit d06fbac2303a0ae3974a14b58a257aee59ed9d0e is to put the root folder inside my c:/ . Not funny.

One solution may be to replay the last 3 merge but without the unnecessary folders and files.
Or using win8? i didn't try yet.

One question: why not include Art?
 
Thanks for the push.

But, for me, the master branch is completely dammed: the Diplomacy/Diplomacy/Diplomacy (and again, again....) subfolders was screwed with windows 7 os. The only way to checkout the code after commit d06fbac2303a0ae3974a14b58a257aee59ed9d0e is to put the root folder inside my c:/ . Not funny.

One solution may be to replay the last 3 merge but without the unnecessary folders and files.
Or using win8? i didn't try yet.

One question: why not include Art?

I just need to sit down and fix it – I'll do that later tonight if I have time. This happens sometimes in modbuddy for reasons I have yet to figure out.

I'll add the art - it was not included at first to save bandwidth for my uploads.

G
 
Thanks for the push.

But, for me, the master branch is completely dammed: the Diplomacy/Diplomacy/Diplomacy (and again, again....) subfolders was screwed with windows 7 os. The only way to checkout the code after commit d06fbac2303a0ae3974a14b58a257aee59ed9d0e is to put the root folder inside my c:/ . Not funny.

One solution may be to replay the last 3 merge but without the unnecessary folders and files.
Or using win8? i didn't try yet.

One question: why not include Art?

Alright, I've completely re-uploaded the stuff - it should no longer have that folder bug, and should include everything.

G
 
Sorry for bumping this but I suspect you misunderstood my request earlier on. What I suggested was that you not only uploaded the new version to the Github but also changes you make to the code (non dll part) in between releases.

As mentioned before it makes it very easy for others to contribute to bug fixes, general changes etc. and some of the more experienced users may use some of the uploaded changes and find bugs before the release was made.

Of course its your call!!

\Skodkim
 
Sorry for bumping this but I suspect you misunderstood my request earlier on. What I suggested was that you not only uploaded the new version to the Github but also changes you make to the code (non dll part) in between releases.

As mentioned before it makes it very easy for others to contribute to bug fixes, general changes etc. and some of the more experienced users may use some of the uploaded changes and find bugs before the release was made.

Of course its your call!!

\Skodkim

That's the plan. When I'm working on the mod, I'll try to push out 'nightly builds' to Github. I plan on pushing one out tonight (though, in this case it'll come out alongside a release).
G
 
I just need to sit down and fix it – I'll do that later tonight if I have time. This happens sometimes in modbuddy for reasons I have yet to figure out.

Modbuddy maintains a nonsynchronized concept ofthe folder structure and it uses an extremely brittle strategy to resolve conflicts between what it thinks the project is and what the file system has actually got.

NEVER delete a folder with contents of any kind - file or directory
and NEVER EVER EVER relocate a folder.

In place of these, you must delete , recursively, manually, any tree node you want to remove, depth first. And you must generate folders in-place, manually move files, delete recursively as described above, and rename the destination directory, if you want to reorganize the project.
It goes without saying, don't use the file system itself to manipulate the project.

This probably isn't even every problem with that tool.
 
Modbuddy maintains a nonsynchronized concept ofthe folder structure and it uses an extremely brittle strategy to resolve conflicts between what it thinks the project is and what the file system has actually got.

NEVER delete a folder with contents of any kind - file or directory
and NEVER EVER EVER relocate a folder.

In place of these, you must delete , recursively, manually, any tree node you want to remove, depth first. And you must generate folders in-place, manually move files, delete recursively as described above, and rename the destination directory, if you want to reorganize the project.
It goes without saying, don't use the file system itself to manipulate the project.

This probably isn't even every problem with that tool.

I don't move files around (learned that a long time ago) and it still occasionally produces infinite hierarchies of files. :)

G
 
I tried to build a local repository today. My system does not make merging the folders easy, it asks me to either overwrite the files or not move the folders.

If this involves 1076 files I'm not supposed to copy, I'm guessing that manually merging the project with my SDK files is an entire day of work?

Local repository is probably the wrong word. Actually, 'work' is definitely the wrong word, too, since it would be not-smart work.
 
I tried to build a local repository today. My system does not make merging the folders easy, it asks me to either overwrite the files or not move the folders.

If this involves 1076 files I'm not supposed to copy, I'm guessing that manually merging the project with my SDK files is an entire day of work?

Local repository is probably the wrong word. Actually, 'work' is definitely the wrong word, too, since it would be not-smart work.

Are you trying to download the DLL? If so, just delete everything in your local file and import the DLL from github. It has all the files you need, or at least most of them. Your VS should auto-generate the files not on github.
G
 
What's all this about then
Merge the SDK libraries (and other invariant files) into the clone. Using Windows Explorer, copy the contents of CvGameCoreSource SDK sub-directory onto your git working directory "D:\gitroot\civ5\Community-Patch-DLL" - accept "merge" for the folders, but DO NOT OVERWRITE ANYTHING.
The repo at Gazebo doesn't have the VS file. I supply that from my SDK from Civ V, so this step isn't nothing. There's all the other contents of my CvGameCoreSource folder too, like CvGameDatabase/lib . You're saying if I open the studio project from the SDK, it will manufacture the files to make up the difference?

Is there any folder at all that I actually need to copy, because it looks to my nondiligent eye that the folders from the project are superset of CvGameCoreSource's folders.

I'm trying to build the local copy so I can work on it. Also so that I can fix whatever problem makes it not run on this specific machine (which I prefer) but does on my other one (which I hate).
 
Also, "this" machine is the only one with a development environment. The other one is unstable for some unknown hardware reason, I don't like doing work on it... which is ironic because it's the newer one with the newer OS and the better hardware that I bought for the purpose of doing work (and nothing else!) on it.

/vent

So, what do I copy? I have to do it manually, so what do I copy?
 
you shouldn't need to copy anything at all, you don't even need the sdk. the instructions are outdated in that regard, the git repo contains everything that is required now. just clone it and open CvGameCoreDLL_Expansion2\CvGameCoreDLL_Expansion2.vs2010.vcxproj

it builds right away. at least for me it does :)
 
I'll try to do that monopoly idea for exercise. ;)

EDIT - Is it possible to use Visual Studio 2013 to compile the Civ5 DLL? I get those errors:
Error 517 error C2665: 'CvLuaMethodWrapper<Derived,InstanceType>::BasicLuaMethod' : none of the 4 overloads could convert all the argument types C:\Program Files (x86)\Steam\SteamApps\common\Sid Meier's Civilization V SDK\CvGameCoreSource\CvGameCoreDLL\Lua\CvLuaPlayer.cpp 3477 1 CvGameCoreDLL
 
Back
Top Bottom