@ls612:
AIAndy apparently has a fairly involved concept as to how to improve this setup so that it won't create any possible drag on any loops through the class objects, which this would potentially have.
According to his last message to me on the subject, the XML may well be able to remain the same though so if you want to work on things, this is effectively ready for it and could perhaps only require the slightest of after adjustments.
It might even help to have your developments on the method in XML to aid in testing the coding conversion project he's got in mind. It's not that this mechanism doesn't work and as he said, wouldn't be a problem for traits. But it needs some improvement at his level of programming to be valid for units and promos and such.
You also might want to utilize the new GameOption tag(s) I implemented for designating Incompatible and Prerequisite Gameoptions.
That sounds great, I am done with Positive traits now and just need to write my Negative traits and add my option to the DLL. I'll be committing the new traits on Friday or Saturday along with a bunch of other stuff (I've built up quite a backlog), so at that point I will consider the option playable.