Modmodding Q&A Thread

[borhap88]

@ Borhap

I had the same problem some time ago, when I still edited XML files with just plain notepad. That convinced me to switching to Notepad++, which solved the issue.

You should delete the file you edited (also if you have reverted the changes) and download the file again. Then, make the changes with Notepad++. (This worked for me)

I guess the problem is connected to the saving of the file with the text editor you (and I when I had the problem) used.

It works!!! Thank you!!!

 

[borhap88]

@borhap again: as merijn said.

I finally found the technical explanation given some time ago by God-Emperor and it is here.

Now everything is clear, thank you!!!

 

[Leoreth]

Good to know, suspected something like that, just assumed Notepad++ would be smart enough here.

 

[BenZL43]

A pretty basic question haha:

It looks like this sentence

if iGameTurn >= getTurnForYear(-2970)

the effect happens not when the game change between year 3000BC to 2970BC, but between year 2970BC and 2940BC instead.

How should I write to make the effect happen between year 3000BC to 2970BC or exactly at 2970BC? Thanks ^^

 

[isenchine]

Try:

if (iGameTurn + 1) >= getTurnForYear(-2970)

I suppose you are in a similar function:

def onBeginGameTurn(self, argsList):
'Called at the beginning of the end of each turn'

and note what they say!..

 

[Leoreth]

Are you sure you want to use ">="? That means the condition will be true on the first turn and every subsequent turn.

 

[Novicenoble]

Ah. There were some questions here, but NVM. Problem solved

I still have some problems, but I am so glad that finally compiler worked properly.

 

[Novicenoble]

Question again. Where can I find Machu Picchu's food effect? It seems like they are not included in XML files.

 

[Leoreth]

Most effects that don't exist for wonders in the base game aren't in the XML. In case of the Machu Picchu wonder you can find its effect in Python in the onBuildingBuilt() method in RFCEventHandler.py.

 

[Novicenoble]

Most effects that don't exist for wonders in the base game aren't in the XML. In case of the Machu Picchu wonder you can find its effect in Python in the onBuildingBuilt() method in RFCEventHandler.py.

Ah found it. Thanks.

 

[Novicenoble]

Question train aboard.


I'm trying to make a modmod of 1.11v (SVN 540), so I downloaded SVN 540 to adjust C++ files.

1. While compiling C++ files, my VS Express 2008 said that there were 2 errors. They were typo grammar errors and I could fix it. But how could you compile them with that cpp files with grammar errors..? Is SVN files are identical with the files that used to compile DLL and release 1.11v?

2. After following whole processes in "How to add civ to DoC" thread, I tried to run with my files. Then the civ4 client said:

And there were some following errors (they said that were memory problems.) I suppose that these errors are related with DLL file. Does anyone have info about this kind of errors?

 

[Leoreth]

What do you mean by grammar errors? In the comments?

 

[Novicenoble]

What do you mean by grammar errors? In the comments?

Here are error messages from the buildlog

CvPlayer.cpp(10473) : error C3861: 'getHighestsNavalUnitLevel': identifier not found, even with argument-dependent lookup
NMAKE : warning U4010: 'Debug\CvPlayer.obj' : build failed; /K specified, continuing ...

CvPlot.cpp(10627) : error C2065: 'eTeam' : undeclared identifier
CvPlot.cpp(10628) : error C3861: 'eTeam': identifier not found, even with argument-dependent lookup
CvPlot.cpp(10655) : error C3861: 'eTeam': identifier not found, even with argument-dependent lookup
CvPlot.cpp(10656) : error C3861: 'eTeam': identifier not found, even with argument-dependent lookup
NMAKE : warning U4010: 'Debug\CvPlot.obj' : build failed; /K specified, continuing ...


'getHighestsNavalUnitLevel' was typo of 'getHighestNavalUnitLevel' and 'eTeam's in CvPlot.cpp should be changed to 'ePlayer'.

 

[Leoreth]

Ah, okay, you're compiling a debug target which is why the FAssert methods are checked.

 

[Novicenoble]

Ah, okay, you're compiling a debug target which is why the FAssert methods are checked.

Sorry, but would you explain some more details for programming newb?

I just followed ASAF's DLL compiling guide. (http://forums.civfanatics.com/showthread.php?t=405444)

 

[Leoreth]

Look at the dropdown menus next to the "execute" button in your IDE, you have selected "Debug" and "Win32" there (probably because it is the standard setting after setting up the compiler). Debug means that additional checks in the code are also executed, including those FAssert methods.

You should be able to select "Release" in the dropdown menu, which should not only result in a faster compilation time, but also in a DLL that runs faster.

 

[Novicenoble]

Yup. It worked properly.

Now I can't blame compiler anymore

 

[Novicenoble]

I hope I am not bothering you..

They seems like readpass problems, but I cannot figure out what's going on exactly. Can you give me any information about them?

 

[Leoreth]

Did you change the building XML?

 

[Novicenoble]

Did you change the building XML?

Yes, added an UB and embassy for Australia.