Modmodding Q&A Thread

[Imperator Knoedel]

Soooooo I have a fork I want to use for pull requests, but I can't figure out how to keep it up to date with your main branch. Is there a more elegant way than just deleting everything and making a new fork every few weeks when I want to make a new pull request?

 

[Leoreth]

What would I have to do to add a new scripted city like Samarkand or Jerusalem in addition to just adding a line in Barbs.py? I mean it seems to work by itself, but for some reason it throws a bunch of Python exceptions in 1200AD, coinciding with the spawn of Kazan, and I suspect it might be related to the total number of minor cities.

Did you update the iNumMinorCities constant? Otherwise the content of the Python exceptions would help.

Soooooo I have a fork I want to use for pull requests, but I can't figure out how to keep it up to date with your main branch. Is there a more elegant way than just deleting everything and making a new fork every few weeks when I want to make a new pull request?

Yes, here's a guide.

Most online Git guides assume you are using the command line client, but I'm sure you can figure out to find the right dialog options in Tortoise to do the equivalent. The important points are:
- when you do a pull to update your fork, the client should point to "origin" by default. This is your fork.
- you can add another source that points to the main DoC repo ("upstream" in the guide, but the name doesn't matter)
- then you can replace origin by upstream when doing a pull to get commits from the main repo

 

[Mouthwash]

How does the settling with more than one population work? It appears to depend on both civ and location (and era/tech?).

 

[Leoreth]

It's the same for all civs. It's their current era, plus one if it's an overseas colony after the discovery of Astronomy. The code is in CvCity::init().

 

[Mouthwash]

Is there any way to make it civ-specific? I could give them a settler UU if necessary.

 

[merijn_v1]

The Harappan UU is also defined there. You can take a look how that is done.

 

[Leoreth]

Yeah, both is possible. In fact even the Harappan UU ability is implemented as a civ ability for simplicity.

 

[merijn_v1]

IIRC, I've seen similar abilities done with python. +1 pop @oncityacquired.

 

[Mouthwash]

I can't find CvCity::init(), even after doing a file search in NotePad.

 

[Leoreth]

Search CvCity.cpp for ::init without parentheses, I usually leave out parameters when referencing methods.

 

[Mouthwash]

There is no file called CvCity.

 

[Leoreth]

In CvGameCoreDLL.

 

[Mouthwash]

Got it. Thanks!

 

[citis]

What does the iAsset and iPower do in the tech?

 

[Leoreth]

iAsset: determines how much this tech counts toward a player's score.
iPower: determines how the AI judges the military value of that tech (to evaluate an enemy's strength)

 

[Mouthwash]

I'm going crazy trying to find the art for your smokehouse. It isn't in the FPK files, and searching the entire assets folder didn't turn up one instance of the word.

 

[merijn_v1]

You know you can easily find the art location with the XML, right?

		<BuildingArtInfo>
			<Type>ART_DEF_BUILDING_SMOKEHOUSE</Type>
			<LSystem>LSYSTEM_1x1</LSystem>
			<bAnimated>0</bAnimated>
			<fScale>1.2</fScale>
			<fInterfaceScale>0.6</fInterfaceScale>
			[U]<NIF>Art/Structures/Buildings/Smokehouse/Smokehouse (Medieval).nif</NIF>[/U]
			<KFM/>
			<Button>Art/Structures/Buildings/Smokehouse/Button_Smokehouse.dds</Button>
		</BuildingArtInfo>

If it is in the FPK, it still follows that path.

 

[Mouthwash]

You know you can easily find the art location with the XML, right?

		<BuildingArtInfo>
			<Type>ART_DEF_BUILDING_SMOKEHOUSE</Type>
			<LSystem>LSYSTEM_1x1</LSystem>
			<bAnimated>0</bAnimated>
			<fScale>1.2</fScale>
			<fInterfaceScale>0.6</fInterfaceScale>
			[U]<NIF>Art/Structures/Buildings/Smokehouse/Smokehouse (Medieval).nif</NIF>[/U]
			<KFM/>
			<Button>Art/Structures/Buildings/Smokehouse/Button_Smokehouse.dds</Button>
		</BuildingArtInfo>

If it is in the FPK, it still follows that path.

Yes. It isn't in there. Which is what I just said.

Since file searches aren't always reliable, I went into both ArtDefines and BuildingInfos to search them individually. There's nothing in them called smokehouse.

 

[Leoreth]

How did you search the FPK?

 

[merijn_v1]

The definitely are in the Git version.

You can find all files here. You have to download them individually, but at least you have them. (click on the files and click "view raw" to download the files)
http://github.com/dguenms/Dawn-of-C...op/Assets/Art/Structures/Buildings/Smokehouse