Modmodding Q&A Thread

[adhiraj.bose]

Remove entirely. They would never spawn.

Okay then, how would I stop a civ from spawning.

 

[merijn_v1]

I think this is the easiest way. Open RiseAndFall.py and search for this function. Then add the last part of this snapshot. (if iCiv == iXXXX: ) Replace iXXX with the civ-const. You can find the civ-const in Consts.py. (e.g. France would be iFrance, Portugal = iPortugal etc.)

    def initBirth(self, iCurrentTurn, iBirthYear, iCiv): # iBirthYear is really year now, so no conversion prior to function call - edead
        print 'init birth in: '+str(iBirthYear)
        iHuman = utils.getHumanID()
        iBirthYear = getTurnForYear(iBirthYear) # converted to turns here - edead
      
        if iCiv in lSecondaryCivs:
            if iHuman != iCiv and not data.isPlayerEnabled(iCiv):
                return
              
        if iCiv == iXXXX:
            return

 

[freethink]

It's in the DLL (CvPlayer::getSoundtrackEra()), but it's also largely religion based only. The exception are east Asian civs receiving Confucian music with Buddhism.

Is it difficult to make a new era in the dll?
It would just be precolombian civs without a religion.

Is it civplayer.cvv??

I see the following

        if (eCurrentEra == ERA_CLASSICAL || eCurrentEra == ERA_MEDIEVAL || eCurrentEra == ERA_RENAISSANCE)
        {
            if (getID() == CHINA || getID() == MONGOLIA || getID() == JAPAN || getID() == KOREA)
            {
                return (EraTypes)ERA_EAST_ASIA;
            }
            else
            {
                return (EraTypes)ERA_SOUTH_ASIA;
            }
        }

So If I replace the ID with Inca, Aztec, Maya, it should work?

I guess if I wanted the music would change as soon as they got a religion it would require much more coding.
But just keeping until industrial era is not the worst.

So I wrote this

if (eCurrentEra == ERA_CLASSICAL || eCurrentEra == ERA_MEDIEVAL || eCurrentEra == ERA_RENAISSANCE)
        {
            if (getID() == INCA || getID() == AZTEC || getID() == MAYA)
            {
                return (EraTypes)ERA_NEW_WORLD;
            }
            else
            {
                return (EraTypes)ERA_RENNASANICE;
            }
        }
    }

Is anything wrong here

Moderator Action: Merged your posts and moved them to this thread. Please don't double post (there is an edit button) and use this thread for modding questions. Also, your posts are a lot easier to read if you use [ code ] tags for code. -- Leoreth

 

[freethink]

Did my pull request come through successfully? I am not sure.

 

[Leoreth]

I don't see one.

 

[freethink]

I'm confused, I put one there

 

[Leoreth]

Well, apparently not.

 

[freethink]

I think the request went through now.

 

[Leoreth]

No. For which repository are you attempting to create a PR?

 

[freethink]

No. For which repository are you attempting to create a PR?

For
dguenms/Dawn-of-Civilization

I thought.

 

[Leoreth]

Well as you can see on that page, there's no PR from you open.

 

[freethink]

Well as you can see on that page, there's no PR from you open.

But I see it, next to Mars Colony

 

[Leoreth]

Next to?

 

[freethink]

Next to?

Or rather above the Mars Colony pull request, out of five pull requests

 

[Leoreth]

Not for me. Did you point the PR against your own fork instead of the original repo?

 

[freethink]

Not for me. Did you point the PR against your own fork instead of the original repo?

I honestly wouldn't know.
When I go to your version. I see five pull requests, and that mine is the newest is at the top.
I see 'dguems/Dawn of Civilization at the top. Is there way I could still see your name even if I was pulling against my own fork.

When I made my pull request I compared your version with my fork.

When I click on the following link I see my request
https://github.com/dguenms/Dawn-of-Civilization/pulls

 

[Leoreth]

I don't.

 

[freethink]

I don't.

Then I need help because I am clearly lost, I have to put this pull quest here again and again. What could the problem be? On Github I am civplayer.

 

[Leoreth]

Are you? https://github.com/civplayer is a 404 for me.

 

[freethink]

You can see I have made a pull request here
https://postimg.cc/nCNKvJ8R