Naval Mines

EmperorFool · Feb 24, 2010

No, they are ANDs. Thus the name getPrereqAndTechs(), but GE is right about the single value controlling which tech panel it gets put on. I forgot about that part.

It's scary how much Civ4 API stuff I have learned but forgotten over the past 3 years. Guess my stack is overflowing. :lol:

Afforess · Feb 25, 2010

EmperorFool said:
No, they are ANDs. Thus the name getPrereqAndTechs(),

I guess I should have paid more attention in kindergarten, :lol:

EmperorFool said:
It's scary how much Civ4 API stuff I have learned but forgotten over the past 3 years. Guess my stack is overflowing.

No, it's more likely a buffer underrun.

OrionVeteran · Feb 25, 2010

EmperorFool said:
Yes, the array makes perfect sense, but the extra single-value accessor is odd. I suppose they had the single value first and then needed multiple values and added the array instead of replacing the single value. C'est la vie.

In that code, self.iUnit accesses a value from the screen. You won't have that. Instead you have the pUnit2.getUnitType().

Code:

pUnit2 = pPlot.getUnit(iUnitLoop) info = gc.getUnitInfo(pUnit2.getUnitType()) iMaxEra = -1 [COLOR="Red"][B]iTech = info.getPrereqAndTech()[/B][/COLOR] if iTech != -1: iEra = gc.getTechInfo(iTech).getEra() if iEra > iMaxEra: iMaxEra = iEra for i in range(gc.getNUM_AND_TECH_PREREQS()): iTech = info.getPrereqAndTechs(i) if iTech != -1: iEra = gc.getTechInfo(iTech).getEra() if iEra > iMaxEra: iMaxEra = iEra

iMaxEra is now the latest era of all required techs or -1 if there were no required techs. This assumes that eras are in natural order (they normally are).

I get the following error on the red line:

Attribute Error: "NoneType" object has no attribute getPrereqAndTech.

EmperorFool · Feb 25, 2010

Do you have the code above exactly as I have it?

Code:

info = gc.getUnitInfo(pUnit2.getUnitType())

Unless pUnit2.getUnitType() is returning NO_UNIT, info should be a valid CvUnitInfo. :confused:

OrionVeteran · Feb 26, 2010

EmperorFool said:
Do you have the code above exactly as I have it?

Code:

info = gc.getUnitInfo(pUnit2.getUnitType())

Unless pUnit2.getUnitType() is returning NO_UNIT, info should be a valid CvUnitInfo.

It is as you have it displayed. I'm confused too, as the error comes up on every other ship I move into the plot. Strange!

Orion Veteran :cool:

Afforess · Feb 26, 2010

Put a

Code:

if (info != -1):

check and see what happens.

OrionVeteran · Feb 26, 2010

Afforess said:
Put a

Code:

if (info != -1):

check and see what happens.

No change, the error persists.

OrionVeteran · Feb 26, 2010

Until we figure out this error, I have come up with a work around function that produces the correct Era for the specified unit.

Spoiler :

This function is called by the following:

Code:

pUnitUnitEra = getUnitEra(pUnitType)
Age = gc.getInfoTypeForString(pUnitUnitEra)

It is a good temporary solution to the problem. I stress temporary, because I would rather not require users of the mod to change this function everytime a new Naval unit is added to the game. So, if someone does finally figure out why we are getting the Attribute Error: "NoneType" object has no attribute getPrereqAndTech; I will use that code instead.

Orion Veteran :cool:

General Tso · Feb 26, 2010

Did you try the following?

Code:

[COLOR="DarkRed"]if info != None:[/COLOR]
	iTech = info.getPrereqAndTech()
	if iTech != -1:
		iEra = gc.getTechInfo(iTech).getEra()
		if iEra > iMaxEra:
			iMaxEra = iEra
	for i in range(gc.getNUM_AND_TECH_PREREQS()):
		iTech = info.getPrereqAndTechs(i)
		if iTech != -1:
			iEra = gc.getTechInfo(iTech).getEra()
			if iEra > iMaxEra:
				iMaxEra = iEra

I'm not totaly certain of this but from my experience it appears that there are pointers to non valid units on a plot when combat and/or movement occur. It appears that when Civ creates a new CvUnit object for a given unit or if a unit is killed, the old CvUnit object is kept until the end of the turn. When I ran accross this in the past I just altered the code to ignore them and everything worked OK. As I said above I'm not totally certain this is happening, but that's what it looks like to me. Has anybody else ever noticed this behavior?

Edit: "if not pUnit2.isNone():" Would be slightly more efficient, but I'm not sure if that works all of the time (i.e. when the unit is killed).

EmperorFool · Feb 26, 2010

How are you getting pUnitType?

In any case, you can check the unit type I'm getting against -1 before trying to look up the CvUnitInfo:

Code:

pUnit2 = pPlot.getUnit(iUnitLoop)
[B][COLOR="Red"]iUnitType = pUnit2.getUnitType()
if iUnitType != -1:[/COLOR][/B]
    info = gc.getUnitInfo([B][COLOR="Red"]iUnitType[/COLOR][/B])
    # rest of my code indented
    ...
[B][COLOR="Red"]else:
    iMaxEra = -1[/COLOR][/B]

OrionVeteran · Feb 27, 2010

EmperorFool said:
How are you getting pUnitType?

In any case, you can check the unit type I'm getting against -1 before trying to look up the CvUnitInfo:

Code:

pUnit2 = pPlot.getUnit(iUnitLoop) [B][COLOR="Red"]iUnitType = pUnit2.getUnitType() if iUnitType != -1:[/COLOR][/B] info = gc.getUnitInfo([B][COLOR="Red"]iUnitType[/COLOR][/B]) # rest of my code indented ... [B][COLOR="Red"]else: iMaxEra = -1[/COLOR][/B]

It Worked! :beer:

Note: For my purposes, I didn't need the iMaxEra.

Shiggs713 · Feb 27, 2010

hey OrionVeteran, if you need any sounds here ya go. Theres two different ones, I ripped em from AGEod's American Civil War game, but they were created from gamenoise.com so I'm assuming nobody will care if we use them.

OrionVeteran · Feb 28, 2010

Shiggs713 said:
hey OrionVeteran, if you need any sounds here ya go. Theres two different ones, I ripped em from AGEod's American Civil War game, but they were created from gamenoise.com so I'm assuming nobody will care if we use them.

Thanks for the sounds, but I had already pilfered a good explosion sound from YouTube. I created a link for the soon to be released Mine Warfare Mod:

http://forums.civfanatics.com/showthread.php?t=355343

I have put in many hours on this mod and it should be a big hit with the community.

Orion Veteran :cool:

OrionVeteran · Feb 28, 2010

Scenario: Say I have a unit that can move 3 squares per turn. I code python to give the unit a mission go to a specified plot. Is there a way to prevent the unit from making any further movements? In other words, I press the action button and now the unit is locked into place and has 0 movement capability. Any idea how this could be done?

EmperorFool · Feb 28, 2010

Are you saying it shouldn't move at all that turn? It should just queue up the order and drop its MPs to zero? I think there's a callback for groupPushMission() or something. Or you could create a new action.

OrionVeteran · Feb 28, 2010

EmperorFool said:
Are you saying it shouldn't move at all that turn? It should just queue up the order and drop its MPs to zero? I think there's a callback for groupPushMission() or something. Or you could create a new action.

I'm saying, once the unit is deployed to a specified plot, I don't want to be able to move it anymore. Kind of like a sentry command, only permanent.

EmperorFool · Feb 28, 2010

One way would be to make a second unit with the DOMAIN_IMMOBILE type and swap it out when the unit reaches its destination.

OrionVeteran · Feb 28, 2010

EmperorFool said:
One way would be to make a second unit with the DOMAIN_IMMOBILE type and swap it out when the unit reaches its destination.

I was thinking the same idea. Say I go for this concept. I already know how to terminate a unit with the kill command. How would I bring in a completely new unit to the plot?

EmperorFool · Mar 1, 2010

Instead of using kill() you create a new unit using initUnit() and then you convert the old unit to it (or vice versa, I forget). This makes sure to transfer over the XP, HP, etc. This is how upgrading works, so you can check CvUnit::upgrade() to see how it works.

OrionVeteran · Mar 1, 2010

EmperorFool said:
Instead of using kill() you create a new unit using initUnit() and then you convert the old unit to it (or vice versa, I forget). This makes sure to transfer over the XP, HP, etc. This is how upgrading works, so you can check CvUnit::upgrade() to see how it works.

Do you think this might work?

Spoiler :

Naval Mines

Deity

The White Wizard

Deity

Deity

Deity

The White Wizard

Deity

Deity

Panzer General

Deity

Deity

Immortal

Deity

Deity

Deity

Deity

Deity

Deity

Deity

Deity

Similar threads