New Beta Patch - 2/4

[Recursive]

I'm having trouble reproducing the bug with impossible peace deals, so I'm gonna ask for some community help here.

If anyone could replace the DLL and PDB files in their MODS > (1) Community Patch folder with the ones I attached to this post, use no other mods, reproduce the bug, then send/post a save file, it would be much appreciated and I could debug the problem instantly.

Unfortunately you need the debug DLL to run the debugger, and savegames from the release DLL (which is better optimized) are not compatible with debug DLL saves.

But if I'm given a save file that uses the debug config, I can run the debugger and instantly figure out why it's malfunctioning.

 

[Recursive]

Is everything allright with building cost? Here is my city when selecting a building and selecting unit (Knight).

Looks like Modifier for unit combat class reduces my production instead of increasing it. Am I missing something?

Definitely a bug, please report on Github!

 

[Solic]

I'm having trouble reproducing the bug with impossible peace deals, so I'm gonna ask for some community help here.

If anyone could replace the DLL and PDB files in their MODS > (1) Community Patch folder with the ones I attached to this post, use no other mods, reproduce the bug, then send/post a save file, it would be much appreciated and I could debug the problem instantly.

Unfortunately you need the debug DLL to run the debugger, and savegames from the release DLL (which is better optimized) are not compatible with debug DLL saves.

But if I'm given a save file that uses the debug config, I can run the debugger and instantly figure out why it's malfunctioning.

:/ I tried this out and it did work now. I tried to reproduce this quickly so went with a lower difficulty and as Aztecs. Just conquered a capital as soon as Netherlands made their second city. With war score 100, I could peace out easily. First try, I made the war happen by being too close to the borders and declaring this way. Second try I reloaded a few turns before and declared myself. Could peace out after I had conquered it both times.

I do use mods normally, so maybe it's a conflict there? I think I can run this debug DLL for regular games I play and report it if I encounter it there again, but I would like to play with mods like 4 UC and More Resources. If those games are useless to debug, then I can't find it for you.

 

[Recursive]

:/ I tried this out and it did work now. I tried to reproduce this quickly so went with a lower difficulty and as Aztecs. Just conquered a capital as soon as Netherlands made their second city. With war score 100, I could peace out easily. First try, I made the war happen by being too close to the borders and declaring this way. Second try I reloaded a few turns before and declared myself. Could peace out after I had conquered it both times.

I do use mods normally, so maybe it's a conflict there? I think I can run this debug DLL for regular games I play and report it if I encounter it there again, but I would like to play with mods like 4 UC and More Resources. If those games are useless to debug, then I can't find it for you.

Actually it should work with other mods, but include your extra mods in your savegame folder so I can copy them exactly, otherwise I can't load the save.

Note that the debug DLL is less optimized so expect a performance hit.

 

[airbse]

I'm having trouble reproducing the bug with impossible peace deals, so I'm gonna ask for some community help here.

If anyone could replace the DLL and PDB files in their MODS > (1) Community Patch folder with the ones I attached to this post, use no other mods, reproduce the bug, then send/post a save file, it would be much appreciated and I could debug the problem instantly.

Unfortunately you need the debug DLL to run the debugger, and savegames from the release DLL (which is better optimized) are not compatible with debug DLL saves.

But if I'm given a save file that uses the debug config, I can run the debugger and instantly figure out why it's malfunctioning.

replaced dll and pdb with your attachments, loaded broken save successfully, played one turn, peacing out with polynesia still "impossible", made new save (attached incl. 34UC mod).

thanks a lot for your efforts!

 

[Zarrk]

Hello I'm starting a new game with hotfix 3 but I noticed a small problem: mousing over the Culture Icon in the top bar fail to create the toolip, it just say "Brief description" or show the Faith tooltip shall I mouse over this one before.
I reinstalled VP 12-1-3 and saw no problem but as soon as I add beta-2-4 it stop working.

This is what I found in log.lua:

(6a) Community Balance Overhaul - Compatibility Files (EUI)\LUA\TopPanel.lua:1624: attempt to call method 'GetJONSCulturePerTurnFromMinorCivs' (a nil value)

 

[psparky]

Unfortunately you need the debug DLL to run the debugger, and savegames from the release DLL (which is better optimized) are not compatible with debug DLL saves.

That seems like a major obstacle to bug investigation; in the past, saves from the debug and non-debug versions were compatible. Maybe we should consider undoing whatever optimization is causing them to be incompatible, at least for beta versions.

 

[Solic]

replaced dll and pdb with your attachments, loaded broken save successfully, played one turn, peacing out with polynesia still "impossible", made new save (attached incl. 34UC mod).

thanks a lot for your efforts!

I tried to replicate it again with my normal mods on, but wasn't able to. Didn't know I could have just tried to reload my old save, where I found the bug initially. Let me know if it's still necessary and I'll keep the debug settings for when I play next. (Computer seems to be able to handle lower performance just fine)

 

[Recursive]

replaced dll and pdb with your attachments, loaded broken save successfully, played one turn, peacing out with polynesia still "impossible", made new save (attached incl. 34UC mod).

thanks a lot for your efforts!

Thank you! I'll look at this immediately.

Maybe it is savegame compatible after all? My information might be outdated...

Hello I'm starting a new game with hotfix 3 but I noticed a small problem: mousing over the Culture Icon in the top bar fail to create the toolip, it just say "Brief description" or show the Faith tooltip shall I mouse over this one before.
I reinstalled VP 12-1-3 and saw no problem but as soon as I add beta-2-4 it stop working.

This is what I found in log.lua:

(6a) Community Balance Overhaul - Compatibility Files (EUI)\LUA\TopPanel.lua:1624: attempt to call method 'GetJONSCulturePerTurnFromMinorCivs' (a nil value)

Whoops, my bad. Will fix in the next hotfix.

 

[Recursive]

AHA! Found it

A bug was setting the trade value of peace with allied City-States to impossible if there was a denouncement in either direction. I just moved the anti-exploit check lower in the function.

 

[ilteroi]

That seems like a major obstacle to bug investigation; in the past, saves from the debug and non-debug versions were compatible. Maybe we should consider undoing whatever optimization is causing them to be incompatible, at least for beta versions.

saves were never reliably compatible between debug and release. you are welcome to fix the serialization.

 

[Recursive]

Fourth and hopefully last hotfix posted. Fixes impossible peace deal bug and culture overview, adds in some changes from HungryForFood, adjusts diplo values for competition/non-competition.

Savegame compatible.

OP's files have been updated.

 

[WizePony]

Great! Thanks for your hard work!

 

[glaivemaster]

AHA! Found it

A bug was setting the trade value of peace with allied City-States to impossible if there was a denouncement in either direction. I just moved the anti-exploit check lower in the function.

Sorry I missed the debugger request, but glad you got it sorted. Echoing thanks for the hard work and quick turnaround!

 

[Laz0r]

Woah sir, I think you've been stealing ideas from civ 6 without giving credit by making barbarians NOT pathetic pushovers . But really, barbarians being able to heal sounds great from both a flavor and a balance perspective given how easy it was to wipe them out with 3 warriors and a scout tops even with raging barbs. Nice to see they're actually going to be a bit more tenacious and more of a challenge to overcome instead of free experience (and yields).

 

[Stalker0]

Woah sir, I think you've been stealing ideas from civ 6 without giving credit by making barbarians NOT pathetic pushovers . But really, barbarians being able to heal sounds great from both a flavor and a balance perspective given how easy it was to wipe them out with 3 warriors and a scout tops even with raging barbs. Nice to see they're actually going to be a bit more tenacious and more of a challenge to overcome instead of free experience (and yields).

Just noting if anyone wants to have fun with Barbs, play Communitas_79 with low sea levels. You will get a heck of a barb experience that way.

 

[Recursive]

FINALLY FIXED THE COOP WAR BUG!

AND IT WAS SO SIMPLE TOO, I FEEL DUMB! I was staring at the code for like an hour and I didn't find it. Thanks for the save file @Kim Dong Un.

CvDiplomacyAI::IsValidCoopWarTarget()

   // Can't be already at war with the target
    if (IsAtWar(eTargetPlayer))
        return false;

What was happening is one player declared war early, setting the "at war" flag to true, and then this check would be called via CanStartCoopWar().

At this point the code is supposed to check if both players can start a coop war, which ignores the "can declare war" check in certain situations, but I forgot to remove this "IsAtWar" check that I added early on - and which also checks if the target is valid if you DON'T have a planned coop war.

 

[Recursive]

As thanks, I shall post a hotfix with the coop war bug fixed.

Hotfix 5 posted. Fixes the coop war bug.

OP's files have been updated.

 

[AndreyK]

Something changed with deals - when deal is worth 200 then AI is willing to pay 350-400 ( 5-6 gpt in epic), when before they never paid more than 3 gpt

 

[Willy_the_Kid]

As thanks, I shall post a hotfix with the coop war bug fixed.

Hotfix 5 posted. Fixes the coop war bug.

OP's files have been updated.

Is this one save game compatible?