Promotion Flags EUI 1.1

[Infixo]

However, since I'm not completely useless, I took a shot at it. Do you think this would work @Infixo ?

I can"t even remember what was all that fuzz about half a year ago...
The duration of the promotion that goes into the tooltip comes from these lines:

           local sDurationTip = ""
           if unit:GetPromotionDuration(unitPromotionID) > 0 then
               sDurationTip = " (" .. Locale.ConvertTextKey("TXT_KEY_STR_TURNS", unit:GetPromotionDuration(unitPromotionID) - (Game.GetGameTurn() - unit:GetTurnPromotionGained(unitPromotionID))) .. ")"
           end

It seems that you used them, but I don't know the rest of the code.

 

[civplayer33]

I updated my fix and tested it thoroughly now; it works without issue.
I also updated some other parts of the file to fit with the 11-30-18 version of VP.

You can download it (then extract it) and replace the UI/UnitPanel.lua with this one to have all the functionality; you should probably also update the modinfo file with the new MD5: 8A2127E2D3ED0CC7FF7DE36B19A02689
Also, delete the files in your cache and ModSettings folders just to be sure that the changes take effect properly.

 

[ryanmusante]

I updated my fix and tested it thoroughly now; it works without issue.
I also updated some other parts of the file to fit with the 11-30-18 version of VP.

I updated mine with the file. What other parts were modified to fit with VP? Is there anything significant from 12-3 to the non-beta 11-30 patch? I see this was added to corresponding areas.

        g_MaxDamage = unit:GetMaxHitPoints();

 

[civplayer33]

What other parts were modified to fit with VP? Is there anything significant from 12-3 to the non-beta 11-30 patch? I see this was added to corresponding areas.

Yeah that is part of the changes that VP has made to the file in the last 6 months up to version 11-30-18; I basically merged all changes into the file, if they didn't interfere with the Promotions EUI changes with the exception of the promo duration part. I don't know if VP has updated the UnitPanel.lua in the latest beta and I can't easily test it since the manual download link doesn't have the new beta and I don't wanna use the installer to check since then I'd have to install the beta just to get the file and then reinstall my other version with all the mods...too much hassle, sorry. But you can check this for yourself, if you have the UnitPanel.lua from the newest beta by comparing it with the file from the 11-30-18 version (unmodified) which I'll attach here.
Edit: this file is taken from the (6a) CBO Compatibility Files (EUI) folder of the 11-30-18 version, to be precise

 

[ryanmusante]

Yeah that is part of the changes that VP has made

Could you merge Condensed Promotions into the mod? It changes the UnitPanel.lua and UnitPanel(_small).xml core files. I feel it would be great to have as a part of its base.

http://www.picknmixmods.com/mods/CivV/UI/Condensed Promotions.html

 

[civplayer33]

Could you merge Condensed Promotions into the mod?

This functionality is actually already part of VP, I believe, at least the VP EUI version.

 

[ryanmusante]

There was a discussion about it here:

https://forums.civfanatics.com/threads/condensed-promotions.631961/

 

[civplayer33]

There was a discussion about it here:

https://forums.civfanatics.com/threads/condensed-promotions.631961/

In my current game the functionality is present and I'm not using that mod. You can check here what mods I'm using; one of them is doing it and I vaguely remember that it was part of VP (6a) when I was merging in some stuff.

 

[ryanmusante]

+ Appropriate GG/GA

I meant to ask you, what is this? Can you link it for me?

 

[civplayer33]

Can you link it for me?

here you go
It adds a "Created" promotion to each unit, though, which sorta contributes to the clogging of promotions, unfortunately, albeit only slightly. Also, the icon that is chosen for it with VP Promo Icons is pretty bad and too "flashy" so I used the awesome custom promo functionality of VP Promo Icons to change the icon to something more bland. So I dunno whether I'll be using it again; I like that I finally get GG and GA that fit with my civ but the extra promo thing is not so great.

 

[Asterix Rage]

Great

...Also, the icon that is chosen for it with VP Promo Icons is pretty bad and too "flashy" so I used the awesome custom promo functionality of VP Promo Icons to change the icon to something more bland...

I was asking myself if someone find \VP Promo Icons (v 1.9)\extra_VPPI_icons.jpg usefull
You do. It makes me at ease.

You are right. PROMOTION_CREATED in CIV-LGG need a more sober symbol than one from extra_VPPI_icons.
It will be in a next version of VP Promo Icons

edit: a sort of bland icon

 

[civplayer33]

You are right. PROMOTION_CREATED in CIV-LGG need a more sober symbol than one from extra_VPPI_icons.
It will be in a next version of VP Promo Icons

I'm using Extra_04#18 for it now; just makes it less striking since the default one looks so crazy with the lightning and medic sign that one may think it's the most OP promo ever when it really doesn't even do anything

Will you also add promo icons for MUCfVP? I am using that mod right now and getting the yellow triangle on my units for the extra promo of Germany in MUCfVP (Chapter), which is not too bad since I think it's actually the only yellow triangle promo in my current game, but just wanted to inquire anyway. Love your mod btw

 

[Asterix Rage]

Will you also add promo icons for MUCfVP?

I'm on it. Slowly. It will be done ...in 2019

 

[Mantis Toboggan M.D.]

Is there a version of this mod that can be used in non modded games? Like you can use EUI in non modded games because it's treated like DLC.

 

[mbbcam]

@joehedaya1 Try this: https://forums.civfanatics.com/threads/modmod-thal´s-flagpromotions-for-cpp.547864/